diff options
| author | nsfisis <nsfisis@gmail.com> | 2025-12-31 02:15:17 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2025-12-31 02:15:17 +0900 |
| commit | ed93dd099f43dd6746276a72953485de91b49c8c (patch) | |
| tree | db737032e32508b7de24d94696a13e4bfebe8978 /src/server | |
| parent | 78609e0b390e9a485c8935c17db6e0093660ebef (diff) | |
| download | kioku-ed93dd099f43dd6746276a72953485de91b49c8c.tar.gz kioku-ed93dd099f43dd6746276a72953485de91b49c8c.tar.zst kioku-ed93dd099f43dd6746276a72953485de91b49c8c.zip | |
feat(sync): add sync support for note-related entities
Extend the sync system to handle NoteType, NoteFieldType, Note, and
NoteFieldValue entities. This includes:
- Server sync repository and routes for push/pull of new entities
- Client sync queue, push, pull, and conflict resolution for notes
- Update Card sync to include noteId and isReversed fields
- Add comprehensive tests for all sync functionality
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Diffstat (limited to 'src/server')
| -rw-r--r-- | src/server/repositories/sync.ts | 535 | ||||
| -rw-r--r-- | src/server/routes/sync.test.ts | 370 | ||||
| -rw-r--r-- | src/server/routes/sync.ts | 46 |
3 files changed, 940 insertions, 11 deletions
diff --git a/src/server/repositories/sync.ts b/src/server/repositories/sync.ts index 3e9f8ed..ac9b336 100644 --- a/src/server/repositories/sync.ts +++ b/src/server/repositories/sync.ts @@ -1,7 +1,23 @@ import { and, eq, gt, sql } from "drizzle-orm"; import { db } from "../db/index.js"; -import { cards, decks, reviewLogs } from "../db/schema.js"; -import type { Card, Deck, ReviewLog } from "./types.js"; +import { + cards, + decks, + noteFieldTypes, + noteFieldValues, + noteTypes, + notes, + reviewLogs, +} from "../db/schema.js"; +import type { + Card, + Deck, + Note, + NoteFieldType, + NoteFieldValue, + NoteType, + ReviewLog, +} from "./types.js"; /** * Sync data types for push/pull operations @@ -10,6 +26,10 @@ export interface SyncPushData { decks: SyncDeckData[]; cards: SyncCardData[]; reviewLogs: SyncReviewLogData[]; + noteTypes: SyncNoteTypeData[]; + noteFieldTypes: SyncNoteFieldTypeData[]; + notes: SyncNoteData[]; + noteFieldValues: SyncNoteFieldValueData[]; } export interface SyncDeckData { @@ -25,6 +45,8 @@ export interface SyncDeckData { export interface SyncCardData { id: string; deckId: string; + noteId: string | null; + isReversed: boolean | null; front: string; back: string; state: number; @@ -52,13 +74,61 @@ export interface SyncReviewLogData { durationMs: number | null; } +export interface SyncNoteTypeData { + id: string; + name: string; + frontTemplate: string; + backTemplate: string; + isReversible: boolean; + createdAt: string; + updatedAt: string; + deletedAt: string | null; +} + +export interface SyncNoteFieldTypeData { + id: string; + noteTypeId: string; + name: string; + order: number; + fieldType: string; + createdAt: string; + updatedAt: string; + deletedAt: string | null; +} + +export interface SyncNoteData { + id: string; + deckId: string; + noteTypeId: string; + createdAt: string; + updatedAt: string; + deletedAt: string | null; +} + +export interface SyncNoteFieldValueData { + id: string; + noteId: string; + noteFieldTypeId: string; + value: string; + createdAt: string; + updatedAt: string; +} + export interface SyncPushResult { decks: { id: string; syncVersion: number }[]; cards: { id: string; syncVersion: number }[]; reviewLogs: { id: string; syncVersion: number }[]; + noteTypes: { id: string; syncVersion: number }[]; + noteFieldTypes: { id: string; syncVersion: number }[]; + notes: { id: string; syncVersion: number }[]; + noteFieldValues: { id: string; syncVersion: number }[]; conflicts: { decks: string[]; cards: string[]; + noteTypes: string[]; + noteFieldTypes: string[]; + notes: string[]; + noteFieldValues: string[]; }; } @@ -70,6 +140,10 @@ export interface SyncPullResult { decks: Deck[]; cards: Card[]; reviewLogs: ReviewLog[]; + noteTypes: NoteType[]; + noteFieldTypes: NoteFieldType[]; + notes: Note[]; + noteFieldValues: NoteFieldValue[]; currentSyncVersion: number; } @@ -87,9 +161,17 @@ export const syncRepository: SyncRepository = { decks: [], cards: [], reviewLogs: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], conflicts: { decks: [], cards: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], }, }; @@ -200,6 +282,8 @@ export const syncRepository: SyncRepository = { .values({ id: cardData.id, deckId: cardData.deckId, + noteId: cardData.noteId, + isReversed: cardData.isReversed, front: cardData.front, back: cardData.back, state: cardData.state, @@ -235,6 +319,8 @@ export const syncRepository: SyncRepository = { .update(cards) .set({ deckId: cardData.deckId, + noteId: cardData.noteId, + isReversed: cardData.isReversed, front: cardData.front, back: cardData.back, state: cardData.state, @@ -333,6 +419,357 @@ export const syncRepository: SyncRepository = { } } + // Process note types with Last-Write-Wins conflict resolution + for (const noteTypeData of data.noteTypes) { + const clientUpdatedAt = new Date(noteTypeData.updatedAt); + + // Check if note type exists and belongs to user + const existing = await db + .select({ + id: noteTypes.id, + updatedAt: noteTypes.updatedAt, + syncVersion: noteTypes.syncVersion, + }) + .from(noteTypes) + .where( + and(eq(noteTypes.id, noteTypeData.id), eq(noteTypes.userId, userId)), + ); + + if (existing.length === 0) { + // New note type - insert + const [inserted] = await db + .insert(noteTypes) + .values({ + id: noteTypeData.id, + userId, + name: noteTypeData.name, + frontTemplate: noteTypeData.frontTemplate, + backTemplate: noteTypeData.backTemplate, + isReversible: noteTypeData.isReversible, + createdAt: new Date(noteTypeData.createdAt), + updatedAt: clientUpdatedAt, + deletedAt: noteTypeData.deletedAt + ? new Date(noteTypeData.deletedAt) + : null, + syncVersion: 1, + }) + .returning({ id: noteTypes.id, syncVersion: noteTypes.syncVersion }); + + if (inserted) { + result.noteTypes.push({ + id: inserted.id, + syncVersion: inserted.syncVersion, + }); + } + } else { + const serverNoteType = existing[0]; + if (serverNoteType && clientUpdatedAt > serverNoteType.updatedAt) { + // Client wins - update + const [updated] = await db + .update(noteTypes) + .set({ + name: noteTypeData.name, + frontTemplate: noteTypeData.frontTemplate, + backTemplate: noteTypeData.backTemplate, + isReversible: noteTypeData.isReversible, + updatedAt: clientUpdatedAt, + deletedAt: noteTypeData.deletedAt + ? new Date(noteTypeData.deletedAt) + : null, + syncVersion: sql`${noteTypes.syncVersion} + 1`, + }) + .where(eq(noteTypes.id, noteTypeData.id)) + .returning({ + id: noteTypes.id, + syncVersion: noteTypes.syncVersion, + }); + + if (updated) { + result.noteTypes.push({ + id: updated.id, + syncVersion: updated.syncVersion, + }); + } + } else if (serverNoteType) { + // Server wins - mark as conflict + result.conflicts.noteTypes.push(noteTypeData.id); + result.noteTypes.push({ + id: serverNoteType.id, + syncVersion: serverNoteType.syncVersion, + }); + } + } + } + + // Process note field types with Last-Write-Wins conflict resolution + for (const fieldTypeData of data.noteFieldTypes) { + const clientUpdatedAt = new Date(fieldTypeData.updatedAt); + + // Verify parent note type belongs to user + const noteTypeCheck = await db + .select({ id: noteTypes.id }) + .from(noteTypes) + .where( + and( + eq(noteTypes.id, fieldTypeData.noteTypeId), + eq(noteTypes.userId, userId), + ), + ); + + if (noteTypeCheck.length === 0) { + // Parent note type doesn't belong to user, skip + continue; + } + + // Check if note field type exists + const existing = await db + .select({ + id: noteFieldTypes.id, + updatedAt: noteFieldTypes.updatedAt, + syncVersion: noteFieldTypes.syncVersion, + }) + .from(noteFieldTypes) + .where(eq(noteFieldTypes.id, fieldTypeData.id)); + + if (existing.length === 0) { + // New note field type - insert + const [inserted] = await db + .insert(noteFieldTypes) + .values({ + id: fieldTypeData.id, + noteTypeId: fieldTypeData.noteTypeId, + name: fieldTypeData.name, + order: fieldTypeData.order, + fieldType: fieldTypeData.fieldType, + createdAt: new Date(fieldTypeData.createdAt), + updatedAt: clientUpdatedAt, + deletedAt: fieldTypeData.deletedAt + ? new Date(fieldTypeData.deletedAt) + : null, + syncVersion: 1, + }) + .returning({ + id: noteFieldTypes.id, + syncVersion: noteFieldTypes.syncVersion, + }); + + if (inserted) { + result.noteFieldTypes.push({ + id: inserted.id, + syncVersion: inserted.syncVersion, + }); + } + } else { + const serverFieldType = existing[0]; + if (serverFieldType && clientUpdatedAt > serverFieldType.updatedAt) { + // Client wins - update + const [updated] = await db + .update(noteFieldTypes) + .set({ + noteTypeId: fieldTypeData.noteTypeId, + name: fieldTypeData.name, + order: fieldTypeData.order, + fieldType: fieldTypeData.fieldType, + updatedAt: clientUpdatedAt, + deletedAt: fieldTypeData.deletedAt + ? new Date(fieldTypeData.deletedAt) + : null, + syncVersion: sql`${noteFieldTypes.syncVersion} + 1`, + }) + .where(eq(noteFieldTypes.id, fieldTypeData.id)) + .returning({ + id: noteFieldTypes.id, + syncVersion: noteFieldTypes.syncVersion, + }); + + if (updated) { + result.noteFieldTypes.push({ + id: updated.id, + syncVersion: updated.syncVersion, + }); + } + } else if (serverFieldType) { + // Server wins - mark as conflict + result.conflicts.noteFieldTypes.push(fieldTypeData.id); + result.noteFieldTypes.push({ + id: serverFieldType.id, + syncVersion: serverFieldType.syncVersion, + }); + } + } + } + + // Process notes with Last-Write-Wins conflict resolution + for (const noteData of data.notes) { + const clientUpdatedAt = new Date(noteData.updatedAt); + + // Verify parent deck belongs to user + const deckCheck = await db + .select({ id: decks.id }) + .from(decks) + .where(and(eq(decks.id, noteData.deckId), eq(decks.userId, userId))); + + if (deckCheck.length === 0) { + // Parent deck doesn't belong to user, skip + continue; + } + + // Check if note exists + const existing = await db + .select({ + id: notes.id, + updatedAt: notes.updatedAt, + syncVersion: notes.syncVersion, + }) + .from(notes) + .where(eq(notes.id, noteData.id)); + + if (existing.length === 0) { + // New note - insert + const [inserted] = await db + .insert(notes) + .values({ + id: noteData.id, + deckId: noteData.deckId, + noteTypeId: noteData.noteTypeId, + createdAt: new Date(noteData.createdAt), + updatedAt: clientUpdatedAt, + deletedAt: noteData.deletedAt + ? new Date(noteData.deletedAt) + : null, + syncVersion: 1, + }) + .returning({ id: notes.id, syncVersion: notes.syncVersion }); + + if (inserted) { + result.notes.push({ + id: inserted.id, + syncVersion: inserted.syncVersion, + }); + } + } else { + const serverNote = existing[0]; + if (serverNote && clientUpdatedAt > serverNote.updatedAt) { + // Client wins - update + const [updated] = await db + .update(notes) + .set({ + deckId: noteData.deckId, + noteTypeId: noteData.noteTypeId, + updatedAt: clientUpdatedAt, + deletedAt: noteData.deletedAt + ? new Date(noteData.deletedAt) + : null, + syncVersion: sql`${notes.syncVersion} + 1`, + }) + .where(eq(notes.id, noteData.id)) + .returning({ id: notes.id, syncVersion: notes.syncVersion }); + + if (updated) { + result.notes.push({ + id: updated.id, + syncVersion: updated.syncVersion, + }); + } + } else if (serverNote) { + // Server wins - mark as conflict + result.conflicts.notes.push(noteData.id); + result.notes.push({ + id: serverNote.id, + syncVersion: serverNote.syncVersion, + }); + } + } + } + + // Process note field values with Last-Write-Wins conflict resolution + for (const fieldValueData of data.noteFieldValues) { + const clientUpdatedAt = new Date(fieldValueData.updatedAt); + + // Verify parent note belongs to user (via deck ownership) + const noteCheck = await db + .select({ id: notes.id }) + .from(notes) + .innerJoin(decks, eq(notes.deckId, decks.id)) + .where( + and(eq(notes.id, fieldValueData.noteId), eq(decks.userId, userId)), + ); + + if (noteCheck.length === 0) { + // Parent note doesn't belong to user, skip + continue; + } + + // Check if note field value exists + const existing = await db + .select({ + id: noteFieldValues.id, + updatedAt: noteFieldValues.updatedAt, + syncVersion: noteFieldValues.syncVersion, + }) + .from(noteFieldValues) + .where(eq(noteFieldValues.id, fieldValueData.id)); + + if (existing.length === 0) { + // New note field value - insert + const [inserted] = await db + .insert(noteFieldValues) + .values({ + id: fieldValueData.id, + noteId: fieldValueData.noteId, + noteFieldTypeId: fieldValueData.noteFieldTypeId, + value: fieldValueData.value, + createdAt: new Date(fieldValueData.createdAt), + updatedAt: clientUpdatedAt, + syncVersion: 1, + }) + .returning({ + id: noteFieldValues.id, + syncVersion: noteFieldValues.syncVersion, + }); + + if (inserted) { + result.noteFieldValues.push({ + id: inserted.id, + syncVersion: inserted.syncVersion, + }); + } + } else { + const serverFieldValue = existing[0]; + if (serverFieldValue && clientUpdatedAt > serverFieldValue.updatedAt) { + // Client wins - update + const [updated] = await db + .update(noteFieldValues) + .set({ + noteId: fieldValueData.noteId, + noteFieldTypeId: fieldValueData.noteFieldTypeId, + value: fieldValueData.value, + updatedAt: clientUpdatedAt, + syncVersion: sql`${noteFieldValues.syncVersion} + 1`, + }) + .where(eq(noteFieldValues.id, fieldValueData.id)) + .returning({ + id: noteFieldValues.id, + syncVersion: noteFieldValues.syncVersion, + }); + + if (updated) { + result.noteFieldValues.push({ + id: updated.id, + syncVersion: updated.syncVersion, + }); + } + } else if (serverFieldValue) { + // Server wins - mark as conflict + result.conflicts.noteFieldValues.push(fieldValueData.id); + result.noteFieldValues.push({ + id: serverFieldValue.id, + syncVersion: serverFieldValue.syncVersion, + }); + } + } + } + return result; }, @@ -380,6 +817,76 @@ export const syncRepository: SyncRepository = { ), ); + // Get all note types for user with syncVersion > lastSyncVersion + const pulledNoteTypes = await db + .select() + .from(noteTypes) + .where( + and( + eq(noteTypes.userId, userId), + gt(noteTypes.syncVersion, lastSyncVersion), + ), + ); + + // Get user's note type IDs for filtering note field types + const userNoteTypeIds = await db + .select({ id: noteTypes.id }) + .from(noteTypes) + .where(eq(noteTypes.userId, userId)); + + const noteTypeIdList = userNoteTypeIds.map((nt) => nt.id); + + // Get all note field types for user's note types with syncVersion > lastSyncVersion + let pulledNoteFieldTypes: NoteFieldType[] = []; + if (noteTypeIdList.length > 0) { + const fieldTypeResults = await db + .select() + .from(noteFieldTypes) + .where(gt(noteFieldTypes.syncVersion, lastSyncVersion)); + + pulledNoteFieldTypes = fieldTypeResults.filter((ft) => + noteTypeIdList.includes(ft.noteTypeId), + ); + } + + // Get all notes for user's decks with syncVersion > lastSyncVersion + let pulledNotes: Note[] = []; + if (deckIdList.length > 0) { + const noteResults = await db + .select() + .from(notes) + .where(gt(notes.syncVersion, lastSyncVersion)); + + pulledNotes = noteResults.filter((n) => deckIdList.includes(n.deckId)); + } + + // Get note IDs for filtering note field values + const noteIdList = pulledNotes.map((n) => n.id); + + // Also get all user's note IDs (not just recently synced ones) for field value filtering + let allUserNoteIds: string[] = []; + if (deckIdList.length > 0) { + const allNotes = await db + .select({ id: notes.id }) + .from(notes) + .innerJoin(decks, eq(notes.deckId, decks.id)) + .where(eq(decks.userId, userId)); + allUserNoteIds = allNotes.map((n) => n.id); + } + + // Get all note field values for user's notes with syncVersion > lastSyncVersion + let pulledNoteFieldValues: NoteFieldValue[] = []; + if (allUserNoteIds.length > 0) { + const fieldValueResults = await db + .select() + .from(noteFieldValues) + .where(gt(noteFieldValues.syncVersion, lastSyncVersion)); + + pulledNoteFieldValues = fieldValueResults.filter((fv) => + allUserNoteIds.includes(fv.noteId), + ); + } + // Calculate current max sync version across all entities let currentSyncVersion = lastSyncVersion; @@ -398,11 +905,35 @@ export const syncRepository: SyncRepository = { currentSyncVersion = log.syncVersion; } } + for (const noteType of pulledNoteTypes) { + if (noteType.syncVersion > currentSyncVersion) { + currentSyncVersion = noteType.syncVersion; + } + } + for (const fieldType of pulledNoteFieldTypes) { + if (fieldType.syncVersion > currentSyncVersion) { + currentSyncVersion = fieldType.syncVersion; + } + } + for (const note of pulledNotes) { + if (note.syncVersion > currentSyncVersion) { + currentSyncVersion = note.syncVersion; + } + } + for (const fieldValue of pulledNoteFieldValues) { + if (fieldValue.syncVersion > currentSyncVersion) { + currentSyncVersion = fieldValue.syncVersion; + } + } return { decks: pulledDecks, cards: pulledCards, reviewLogs: pulledReviewLogs, + noteTypes: pulledNoteTypes, + noteFieldTypes: pulledNoteFieldTypes, + notes: pulledNotes, + noteFieldValues: pulledNoteFieldValues, currentSyncVersion, }; }, diff --git a/src/server/routes/sync.test.ts b/src/server/routes/sync.test.ts index 7492b49..1107acd 100644 --- a/src/server/routes/sync.test.ts +++ b/src/server/routes/sync.test.ts @@ -7,7 +7,15 @@ import type { SyncPushResult, SyncRepository, } from "../repositories/sync.js"; -import type { Card, Deck, ReviewLog } from "../repositories/types.js"; +import type { + Card, + Deck, + Note, + NoteFieldType, + NoteFieldValue, + NoteType, + ReviewLog, +} from "../repositories/types.js"; import { createSyncRouter } from "./sync.js"; function createMockSyncRepo(): SyncRepository { @@ -35,9 +43,17 @@ interface SyncPushResponse { decks?: { id: string; syncVersion: number }[]; cards?: { id: string; syncVersion: number }[]; reviewLogs?: { id: string; syncVersion: number }[]; + noteTypes?: { id: string; syncVersion: number }[]; + noteFieldTypes?: { id: string; syncVersion: number }[]; + notes?: { id: string; syncVersion: number }[]; + noteFieldValues?: { id: string; syncVersion: number }[]; conflicts?: { decks: string[]; cards: string[]; + noteTypes: string[]; + noteFieldTypes: string[]; + notes: string[]; + noteFieldValues: string[]; }; error?: { code: string; @@ -76,7 +92,18 @@ describe("POST /api/sync/push", () => { decks: [], cards: [], reviewLogs: [], - conflicts: { decks: [], cards: [] }, + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + conflicts: { + decks: [], + cards: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + }, }; vi.mocked(mockSyncRepo.pushChanges).mockResolvedValue(mockResult); @@ -94,11 +121,18 @@ describe("POST /api/sync/push", () => { expect(body.decks).toEqual([]); expect(body.cards).toEqual([]); expect(body.reviewLogs).toEqual([]); - expect(body.conflicts).toEqual({ decks: [], cards: [] }); + expect(body.noteTypes).toEqual([]); + expect(body.noteFieldTypes).toEqual([]); + expect(body.notes).toEqual([]); + expect(body.noteFieldValues).toEqual([]); expect(mockSyncRepo.pushChanges).toHaveBeenCalledWith(userId, { decks: [], cards: [], reviewLogs: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], }); }); @@ -117,7 +151,18 @@ describe("POST /api/sync/push", () => { decks: [{ id: "deck-uuid-123", syncVersion: 1 }], cards: [], reviewLogs: [], - conflicts: { decks: [], cards: [] }, + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + conflicts: { + decks: [], + cards: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + }, }; vi.mocked(mockSyncRepo.pushChanges).mockResolvedValue(mockResult); @@ -141,6 +186,8 @@ describe("POST /api/sync/push", () => { const cardData = { id: "550e8400-e29b-41d4-a716-446655440001", deckId: "550e8400-e29b-41d4-a716-446655440000", + noteId: null, + isReversed: null, front: "Question", back: "Answer", state: 0, @@ -161,7 +208,18 @@ describe("POST /api/sync/push", () => { decks: [], cards: [{ id: "550e8400-e29b-41d4-a716-446655440001", syncVersion: 1 }], reviewLogs: [], - conflicts: { decks: [], cards: [] }, + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + conflicts: { + decks: [], + cards: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + }, }; vi.mocked(mockSyncRepo.pushChanges).mockResolvedValue(mockResult); @@ -198,7 +256,18 @@ describe("POST /api/sync/push", () => { reviewLogs: [ { id: "550e8400-e29b-41d4-a716-446655440002", syncVersion: 1 }, ], - conflicts: { decks: [], cards: [] }, + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + conflicts: { + decks: [], + cards: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + }, }; vi.mocked(mockSyncRepo.pushChanges).mockResolvedValue(mockResult); @@ -238,7 +307,18 @@ describe("POST /api/sync/push", () => { decks: [{ id: "550e8400-e29b-41d4-a716-446655440003", syncVersion: 5 }], cards: [], reviewLogs: [], - conflicts: { decks: ["550e8400-e29b-41d4-a716-446655440003"], cards: [] }, + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + conflicts: { + decks: ["550e8400-e29b-41d4-a716-446655440003"], + cards: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + }, }; vi.mocked(mockSyncRepo.pushChanges).mockResolvedValue(mockResult); @@ -355,6 +435,8 @@ describe("POST /api/sync/push", () => { const cardData = { id: "550e8400-e29b-41d4-a716-446655440005", deckId: "550e8400-e29b-41d4-a716-446655440004", + noteId: null, + isReversed: null, front: "Q", back: "A", state: 0, @@ -388,7 +470,18 @@ describe("POST /api/sync/push", () => { reviewLogs: [ { id: "550e8400-e29b-41d4-a716-446655440006", syncVersion: 1 }, ], - conflicts: { decks: [], cards: [] }, + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + conflicts: { + decks: [], + cards: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + }, }; vi.mocked(mockSyncRepo.pushChanges).mockResolvedValue(mockResult); @@ -412,6 +505,121 @@ describe("POST /api/sync/push", () => { expect(body.reviewLogs).toHaveLength(1); }); + it("successfully pushes note types", async () => { + const noteTypeData = { + id: "550e8400-e29b-41d4-a716-446655440010", + name: "Basic Note", + frontTemplate: "{{Front}}", + backTemplate: "{{Back}}", + isReversible: false, + createdAt: "2024-01-01T00:00:00.000Z", + updatedAt: "2024-01-02T00:00:00.000Z", + deletedAt: null, + }; + + const mockResult: SyncPushResult = { + decks: [], + cards: [], + reviewLogs: [], + noteTypes: [ + { id: "550e8400-e29b-41d4-a716-446655440010", syncVersion: 1 }, + ], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + conflicts: { + decks: [], + cards: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + }, + }; + vi.mocked(mockSyncRepo.pushChanges).mockResolvedValue(mockResult); + + const res = await app.request("/api/sync/push", { + method: "POST", + headers: { + Authorization: `Bearer ${authToken}`, + "Content-Type": "application/json", + }, + body: JSON.stringify({ + decks: [], + cards: [], + reviewLogs: [], + noteTypes: [noteTypeData], + }), + }); + + expect(res.status).toBe(200); + const body = (await res.json()) as SyncPushResponse; + expect(body.noteTypes).toHaveLength(1); + expect(body.noteTypes?.[0]?.id).toBe( + "550e8400-e29b-41d4-a716-446655440010", + ); + }); + + it("successfully pushes cards with noteId and isReversed", async () => { + const cardData = { + id: "550e8400-e29b-41d4-a716-446655440011", + deckId: "550e8400-e29b-41d4-a716-446655440000", + noteId: "550e8400-e29b-41d4-a716-446655440020", + isReversed: true, + front: "Question", + back: "Answer", + state: 0, + due: "2024-01-01T00:00:00.000Z", + stability: 0, + difficulty: 0, + elapsedDays: 0, + scheduledDays: 0, + reps: 0, + lapses: 0, + lastReview: null, + createdAt: "2024-01-01T00:00:00.000Z", + updatedAt: "2024-01-02T00:00:00.000Z", + deletedAt: null, + }; + + const mockResult: SyncPushResult = { + decks: [], + cards: [{ id: "550e8400-e29b-41d4-a716-446655440011", syncVersion: 1 }], + reviewLogs: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + conflicts: { + decks: [], + cards: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + }, + }; + vi.mocked(mockSyncRepo.pushChanges).mockResolvedValue(mockResult); + + const res = await app.request("/api/sync/push", { + method: "POST", + headers: { + Authorization: `Bearer ${authToken}`, + "Content-Type": "application/json", + }, + body: JSON.stringify({ + decks: [], + cards: [cardData], + reviewLogs: [], + }), + }); + + expect(res.status).toBe(200); + const body = (await res.json()) as SyncPushResponse; + expect(body.cards).toHaveLength(1); + expect(body.cards?.[0]?.id).toBe("550e8400-e29b-41d4-a716-446655440011"); + }); + it("handles soft-deleted entities", async () => { const deletedDeck = { id: "550e8400-e29b-41d4-a716-446655440007", @@ -427,7 +635,18 @@ describe("POST /api/sync/push", () => { decks: [{ id: "550e8400-e29b-41d4-a716-446655440007", syncVersion: 2 }], cards: [], reviewLogs: [], - conflicts: { decks: [], cards: [] }, + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + conflicts: { + decks: [], + cards: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + }, }; vi.mocked(mockSyncRepo.pushChanges).mockResolvedValue(mockResult); @@ -454,6 +673,10 @@ interface SyncPullResponse { decks?: Deck[]; cards?: Card[]; reviewLogs?: ReviewLog[]; + noteTypes?: NoteType[]; + noteFieldTypes?: NoteFieldType[]; + notes?: Note[]; + noteFieldValues?: NoteFieldValue[]; currentSyncVersion?: number; error?: { code: string; @@ -500,6 +723,10 @@ describe("GET /api/sync/pull", () => { decks: [mockDeck], cards: [], reviewLogs: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], currentSyncVersion: 1, }; vi.mocked(mockSyncRepo.pullChanges).mockResolvedValue(mockResult); @@ -515,6 +742,10 @@ describe("GET /api/sync/pull", () => { expect(body.decks).toHaveLength(1); expect(body.cards).toHaveLength(0); expect(body.reviewLogs).toHaveLength(0); + expect(body.noteTypes).toHaveLength(0); + expect(body.noteFieldTypes).toHaveLength(0); + expect(body.notes).toHaveLength(0); + expect(body.noteFieldValues).toHaveLength(0); expect(body.currentSyncVersion).toBe(1); expect(mockSyncRepo.pullChanges).toHaveBeenCalledWith(userId, { lastSyncVersion: 0, @@ -526,6 +757,10 @@ describe("GET /api/sync/pull", () => { decks: [], cards: [], reviewLogs: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], currentSyncVersion: 5, }; vi.mocked(mockSyncRepo.pullChanges).mockResolvedValue(mockResult); @@ -562,6 +797,10 @@ describe("GET /api/sync/pull", () => { decks: [mockDeck], cards: [], reviewLogs: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], currentSyncVersion: 2, }; vi.mocked(mockSyncRepo.pullChanges).mockResolvedValue(mockResult); @@ -607,6 +846,10 @@ describe("GET /api/sync/pull", () => { decks: [], cards: [mockCard], reviewLogs: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], currentSyncVersion: 3, }; vi.mocked(mockSyncRepo.pullChanges).mockResolvedValue(mockResult); @@ -645,6 +888,10 @@ describe("GET /api/sync/pull", () => { decks: [], cards: [], reviewLogs: [mockReviewLog], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], currentSyncVersion: 1, }; vi.mocked(mockSyncRepo.pullChanges).mockResolvedValue(mockResult); @@ -717,6 +964,10 @@ describe("GET /api/sync/pull", () => { decks: [mockDeck], cards: [mockCard], reviewLogs: [mockReviewLog], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], currentSyncVersion: 3, }; vi.mocked(mockSyncRepo.pullChanges).mockResolvedValue(mockResult); @@ -732,9 +983,106 @@ describe("GET /api/sync/pull", () => { expect(body.decks).toHaveLength(1); expect(body.cards).toHaveLength(1); expect(body.reviewLogs).toHaveLength(1); + expect(body.noteTypes).toHaveLength(0); + expect(body.noteFieldTypes).toHaveLength(0); + expect(body.notes).toHaveLength(0); + expect(body.noteFieldValues).toHaveLength(0); expect(body.currentSyncVersion).toBe(3); }); + it("returns note types", async () => { + const mockNoteType: NoteType = { + id: "550e8400-e29b-41d4-a716-446655440010", + userId, + name: "Basic Note", + frontTemplate: "{{Front}}", + backTemplate: "{{Back}}", + isReversible: false, + createdAt: new Date("2024-01-01T00:00:00.000Z"), + updatedAt: new Date("2024-01-02T00:00:00.000Z"), + deletedAt: null, + syncVersion: 1, + }; + + const mockResult: SyncPullResult = { + decks: [], + cards: [], + reviewLogs: [], + noteTypes: [mockNoteType], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + currentSyncVersion: 1, + }; + vi.mocked(mockSyncRepo.pullChanges).mockResolvedValue(mockResult); + + const res = await app.request("/api/sync/pull", { + headers: { + Authorization: `Bearer ${authToken}`, + }, + }); + + expect(res.status).toBe(200); + const body = (await res.json()) as SyncPullResponse; + expect(body.noteTypes).toHaveLength(1); + expect(body.noteTypes?.[0]?.id).toBe( + "550e8400-e29b-41d4-a716-446655440010", + ); + expect(body.noteTypes?.[0]?.name).toBe("Basic Note"); + expect(body.noteTypes?.[0]?.frontTemplate).toBe("{{Front}}"); + expect(body.noteTypes?.[0]?.isReversible).toBe(false); + }); + + it("returns cards with noteId and isReversed fields", async () => { + const mockCard: Card = { + id: "550e8400-e29b-41d4-a716-446655440001", + deckId: "550e8400-e29b-41d4-a716-446655440000", + noteId: "550e8400-e29b-41d4-a716-446655440020", + isReversed: true, + front: "Question", + back: "Answer", + state: 0, + due: new Date("2024-01-01T00:00:00.000Z"), + stability: 0, + difficulty: 0, + elapsedDays: 0, + scheduledDays: 0, + reps: 0, + lapses: 0, + lastReview: null, + createdAt: new Date("2024-01-01T00:00:00.000Z"), + updatedAt: new Date("2024-01-02T00:00:00.000Z"), + deletedAt: null, + syncVersion: 1, + }; + + const mockResult: SyncPullResult = { + decks: [], + cards: [mockCard], + reviewLogs: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], + currentSyncVersion: 1, + }; + vi.mocked(mockSyncRepo.pullChanges).mockResolvedValue(mockResult); + + const res = await app.request("/api/sync/pull", { + headers: { + Authorization: `Bearer ${authToken}`, + }, + }); + + expect(res.status).toBe(200); + const body = (await res.json()) as SyncPullResponse; + expect(body.cards).toHaveLength(1); + expect(body.cards?.[0]?.noteId).toBe( + "550e8400-e29b-41d4-a716-446655440020", + ); + expect(body.cards?.[0]?.isReversed).toBe(true); + }); + it("returns soft-deleted entities", async () => { const deletedDeck: Deck = { id: "550e8400-e29b-41d4-a716-446655440000", @@ -752,6 +1100,10 @@ describe("GET /api/sync/pull", () => { decks: [deletedDeck], cards: [], reviewLogs: [], + noteTypes: [], + noteFieldTypes: [], + notes: [], + noteFieldValues: [], currentSyncVersion: 2, }; vi.mocked(mockSyncRepo.pullChanges).mockResolvedValue(mockResult); diff --git a/src/server/routes/sync.ts b/src/server/routes/sync.ts index ff95bf4..f05a7ba 100644 --- a/src/server/routes/sync.ts +++ b/src/server/routes/sync.ts @@ -26,6 +26,8 @@ const syncDeckSchema = z.object({ const syncCardSchema = z.object({ id: z.uuid(), deckId: z.uuid(), + noteId: z.uuid().nullable(), + isReversed: z.boolean().nullable(), front: z.string().min(1), back: z.string().min(1), state: z.number().int().min(0).max(3), @@ -53,10 +55,54 @@ const syncReviewLogSchema = z.object({ durationMs: z.number().int().min(0).nullable(), }); +const syncNoteTypeSchema = z.object({ + id: z.uuid(), + name: z.string().min(1).max(255), + frontTemplate: z.string(), + backTemplate: z.string(), + isReversible: z.boolean(), + createdAt: z.string().datetime(), + updatedAt: z.string().datetime(), + deletedAt: z.string().datetime().nullable(), +}); + +const syncNoteFieldTypeSchema = z.object({ + id: z.uuid(), + noteTypeId: z.uuid(), + name: z.string().min(1).max(255), + order: z.number().int().min(0), + fieldType: z.string(), + createdAt: z.string().datetime(), + updatedAt: z.string().datetime(), + deletedAt: z.string().datetime().nullable(), +}); + +const syncNoteSchema = z.object({ + id: z.uuid(), + deckId: z.uuid(), + noteTypeId: z.uuid(), + createdAt: z.string().datetime(), + updatedAt: z.string().datetime(), + deletedAt: z.string().datetime().nullable(), +}); + +const syncNoteFieldValueSchema = z.object({ + id: z.uuid(), + noteId: z.uuid(), + noteFieldTypeId: z.uuid(), + value: z.string(), + createdAt: z.string().datetime(), + updatedAt: z.string().datetime(), +}); + const syncPushSchema = z.object({ decks: z.array(syncDeckSchema).default([]), cards: z.array(syncCardSchema).default([]), reviewLogs: z.array(syncReviewLogSchema).default([]), + noteTypes: z.array(syncNoteTypeSchema).default([]), + noteFieldTypes: z.array(syncNoteFieldTypeSchema).default([]), + notes: z.array(syncNoteSchema).default([]), + noteFieldValues: z.array(syncNoteFieldValueSchema).default([]), }); const syncPullQuerySchema = z.object({ |
