From 897f22233810919ba01608bffbfa69f2bb926388 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 15 Feb 2026 16:58:47 +0900 Subject: refactor: rename lint/typecheck scripts to check namespace Consolidate typecheck and lint into a unified `pnpm check` command with `check:ts` and `check:lint` sub-commands. Update CI workflow to use the single check step and update docs accordingly. Co-Authored-By: Claude Opus 4.6 --- .github/workflows/ci.yaml | 7 ++----- CLAUDE.md | 10 +++++----- README.md | 6 +++--- package.json | 6 +++--- 4 files changed, 13 insertions(+), 16 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 86db887..c451aef 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -27,11 +27,8 @@ jobs: - name: Install dependencies run: pnpm install --frozen-lockfile - - name: Lint - run: pnpm lint - - - name: Typecheck - run: pnpm typecheck + - name: Check + run: pnpm check - name: Test run: POSTGRES_USER=test POSTGRES_PASSWORD=test POSTGRES_DB=test POSTGRES_HOST=localhost POSTGRES_PORT=5432 pnpm test diff --git a/CLAUDE.md b/CLAUDE.md index 25c313f..118ac71 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -10,9 +10,9 @@ pnpm dev # Start backend server (hot reload) pnpm dev:client # Start frontend dev server (port 5173) pnpm build # Build both server and client pnpm test # Run tests (Vitest) -pnpm typecheck # TypeScript type checking -pnpm lint # Lint with Biome -pnpm lint:fix # Auto-fix lint issues +pnpm check # Run all checks (TypeScript + lint) +pnpm check:ts # TypeScript type checking +pnpm check:lint # Lint with Biome pnpm format # Format with Biome pnpm db:generate # Generate database migrations pnpm db:migrate # Run database migrations @@ -25,7 +25,7 @@ See [docs/dev/architecture.md](docs/dev/architecture.md) for details. ## Code Style -- **Formatter/Linter**: Biome (run `pnpm lint` to check, `pnpm lint:fix` to auto-fix) +- **Formatter/Linter**: Biome (run `pnpm check:lint` to check, `pnpm format` to auto-format) - **Indentation**: Tabs - **Quotes**: Double quotes for JS/TS - **Imports**: Organized by Biome (auto-sorted) @@ -51,4 +51,4 @@ Test environment uses `JWT_SECRET=test-secret-key` and mock factories for test d ## CI Pipeline -Lint → Typecheck → Test → Build (see `.github/workflows/ci.yaml`) +Check (lint + typecheck) → Test → Build (see `.github/workflows/ci.yaml`) diff --git a/README.md b/README.md index 86e6cf6..cfdf165 100644 --- a/README.md +++ b/README.md @@ -65,9 +65,9 @@ pnpm dev:client # Frontend dev server (port 5173) | `pnpm build` | Build both server and client | | `pnpm start` | Start production server | | `pnpm test` | Run tests | -| `pnpm typecheck` | Run TypeScript type checking | -| `pnpm lint` | Lint code with Biome | -| `pnpm lint:fix` | Lint and auto-fix issues | +| `pnpm check` | Run all checks (TypeScript + lint) | +| `pnpm check:ts` | Run TypeScript type checking | +| `pnpm check:lint` | Lint code with Biome | | `pnpm db:migrate` | Run database migrations | | `pnpm db:studio` | Open Drizzle Studio (database GUI) | | `pnpm user:add` | Add a new user (interactive) | diff --git a/package.json b/package.json index 3c1c63e..db840b7 100644 --- a/package.json +++ b/package.json @@ -13,9 +13,9 @@ "start": "node dist/server/index.js", "test": "vitest run", "test:watch": "vitest", - "typecheck": "tsc --noEmit", - "lint": "biome check .", - "lint:fix": "biome check --write .", + "check": "pnpm check:ts && pnpm check:lint", + "check:ts": "tsc --noEmit", + "check:lint": "biome check .", "format": "biome format --write .", "db:generate": "drizzle-kit generate", "db:migrate": "drizzle-kit migrate", -- cgit v1.3-1-g0d28