From b51d4efaa1e5e0417d4306c02797f424938766cb Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 31 Dec 2025 02:38:05 +0900 Subject: feat(client): add NoteTypesPage for note type management MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Implement Phase 6 of the roadmap - NoteType list page with CRUD modals: - NoteTypesPage displays all user's note types with templates and reversible badge - CreateNoteTypeModal for creating new note types with templates - EditNoteTypeModal for updating existing note types - DeleteNoteTypeModal with constraint warning - Navigation link from HomePage header - Comprehensive tests for all components (65 new tests) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- src/client/App.tsx | 6 + src/client/components/CreateNoteTypeModal.test.tsx | 318 ++++++++++++ src/client/components/CreateNoteTypeModal.tsx | 229 +++++++++ src/client/components/DeleteNoteTypeModal.test.tsx | 290 +++++++++++ src/client/components/DeleteNoteTypeModal.tsx | 156 ++++++ src/client/components/EditNoteTypeModal.test.tsx | 368 ++++++++++++++ src/client/components/EditNoteTypeModal.tsx | 239 +++++++++ src/client/pages/HomePage.tsx | 13 + src/client/pages/NoteTypesPage.test.tsx | 551 +++++++++++++++++++++ src/client/pages/NoteTypesPage.tsx | 272 ++++++++++ src/client/pages/index.ts | 1 + 11 files changed, 2443 insertions(+) create mode 100644 src/client/components/CreateNoteTypeModal.test.tsx create mode 100644 src/client/components/CreateNoteTypeModal.tsx create mode 100644 src/client/components/DeleteNoteTypeModal.test.tsx create mode 100644 src/client/components/DeleteNoteTypeModal.tsx create mode 100644 src/client/components/EditNoteTypeModal.test.tsx create mode 100644 src/client/components/EditNoteTypeModal.tsx create mode 100644 src/client/pages/NoteTypesPage.test.tsx create mode 100644 src/client/pages/NoteTypesPage.tsx (limited to 'src') diff --git a/src/client/App.tsx b/src/client/App.tsx index 3c20c54..e1b794c 100644 --- a/src/client/App.tsx +++ b/src/client/App.tsx @@ -4,6 +4,7 @@ import { DeckDetailPage, HomePage, LoginPage, + NoteTypesPage, NotFoundPage, StudyPage, } from "./pages"; @@ -28,6 +29,11 @@ export function App() { + + + + + diff --git a/src/client/components/CreateNoteTypeModal.test.tsx b/src/client/components/CreateNoteTypeModal.test.tsx new file mode 100644 index 0000000..9536f53 --- /dev/null +++ b/src/client/components/CreateNoteTypeModal.test.tsx @@ -0,0 +1,318 @@ +/** + * @vitest-environment jsdom + */ +import { cleanup, render, screen, waitFor } from "@testing-library/react"; +import userEvent from "@testing-library/user-event"; +import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"; +import { apiClient } from "../api/client"; + +vi.mock("../api/client", () => ({ + apiClient: { + getAuthHeader: vi.fn(), + }, + ApiClientError: class ApiClientError extends Error { + constructor( + message: string, + public status: number, + public code?: string, + ) { + super(message); + this.name = "ApiClientError"; + } + }, +})); + +// Import after mock is set up +import { CreateNoteTypeModal } from "./CreateNoteTypeModal"; + +// Mock fetch globally +const mockFetch = vi.fn(); +global.fetch = mockFetch; + +describe("CreateNoteTypeModal", () => { + const defaultProps = { + isOpen: true, + onClose: vi.fn(), + onNoteTypeCreated: vi.fn(), + }; + + beforeEach(() => { + vi.clearAllMocks(); + vi.mocked(apiClient.getAuthHeader).mockReturnValue({ + Authorization: "Bearer access-token", + }); + }); + + afterEach(() => { + cleanup(); + vi.restoreAllMocks(); + }); + + it("does not render when closed", () => { + render(); + + expect(screen.queryByRole("dialog")).toBeNull(); + }); + + it("renders modal when open", () => { + render(); + + expect(screen.getByRole("dialog")).toBeDefined(); + expect( + screen.getByRole("heading", { name: "Create Note Type" }), + ).toBeDefined(); + expect(screen.getByLabelText("Name")).toBeDefined(); + expect(screen.getByLabelText("Front Template")).toBeDefined(); + expect(screen.getByLabelText("Back Template")).toBeDefined(); + expect(screen.getByLabelText("Create reversed cards")).toBeDefined(); + expect(screen.getByRole("button", { name: "Cancel" })).toBeDefined(); + expect(screen.getByRole("button", { name: "Create" })).toBeDefined(); + }); + + it("has default template values", () => { + render(); + + expect(screen.getByLabelText("Front Template")).toHaveProperty( + "value", + "{{Front}}", + ); + expect(screen.getByLabelText("Back Template")).toHaveProperty( + "value", + "{{Back}}", + ); + }); + + it("disables create button when name is empty", () => { + render(); + + const createButton = screen.getByRole("button", { name: "Create" }); + expect(createButton).toHaveProperty("disabled", true); + }); + + it("enables create button when name has content", async () => { + const user = userEvent.setup(); + render(); + + const nameInput = screen.getByLabelText("Name"); + await user.type(nameInput, "My Note Type"); + + const createButton = screen.getByRole("button", { name: "Create" }); + expect(createButton).toHaveProperty("disabled", false); + }); + + it("calls onClose when Cancel is clicked", async () => { + const user = userEvent.setup(); + const onClose = vi.fn(); + render(); + + await user.click(screen.getByRole("button", { name: "Cancel" })); + + expect(onClose).toHaveBeenCalledTimes(1); + }); + + it("calls onClose when clicking outside the modal", async () => { + const user = userEvent.setup(); + const onClose = vi.fn(); + render(); + + const dialog = screen.getByRole("dialog"); + await user.click(dialog); + + expect(onClose).toHaveBeenCalledTimes(1); + }); + + it("creates note type with all fields", async () => { + const user = userEvent.setup(); + const onClose = vi.fn(); + const onNoteTypeCreated = vi.fn(); + + mockFetch.mockResolvedValue({ + ok: true, + json: async () => ({ + noteType: { + id: "note-type-1", + name: "Test Note Type", + frontTemplate: "{{Front}}", + backTemplate: "{{Back}}", + isReversible: true, + }, + }), + }); + + render( + , + ); + + await user.type(screen.getByLabelText("Name"), "Test Note Type"); + // Keep default templates and just toggle reversible + await user.click(screen.getByLabelText("Create reversed cards")); + await user.click(screen.getByRole("button", { name: "Create" })); + + await waitFor(() => { + expect(mockFetch).toHaveBeenCalledWith("/api/note-types", { + method: "POST", + headers: { + "Content-Type": "application/json", + Authorization: "Bearer access-token", + }, + body: JSON.stringify({ + name: "Test Note Type", + frontTemplate: "{{Front}}", + backTemplate: "{{Back}}", + isReversible: true, + }), + }); + }); + + expect(onNoteTypeCreated).toHaveBeenCalledTimes(1); + expect(onClose).toHaveBeenCalledTimes(1); + }); + + it("trims whitespace from text fields", async () => { + const user = userEvent.setup(); + + mockFetch.mockResolvedValue({ + ok: true, + json: async () => ({ noteType: { id: "note-type-1" } }), + }); + + render(); + + await user.type(screen.getByLabelText("Name"), " Test Note Type "); + await user.click(screen.getByRole("button", { name: "Create" })); + + await waitFor(() => { + expect(mockFetch).toHaveBeenCalledWith( + "/api/note-types", + expect.objectContaining({ + body: expect.stringContaining('"name":"Test Note Type"'), + }), + ); + }); + }); + + it("shows loading state during submission", async () => { + const user = userEvent.setup(); + + mockFetch.mockImplementation(() => new Promise(() => {})); // Never resolves + + render(); + + await user.type(screen.getByLabelText("Name"), "Test Note Type"); + await user.click(screen.getByRole("button", { name: "Create" })); + + expect(screen.getByRole("button", { name: "Creating..." })).toBeDefined(); + expect(screen.getByRole("button", { name: "Creating..." })).toHaveProperty( + "disabled", + true, + ); + expect(screen.getByRole("button", { name: "Cancel" })).toHaveProperty( + "disabled", + true, + ); + expect(screen.getByLabelText("Name")).toHaveProperty("disabled", true); + }); + + it("displays API error message", async () => { + const user = userEvent.setup(); + + mockFetch.mockResolvedValue({ + ok: false, + status: 400, + json: async () => ({ error: "Note type name already exists" }), + }); + + render(); + + await user.type(screen.getByLabelText("Name"), "Test Note Type"); + await user.click(screen.getByRole("button", { name: "Create" })); + + await waitFor(() => { + expect(screen.getByRole("alert").textContent).toContain( + "Note type name already exists", + ); + }); + }); + + it("displays generic error on unexpected failure", async () => { + const user = userEvent.setup(); + + mockFetch.mockRejectedValue(new Error("Network error")); + + render(); + + await user.type(screen.getByLabelText("Name"), "Test Note Type"); + await user.click(screen.getByRole("button", { name: "Create" })); + + await waitFor(() => { + expect(screen.getByRole("alert").textContent).toContain( + "Failed to create note type. Please try again.", + ); + }); + }); + + it("displays error when not authenticated", async () => { + const user = userEvent.setup(); + + vi.mocked(apiClient.getAuthHeader).mockReturnValue(undefined); + + render(); + + await user.type(screen.getByLabelText("Name"), "Test Note Type"); + await user.click(screen.getByRole("button", { name: "Create" })); + + await waitFor(() => { + expect(screen.getByRole("alert").textContent).toContain( + "Not authenticated", + ); + }); + }); + + it("resets form when closed and reopened", async () => { + const user = userEvent.setup(); + const onClose = vi.fn(); + + const { rerender } = render( + , + ); + + // Type something in the form + await user.type(screen.getByLabelText("Name"), "Test Note Type"); + await user.click(screen.getByLabelText("Create reversed cards")); + + // Click cancel to close + await user.click(screen.getByRole("button", { name: "Cancel" })); + + // Reopen the modal + rerender( + , + ); + + // Form should be reset + expect(screen.getByLabelText("Name")).toHaveProperty("value", ""); + expect(screen.getByLabelText("Front Template")).toHaveProperty( + "value", + "{{Front}}", + ); + expect(screen.getByLabelText("Back Template")).toHaveProperty( + "value", + "{{Back}}", + ); + expect(screen.getByLabelText("Create reversed cards")).toHaveProperty( + "checked", + false, + ); + }); +}); diff --git a/src/client/components/CreateNoteTypeModal.tsx b/src/client/components/CreateNoteTypeModal.tsx new file mode 100644 index 0000000..2b8dfb9 --- /dev/null +++ b/src/client/components/CreateNoteTypeModal.tsx @@ -0,0 +1,229 @@ +import { type FormEvent, useState } from "react"; +import { ApiClientError, apiClient } from "../api"; + +interface CreateNoteTypeModalProps { + isOpen: boolean; + onClose: () => void; + onNoteTypeCreated: () => void; +} + +export function CreateNoteTypeModal({ + isOpen, + onClose, + onNoteTypeCreated, +}: CreateNoteTypeModalProps) { + const [name, setName] = useState(""); + const [frontTemplate, setFrontTemplate] = useState("{{Front}}"); + const [backTemplate, setBackTemplate] = useState("{{Back}}"); + const [isReversible, setIsReversible] = useState(false); + const [error, setError] = useState(null); + const [isSubmitting, setIsSubmitting] = useState(false); + + const resetForm = () => { + setName(""); + setFrontTemplate("{{Front}}"); + setBackTemplate("{{Back}}"); + setIsReversible(false); + setError(null); + }; + + const handleClose = () => { + resetForm(); + onClose(); + }; + + const handleSubmit = async (e: FormEvent) => { + e.preventDefault(); + setError(null); + setIsSubmitting(true); + + try { + const authHeader = apiClient.getAuthHeader(); + if (!authHeader) { + throw new ApiClientError("Not authenticated", 401); + } + + const res = await fetch("/api/note-types", { + method: "POST", + headers: { + "Content-Type": "application/json", + ...authHeader, + }, + body: JSON.stringify({ + name: name.trim(), + frontTemplate: frontTemplate.trim(), + backTemplate: backTemplate.trim(), + isReversible, + }), + }); + + if (!res.ok) { + const errorBody = await res.json().catch(() => ({})); + throw new ApiClientError( + (errorBody as { error?: string }).error || + `Request failed with status ${res.status}`, + res.status, + ); + } + + resetForm(); + onNoteTypeCreated(); + onClose(); + } catch (err) { + if (err instanceof ApiClientError) { + setError(err.message); + } else { + setError("Failed to create note type. Please try again."); + } + } finally { + setIsSubmitting(false); + } + }; + + if (!isOpen) { + return null; + } + + return ( +
{ + if (e.target === e.currentTarget) { + handleClose(); + } + }} + onKeyDown={(e) => { + if (e.key === "Escape") { + handleClose(); + } + }} + > +
+
+

+ Create Note Type +

+ +
+ {error && ( +
+ {error} +
+ )} + +
+ + setName(e.target.value)} + required + maxLength={255} + disabled={isSubmitting} + className="w-full px-4 py-2.5 bg-ivory border border-border rounded-lg text-slate placeholder-muted transition-all duration-200 hover:border-muted focus:border-primary focus:ring-2 focus:ring-primary/10 disabled:opacity-50 disabled:cursor-not-allowed" + placeholder="Basic" + /> +
+ +
+ + setFrontTemplate(e.target.value)} + required + maxLength={1000} + disabled={isSubmitting} + className="w-full px-4 py-2.5 bg-ivory border border-border rounded-lg text-slate placeholder-muted font-mono text-sm transition-all duration-200 hover:border-muted focus:border-primary focus:ring-2 focus:ring-primary/10 disabled:opacity-50 disabled:cursor-not-allowed" + placeholder="{{Front}}" + /> +

+ Use {"{{FieldName}}"} to insert field values +

+
+ +
+ + setBackTemplate(e.target.value)} + required + maxLength={1000} + disabled={isSubmitting} + className="w-full px-4 py-2.5 bg-ivory border border-border rounded-lg text-slate placeholder-muted font-mono text-sm transition-all duration-200 hover:border-muted focus:border-primary focus:ring-2 focus:ring-primary/10 disabled:opacity-50 disabled:cursor-not-allowed" + placeholder="{{Back}}" + /> +
+ +
+ setIsReversible(e.target.checked)} + disabled={isSubmitting} + className="w-4 h-4 text-primary bg-ivory border-border rounded focus:ring-primary/20 focus:ring-2 disabled:opacity-50" + /> + +
+

+ When enabled, each note will generate both a normal and reversed + card +

+ +
+ + +
+
+
+
+
+ ); +} diff --git a/src/client/components/DeleteNoteTypeModal.test.tsx b/src/client/components/DeleteNoteTypeModal.test.tsx new file mode 100644 index 0000000..d5d536a --- /dev/null +++ b/src/client/components/DeleteNoteTypeModal.test.tsx @@ -0,0 +1,290 @@ +/** + * @vitest-environment jsdom + */ +import { cleanup, render, screen, waitFor } from "@testing-library/react"; +import userEvent from "@testing-library/user-event"; +import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"; +import { apiClient } from "../api/client"; + +vi.mock("../api/client", () => ({ + apiClient: { + getAuthHeader: vi.fn(), + }, + ApiClientError: class ApiClientError extends Error { + constructor( + message: string, + public status: number, + public code?: string, + ) { + super(message); + this.name = "ApiClientError"; + } + }, +})); + +// Import after mock is set up +import { DeleteNoteTypeModal } from "./DeleteNoteTypeModal"; + +// Mock fetch globally +const mockFetch = vi.fn(); +global.fetch = mockFetch; + +describe("DeleteNoteTypeModal", () => { + const mockNoteType = { + id: "note-type-123", + name: "Basic", + }; + + const defaultProps = { + isOpen: true, + noteType: mockNoteType, + onClose: vi.fn(), + onNoteTypeDeleted: vi.fn(), + }; + + beforeEach(() => { + vi.clearAllMocks(); + vi.mocked(apiClient.getAuthHeader).mockReturnValue({ + Authorization: "Bearer access-token", + }); + }); + + afterEach(() => { + cleanup(); + vi.restoreAllMocks(); + }); + + it("does not render when closed", () => { + render(); + + expect(screen.queryByRole("dialog")).toBeNull(); + }); + + it("does not render when noteType is null", () => { + render(); + + expect(screen.queryByRole("dialog")).toBeNull(); + }); + + it("renders modal when open with noteType", () => { + render(); + + expect(screen.getByRole("dialog")).toBeDefined(); + expect( + screen.getByRole("heading", { name: "Delete Note Type" }), + ).toBeDefined(); + expect(screen.getByRole("button", { name: "Cancel" })).toBeDefined(); + expect(screen.getByRole("button", { name: "Delete" })).toBeDefined(); + }); + + it("displays confirmation message with noteType name", () => { + render(); + + expect(screen.getByText(/Are you sure you want to delete/)).toBeDefined(); + expect(screen.getByText("Basic")).toBeDefined(); + }); + + it("displays warning about deletion constraints", () => { + render(); + + expect( + screen.getByText(/Note types with existing notes cannot be deleted/), + ).toBeDefined(); + }); + + it("calls onClose when Cancel is clicked", async () => { + const user = userEvent.setup(); + const onClose = vi.fn(); + render(); + + await user.click(screen.getByRole("button", { name: "Cancel" })); + + expect(onClose).toHaveBeenCalledTimes(1); + }); + + it("calls onClose when clicking outside the modal", async () => { + const user = userEvent.setup(); + const onClose = vi.fn(); + render(); + + const dialog = screen.getByRole("dialog"); + await user.click(dialog); + + expect(onClose).toHaveBeenCalledTimes(1); + }); + + it("does not call onClose when clicking inside the modal content", async () => { + const user = userEvent.setup(); + const onClose = vi.fn(); + render(); + + await user.click(screen.getByText("Basic")); + + expect(onClose).not.toHaveBeenCalled(); + }); + + it("deletes noteType when Delete is clicked", async () => { + const user = userEvent.setup(); + const onClose = vi.fn(); + const onNoteTypeDeleted = vi.fn(); + + mockFetch.mockResolvedValue({ + ok: true, + json: async () => ({ success: true }), + }); + + render( + , + ); + + await user.click(screen.getByRole("button", { name: "Delete" })); + + await waitFor(() => { + expect(mockFetch).toHaveBeenCalledWith("/api/note-types/note-type-123", { + method: "DELETE", + headers: { + Authorization: "Bearer access-token", + }, + }); + }); + + expect(onNoteTypeDeleted).toHaveBeenCalledTimes(1); + expect(onClose).toHaveBeenCalledTimes(1); + }); + + it("shows loading state during deletion", async () => { + const user = userEvent.setup(); + + mockFetch.mockImplementation(() => new Promise(() => {})); // Never resolves + + render(); + + await user.click(screen.getByRole("button", { name: "Delete" })); + + expect(screen.getByRole("button", { name: "Deleting..." })).toBeDefined(); + expect(screen.getByRole("button", { name: "Deleting..." })).toHaveProperty( + "disabled", + true, + ); + expect(screen.getByRole("button", { name: "Cancel" })).toHaveProperty( + "disabled", + true, + ); + }); + + it("displays API error message", async () => { + const user = userEvent.setup(); + + mockFetch.mockResolvedValue({ + ok: false, + status: 404, + json: async () => ({ error: "Note type not found" }), + }); + + render(); + + await user.click(screen.getByRole("button", { name: "Delete" })); + + await waitFor(() => { + expect(screen.getByRole("alert").textContent).toContain( + "Note type not found", + ); + }); + }); + + it("displays conflict error when notes exist", async () => { + const user = userEvent.setup(); + + mockFetch.mockResolvedValue({ + ok: false, + status: 409, + json: async () => ({ error: "Cannot delete note type with existing notes" }), + }); + + render(); + + await user.click(screen.getByRole("button", { name: "Delete" })); + + await waitFor(() => { + expect(screen.getByRole("alert").textContent).toContain( + "Cannot delete note type with existing notes", + ); + }); + }); + + it("displays generic error on unexpected failure", async () => { + const user = userEvent.setup(); + + mockFetch.mockRejectedValue(new Error("Network error")); + + render(); + + await user.click(screen.getByRole("button", { name: "Delete" })); + + await waitFor(() => { + expect(screen.getByRole("alert").textContent).toContain( + "Failed to delete note type. Please try again.", + ); + }); + }); + + it("displays error when not authenticated", async () => { + const user = userEvent.setup(); + + vi.mocked(apiClient.getAuthHeader).mockReturnValue(undefined); + + render(); + + await user.click(screen.getByRole("button", { name: "Delete" })); + + await waitFor(() => { + expect(screen.getByRole("alert").textContent).toContain( + "Not authenticated", + ); + }); + }); + + it("clears error when modal is closed", async () => { + const user = userEvent.setup(); + const onClose = vi.fn(); + + mockFetch.mockResolvedValue({ + ok: false, + status: 404, + json: async () => ({ error: "Some error" }), + }); + + const { rerender } = render( + , + ); + + // Trigger error + await user.click(screen.getByRole("button", { name: "Delete" })); + await waitFor(() => { + expect(screen.getByRole("alert")).toBeDefined(); + }); + + // Close and reopen the modal + await user.click(screen.getByRole("button", { name: "Cancel" })); + rerender(); + + // Error should be cleared + expect(screen.queryByRole("alert")).toBeNull(); + }); + + it("displays noteType name correctly when changed", () => { + const { rerender } = render(); + + expect(screen.getByText("Basic")).toBeDefined(); + + const newNoteType = { id: "note-type-456", name: "Another Note Type" }; + rerender(); + + expect(screen.getByText("Another Note Type")).toBeDefined(); + }); +}); diff --git a/src/client/components/DeleteNoteTypeModal.tsx b/src/client/components/DeleteNoteTypeModal.tsx new file mode 100644 index 0000000..bd6b4a5 --- /dev/null +++ b/src/client/components/DeleteNoteTypeModal.tsx @@ -0,0 +1,156 @@ +import { useState } from "react"; +import { ApiClientError, apiClient } from "../api"; + +interface NoteType { + id: string; + name: string; +} + +interface DeleteNoteTypeModalProps { + isOpen: boolean; + noteType: NoteType | null; + onClose: () => void; + onNoteTypeDeleted: () => void; +} + +export function DeleteNoteTypeModal({ + isOpen, + noteType, + onClose, + onNoteTypeDeleted, +}: DeleteNoteTypeModalProps) { + const [error, setError] = useState(null); + const [isDeleting, setIsDeleting] = useState(false); + + const handleClose = () => { + setError(null); + onClose(); + }; + + const handleDelete = async () => { + if (!noteType) return; + + setError(null); + setIsDeleting(true); + + try { + const authHeader = apiClient.getAuthHeader(); + if (!authHeader) { + throw new ApiClientError("Not authenticated", 401); + } + + const res = await fetch(`/api/note-types/${noteType.id}`, { + method: "DELETE", + headers: authHeader, + }); + + if (!res.ok) { + const errorBody = await res.json().catch(() => ({})); + throw new ApiClientError( + (errorBody as { error?: string }).error || + `Request failed with status ${res.status}`, + res.status, + ); + } + + onNoteTypeDeleted(); + onClose(); + } catch (err) { + if (err instanceof ApiClientError) { + setError(err.message); + } else { + setError("Failed to delete note type. Please try again."); + } + } finally { + setIsDeleting(false); + } + }; + + if (!isOpen || !noteType) { + return null; + } + + return ( +
{ + if (e.target === e.currentTarget) { + handleClose(); + } + }} + onKeyDown={(e) => { + if (e.key === "Escape") { + handleClose(); + } + }} + > +
+
+
+ +
+ +

+ Delete Note Type +

+ + {error && ( +
+ {error} +
+ )} + +

+ Are you sure you want to delete{" "} + {noteType.name}? +

+

+ Note types with existing notes cannot be deleted. Remove all notes + using this type first. +

+ +
+ + +
+
+
+
+ ); +} diff --git a/src/client/components/EditNoteTypeModal.test.tsx b/src/client/components/EditNoteTypeModal.test.tsx new file mode 100644 index 0000000..c8064bd --- /dev/null +++ b/src/client/components/EditNoteTypeModal.test.tsx @@ -0,0 +1,368 @@ +/** + * @vitest-environment jsdom + */ +import { cleanup, render, screen, waitFor } from "@testing-library/react"; +import userEvent from "@testing-library/user-event"; +import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"; +import { apiClient } from "../api/client"; + +vi.mock("../api/client", () => ({ + apiClient: { + getAuthHeader: vi.fn(), + }, + ApiClientError: class ApiClientError extends Error { + constructor( + message: string, + public status: number, + public code?: string, + ) { + super(message); + this.name = "ApiClientError"; + } + }, +})); + +// Import after mock is set up +import { EditNoteTypeModal } from "./EditNoteTypeModal"; + +// Mock fetch globally +const mockFetch = vi.fn(); +global.fetch = mockFetch; + +describe("EditNoteTypeModal", () => { + const mockNoteType = { + id: "note-type-123", + name: "Basic", + frontTemplate: "{{Front}}", + backTemplate: "{{Back}}", + isReversible: false, + }; + + const defaultProps = { + isOpen: true, + noteType: mockNoteType, + onClose: vi.fn(), + onNoteTypeUpdated: vi.fn(), + }; + + beforeEach(() => { + vi.clearAllMocks(); + vi.mocked(apiClient.getAuthHeader).mockReturnValue({ + Authorization: "Bearer access-token", + }); + }); + + afterEach(() => { + cleanup(); + vi.restoreAllMocks(); + }); + + it("does not render when closed", () => { + render(); + + expect(screen.queryByRole("dialog")).toBeNull(); + }); + + it("does not render when noteType is null", () => { + render(); + + expect(screen.queryByRole("dialog")).toBeNull(); + }); + + it("renders modal when open with noteType", () => { + render(); + + expect(screen.getByRole("dialog")).toBeDefined(); + expect( + screen.getByRole("heading", { name: "Edit Note Type" }), + ).toBeDefined(); + expect(screen.getByLabelText("Name")).toBeDefined(); + expect(screen.getByLabelText("Front Template")).toBeDefined(); + expect(screen.getByLabelText("Back Template")).toBeDefined(); + expect(screen.getByLabelText("Create reversed cards")).toBeDefined(); + expect(screen.getByRole("button", { name: "Cancel" })).toBeDefined(); + expect(screen.getByRole("button", { name: "Save Changes" })).toBeDefined(); + }); + + it("populates form with noteType data", () => { + render(); + + expect(screen.getByLabelText("Name")).toHaveProperty("value", "Basic"); + expect(screen.getByLabelText("Front Template")).toHaveProperty( + "value", + "{{Front}}", + ); + expect(screen.getByLabelText("Back Template")).toHaveProperty( + "value", + "{{Back}}", + ); + expect(screen.getByLabelText("Create reversed cards")).toHaveProperty( + "checked", + false, + ); + }); + + it("populates form with reversible noteType", () => { + const reversibleNoteType = { + ...mockNoteType, + isReversible: true, + }; + + render( + , + ); + + expect(screen.getByLabelText("Create reversed cards")).toHaveProperty( + "checked", + true, + ); + }); + + it("disables save button when name is empty", async () => { + const user = userEvent.setup(); + render(); + + const nameInput = screen.getByLabelText("Name"); + await user.clear(nameInput); + + const saveButton = screen.getByRole("button", { name: "Save Changes" }); + expect(saveButton).toHaveProperty("disabled", true); + }); + + it("calls onClose when Cancel is clicked", async () => { + const user = userEvent.setup(); + const onClose = vi.fn(); + render(); + + await user.click(screen.getByRole("button", { name: "Cancel" })); + + expect(onClose).toHaveBeenCalledTimes(1); + }); + + it("calls onClose when clicking outside the modal", async () => { + const user = userEvent.setup(); + const onClose = vi.fn(); + render(); + + const dialog = screen.getByRole("dialog"); + await user.click(dialog); + + expect(onClose).toHaveBeenCalledTimes(1); + }); + + it("updates noteType when Save Changes is clicked", async () => { + const user = userEvent.setup(); + const onClose = vi.fn(); + const onNoteTypeUpdated = vi.fn(); + + mockFetch.mockResolvedValue({ + ok: true, + json: async () => ({ + noteType: { + ...mockNoteType, + name: "Updated Basic", + isReversible: true, + }, + }), + }); + + render( + , + ); + + // Update fields + const nameInput = screen.getByLabelText("Name"); + await user.clear(nameInput); + await user.type(nameInput, "Updated Basic"); + await user.click(screen.getByLabelText("Create reversed cards")); + + // Save + await user.click(screen.getByRole("button", { name: "Save Changes" })); + + await waitFor(() => { + expect(mockFetch).toHaveBeenCalledWith( + "/api/note-types/note-type-123", + { + method: "PUT", + headers: { + "Content-Type": "application/json", + Authorization: "Bearer access-token", + }, + body: JSON.stringify({ + name: "Updated Basic", + frontTemplate: "{{Front}}", + backTemplate: "{{Back}}", + isReversible: true, + }), + }, + ); + }); + + expect(onNoteTypeUpdated).toHaveBeenCalledTimes(1); + expect(onClose).toHaveBeenCalledTimes(1); + }); + + it("trims whitespace from text fields", async () => { + const user = userEvent.setup(); + + mockFetch.mockResolvedValue({ + ok: true, + json: async () => ({ noteType: mockNoteType }), + }); + + render(); + + const nameInput = screen.getByLabelText("Name"); + await user.clear(nameInput); + await user.type(nameInput, " Updated Basic "); + await user.click(screen.getByRole("button", { name: "Save Changes" })); + + await waitFor(() => { + expect(mockFetch).toHaveBeenCalledWith( + "/api/note-types/note-type-123", + expect.objectContaining({ + body: expect.stringContaining('"name":"Updated Basic"'), + }), + ); + }); + }); + + it("shows loading state during submission", async () => { + const user = userEvent.setup(); + + mockFetch.mockImplementation(() => new Promise(() => {})); // Never resolves + + render(); + + await user.click(screen.getByRole("button", { name: "Save Changes" })); + + expect(screen.getByRole("button", { name: "Saving..." })).toBeDefined(); + expect(screen.getByRole("button", { name: "Saving..." })).toHaveProperty( + "disabled", + true, + ); + expect(screen.getByRole("button", { name: "Cancel" })).toHaveProperty( + "disabled", + true, + ); + expect(screen.getByLabelText("Name")).toHaveProperty("disabled", true); + }); + + it("displays API error message", async () => { + const user = userEvent.setup(); + + mockFetch.mockResolvedValue({ + ok: false, + status: 404, + json: async () => ({ error: "Note type not found" }), + }); + + render(); + + await user.click(screen.getByRole("button", { name: "Save Changes" })); + + await waitFor(() => { + expect(screen.getByRole("alert").textContent).toContain( + "Note type not found", + ); + }); + }); + + it("displays generic error on unexpected failure", async () => { + const user = userEvent.setup(); + + mockFetch.mockRejectedValue(new Error("Network error")); + + render(); + + await user.click(screen.getByRole("button", { name: "Save Changes" })); + + await waitFor(() => { + expect(screen.getByRole("alert").textContent).toContain( + "Failed to update note type. Please try again.", + ); + }); + }); + + it("displays error when not authenticated", async () => { + const user = userEvent.setup(); + + vi.mocked(apiClient.getAuthHeader).mockReturnValue(undefined); + + render(); + + await user.click(screen.getByRole("button", { name: "Save Changes" })); + + await waitFor(() => { + expect(screen.getByRole("alert").textContent).toContain( + "Not authenticated", + ); + }); + }); + + it("updates form when noteType prop changes", () => { + const { rerender } = render(); + + expect(screen.getByLabelText("Name")).toHaveProperty("value", "Basic"); + + const newNoteType = { + id: "note-type-456", + name: "Another Note Type", + frontTemplate: "Q: {{Front}}", + backTemplate: "A: {{Back}}", + isReversible: true, + }; + + rerender(); + + expect(screen.getByLabelText("Name")).toHaveProperty( + "value", + "Another Note Type", + ); + expect(screen.getByLabelText("Front Template")).toHaveProperty( + "value", + "Q: {{Front}}", + ); + expect(screen.getByLabelText("Back Template")).toHaveProperty( + "value", + "A: {{Back}}", + ); + expect(screen.getByLabelText("Create reversed cards")).toHaveProperty( + "checked", + true, + ); + }); + + it("clears error when modal is closed", async () => { + const user = userEvent.setup(); + const onClose = vi.fn(); + + mockFetch.mockResolvedValue({ + ok: false, + status: 404, + json: async () => ({ error: "Some error" }), + }); + + const { rerender } = render( + , + ); + + // Trigger error + await user.click(screen.getByRole("button", { name: "Save Changes" })); + await waitFor(() => { + expect(screen.getByRole("alert")).toBeDefined(); + }); + + // Close and reopen the modal + await user.click(screen.getByRole("button", { name: "Cancel" })); + rerender(); + + // Error should be cleared + expect(screen.queryByRole("alert")).toBeNull(); + }); +}); diff --git a/src/client/components/EditNoteTypeModal.tsx b/src/client/components/EditNoteTypeModal.tsx new file mode 100644 index 0000000..b5d453d --- /dev/null +++ b/src/client/components/EditNoteTypeModal.tsx @@ -0,0 +1,239 @@ +import { type FormEvent, useEffect, useState } from "react"; +import { ApiClientError, apiClient } from "../api"; + +interface NoteType { + id: string; + name: string; + frontTemplate: string; + backTemplate: string; + isReversible: boolean; +} + +interface EditNoteTypeModalProps { + isOpen: boolean; + noteType: NoteType | null; + onClose: () => void; + onNoteTypeUpdated: () => void; +} + +export function EditNoteTypeModal({ + isOpen, + noteType, + onClose, + onNoteTypeUpdated, +}: EditNoteTypeModalProps) { + const [name, setName] = useState(""); + const [frontTemplate, setFrontTemplate] = useState(""); + const [backTemplate, setBackTemplate] = useState(""); + const [isReversible, setIsReversible] = useState(false); + const [error, setError] = useState(null); + const [isSubmitting, setIsSubmitting] = useState(false); + + // Sync form state when noteType changes + useEffect(() => { + if (noteType) { + setName(noteType.name); + setFrontTemplate(noteType.frontTemplate); + setBackTemplate(noteType.backTemplate); + setIsReversible(noteType.isReversible); + setError(null); + } + }, [noteType]); + + const handleClose = () => { + setError(null); + onClose(); + }; + + const handleSubmit = async (e: FormEvent) => { + e.preventDefault(); + if (!noteType) return; + + setError(null); + setIsSubmitting(true); + + try { + const authHeader = apiClient.getAuthHeader(); + if (!authHeader) { + throw new ApiClientError("Not authenticated", 401); + } + + const res = await fetch(`/api/note-types/${noteType.id}`, { + method: "PUT", + headers: { + "Content-Type": "application/json", + ...authHeader, + }, + body: JSON.stringify({ + name: name.trim(), + frontTemplate: frontTemplate.trim(), + backTemplate: backTemplate.trim(), + isReversible, + }), + }); + + if (!res.ok) { + const errorBody = await res.json().catch(() => ({})); + throw new ApiClientError( + (errorBody as { error?: string }).error || + `Request failed with status ${res.status}`, + res.status, + ); + } + + onNoteTypeUpdated(); + onClose(); + } catch (err) { + if (err instanceof ApiClientError) { + setError(err.message); + } else { + setError("Failed to update note type. Please try again."); + } + } finally { + setIsSubmitting(false); + } + }; + + if (!isOpen || !noteType) { + return null; + } + + return ( +
{ + if (e.target === e.currentTarget) { + handleClose(); + } + }} + onKeyDown={(e) => { + if (e.key === "Escape") { + handleClose(); + } + }} + > +
+
+

+ Edit Note Type +

+ +
+ {error && ( +
+ {error} +
+ )} + +
+ + setName(e.target.value)} + required + maxLength={255} + disabled={isSubmitting} + className="w-full px-4 py-2.5 bg-ivory border border-border rounded-lg text-slate placeholder-muted transition-all duration-200 hover:border-muted focus:border-primary focus:ring-2 focus:ring-primary/10 disabled:opacity-50 disabled:cursor-not-allowed" + /> +
+ +
+ + setFrontTemplate(e.target.value)} + required + maxLength={1000} + disabled={isSubmitting} + className="w-full px-4 py-2.5 bg-ivory border border-border rounded-lg text-slate placeholder-muted font-mono text-sm transition-all duration-200 hover:border-muted focus:border-primary focus:ring-2 focus:ring-primary/10 disabled:opacity-50 disabled:cursor-not-allowed" + /> +

+ Use {"{{FieldName}}"} to insert field values +

+
+ +
+ + setBackTemplate(e.target.value)} + required + maxLength={1000} + disabled={isSubmitting} + className="w-full px-4 py-2.5 bg-ivory border border-border rounded-lg text-slate placeholder-muted font-mono text-sm transition-all duration-200 hover:border-muted focus:border-primary focus:ring-2 focus:ring-primary/10 disabled:opacity-50 disabled:cursor-not-allowed" + /> +
+ +
+ setIsReversible(e.target.checked)} + disabled={isSubmitting} + className="w-4 h-4 text-primary bg-ivory border-border rounded focus:ring-primary/20 focus:ring-2 disabled:opacity-50" + /> + +
+

+ Only affects new notes; existing cards are not modified +

+ +
+ + +
+
+
+
+
+ ); +} diff --git a/src/client/pages/HomePage.tsx b/src/client/pages/HomePage.tsx index b7b2c29..9b9f2de 100644 --- a/src/client/pages/HomePage.tsx +++ b/src/client/pages/HomePage.tsx @@ -1,5 +1,6 @@ import { faBoxOpen, + faLayerGroup, faPen, faPlus, faSpinner, @@ -80,6 +81,18 @@ export function HomePage() {
+ +
+ + {/* Loading State */} + {isLoading && ( +
+
+ )} + + {/* Error State */} + {error && ( +
+ {error} + +
+ )} + + {/* Empty State */} + {!isLoading && !error && noteTypes.length === 0 && ( +
+
+
+

+ No note types yet +

+

+ Create a note type to define how your cards are structured +

+ +
+ )} + + {/* Note Type List */} + {!isLoading && !error && noteTypes.length > 0 && ( +
+ {noteTypes.map((noteType, index) => ( +
+
+
+
+
+
+ + Front: {noteType.frontTemplate} + + + Back: {noteType.backTemplate} + + {noteType.isReversible && ( + + Reversible + + )} +
+
+
+ + +
+
+
+ ))} +
+ )} + + + {/* Modals */} + setIsCreateModalOpen(false)} + onNoteTypeCreated={fetchNoteTypes} + /> + + setEditingNoteType(null)} + onNoteTypeUpdated={fetchNoteTypes} + /> + + setDeletingNoteType(null)} + onNoteTypeDeleted={fetchNoteTypes} + /> + + ); +} diff --git a/src/client/pages/index.ts b/src/client/pages/index.ts index 3fb507a..597ea39 100644 --- a/src/client/pages/index.ts +++ b/src/client/pages/index.ts @@ -1,5 +1,6 @@ export { DeckDetailPage } from "./DeckDetailPage"; export { HomePage } from "./HomePage"; export { LoginPage } from "./LoginPage"; +export { NoteTypesPage } from "./NoteTypesPage"; export { NotFoundPage } from "./NotFoundPage"; export { StudyPage } from "./StudyPage"; -- cgit v1.2.3-70-g09d2