From ae1aa6540761e54a76b8f7984cf93cd3a0d011d0 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 3 May 2026 11:55:03 +0900 Subject: refactor: switch internal maps/sets from HashMap to IndexMap Adopt indexmap workspace-wide so iteration order is deterministic and follows insertion order. The non-deterministic order of std HashMap otherwise leaks into resolver decisions when multiple valid solutions exist (e.g. cyclic require pairs under prefer-lowest), making behavior flaky and divergent from Composer's PHP-array semantics. Co-Authored-By: Claude Opus 4.7 (1M context) --- crates/mozart-autoload/src/autoload.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'crates/mozart-autoload/src/autoload.rs') diff --git a/crates/mozart-autoload/src/autoload.rs b/crates/mozart-autoload/src/autoload.rs index 069fcfa..5e5d702 100644 --- a/crates/mozart-autoload/src/autoload.rs +++ b/crates/mozart-autoload/src/autoload.rs @@ -1,7 +1,8 @@ +use indexmap::IndexSet; use mozart_class_map_generator::{scan_classmap_dirs, scan_psr_for_classmap}; use mozart_registry::installed::InstalledPackages; use mozart_registry::lockfile::LockedPackage; -use std::collections::{BTreeMap, HashSet}; +use std::collections::BTreeMap; use std::path::{Path, PathBuf}; // Embed Composer PHP files from the submodule at compile time. @@ -470,7 +471,7 @@ fn generate_platform_check( packages: &[LockedPackage], root_require: Option<&serde_json::Value>, mode: &PlatformCheckMode, - dev_package_names: &HashSet, + dev_package_names: &IndexSet, ) -> Option { if matches!(mode, PlatformCheckMode::Disabled) { return None; @@ -934,7 +935,7 @@ pub fn generate(config: &AutoloadConfig) -> anyhow::Result { } // 4a. Generate platform_check.php if needed - let dev_package_names_set: HashSet = installed + let dev_package_names_set: IndexSet = installed .dev_package_names .iter() .map(|n| n.to_lowercase()) -- cgit v1.3.1