From ae1aa6540761e54a76b8f7984cf93cd3a0d011d0 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 3 May 2026 11:55:03 +0900 Subject: refactor: switch internal maps/sets from HashMap to IndexMap Adopt indexmap workspace-wide so iteration order is deterministic and follows insertion order. The non-deterministic order of std HashMap otherwise leaks into resolver decisions when multiple valid solutions exist (e.g. cyclic require pairs under prefer-lowest), making behavior flaky and divergent from Composer's PHP-array semantics. Co-Authored-By: Claude Opus 4.7 (1M context) --- crates/mozart-sat-resolver/src/decisions.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'crates/mozart-sat-resolver/src/decisions.rs') diff --git a/crates/mozart-sat-resolver/src/decisions.rs b/crates/mozart-sat-resolver/src/decisions.rs index abfbe3d..e9cc935 100644 --- a/crates/mozart-sat-resolver/src/decisions.rs +++ b/crates/mozart-sat-resolver/src/decisions.rs @@ -1,7 +1,7 @@ use crate::error::SolverBugError; use crate::pool::{Literal, PackageId, literal_to_package_id}; use crate::rule_set::RuleId; -use std::collections::HashMap; +use indexmap::IndexMap; /// A decision entry: which literal was decided and which rule caused it. #[derive(Debug, Clone)] @@ -16,7 +16,7 @@ pub struct Decision { pub struct Decisions { /// Package ID → signed level. Positive = install, negative = uninstall. /// The absolute value is the decision level. - decision_map: HashMap, + decision_map: IndexMap, /// Queue of decisions in order. decision_queue: Vec, } @@ -24,7 +24,7 @@ pub struct Decisions { impl Decisions { pub fn new() -> Self { Decisions { - decision_map: HashMap::new(), + decision_map: IndexMap::new(), decision_queue: Vec::new(), } } -- cgit v1.3.1