From ae1aa6540761e54a76b8f7984cf93cd3a0d011d0 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 3 May 2026 11:55:03 +0900 Subject: refactor: switch internal maps/sets from HashMap to IndexMap Adopt indexmap workspace-wide so iteration order is deterministic and follows insertion order. The non-deterministic order of std HashMap otherwise leaks into resolver decisions when multiple valid solutions exist (e.g. cyclic require pairs under prefer-lowest), making behavior flaky and divergent from Composer's PHP-array semantics. Co-Authored-By: Claude Opus 4.7 (1M context) --- crates/mozart-sat-resolver/src/request.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'crates/mozart-sat-resolver/src/request.rs') diff --git a/crates/mozart-sat-resolver/src/request.rs b/crates/mozart-sat-resolver/src/request.rs index 94891f0..26c17ba 100644 --- a/crates/mozart-sat-resolver/src/request.rs +++ b/crates/mozart-sat-resolver/src/request.rs @@ -1,5 +1,5 @@ use crate::pool::PackageId; -use std::collections::HashMap; +use indexmap::IndexMap; /// A requirement: package name + version constraint string. #[derive(Debug, Clone)] @@ -14,7 +14,7 @@ pub struct Require { #[derive(Debug, Clone)] pub struct Request { /// Root requirements: package name → constraint string. - pub requires: HashMap>, + pub requires: IndexMap>, /// Fixed packages (must be installed, cannot be modified). pub fixed_packages: Vec, /// Locked packages (installed but can be removed if nothing requires them). @@ -24,7 +24,7 @@ pub struct Request { impl Request { pub fn new() -> Self { Request { - requires: HashMap::new(), + requires: IndexMap::new(), fixed_packages: Vec::new(), locked_packages: Vec::new(), } -- cgit v1.3.1