fix(fs): carry file_get_contents results as bytes

file_get_contents() and file_get_contents_with_max_length() return
Vec<u8> instead of a from_utf8_lossy'd String.
Call sites whose consumer takes a &str still convert lossily and are
marked TODO(bytes).

file_get_contents_with_max_length() now reads at most the requested
number of bytes instead of the whole file.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

1 files changed, 7 insertions, 3 deletions

diff --git a/crates/shirabe-class-map-generator/src/php_file_parser.rs b/crates/shirabe-class-map-generator/src/php_file_parser.rs
index 0cb9180f..450bea90 100644
--- a/crates/shirabe-class-map-generator/src/php_file_parser.rs
+++ b/crates/shirabe-class-map-generator/src/php_file_parser.rs
@@ -28,8 +28,12 @@ impl PhpFileParser {
                         "File at \"{}\" is not readable, check its permissions",
                         path
                     );
-                } else if trim(file_get_contents(path).unwrap_or_default().as_str(), None)
-                    .is_empty()
+                // TODO(bytes)
+                } else if trim(
+                    &String::from_utf8_lossy(&file_get_contents(path).unwrap_or_default()),
+                    None,
+                )
+                .is_empty()
                 {
                     // The input file was really empty and thus contains no classes
                     return Ok(vec![]);
@@ -178,7 +182,7 @@ impl PhpFileParser {
         }
 
         if is_file(path) {
-            return file_get_contents(path).is_some();
+            return file_get_contents(path).is_ok();
         }
 
         // assume false otherwise