aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-08 22:14:12 +0900
committernsfisis <nsfisis@gmail.com>2026-08-08 22:14:12 +0900
commitf4cad2123b2af0de72bda4ce039e16e74f163f4e (patch)
tree21803308c5ff41e23c9d3b117433eea16b4ff663 /crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs
parent0209f63210e5b547b5c6b73367bb80ea86c255ec (diff)
downloadphp-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.tar.gz
php-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.tar.zst
php-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.zip
feat(php-shim): give ported exceptions PHP's class hierarchy
Ported exceptions were flat structs reached with `downcast_ref`, so Composer's `catch (\RuntimeException $e)` only matched the exact leaf type and `get_class($e)` had nothing to report. Each exception now embeds an instance of the class it extends and travels inside an `AnyThrowable`; `Catch::catch`/`catch_mut` walk that chain, and `PhpClass::php_class_name` yields the PHP FQCN. Dropping the `std::error::Error` impls from the exception types leaves `AnyThrowable` as the only route into an `anyhow::Error`, so the walk cannot be bypassed. A `no_exception_downcast` linter catches the `downcast::<X>()` calls that would now silently answer `None`. Three sites change behavior as a result: the `TransportException` exit-code override reaches `MaxFileSizeExceededException`, the `catch (\LogicException)` in findSimilar() reaches its subclasses, and rendered exception titles carry the real class name rather than a guess. `get_class_err()` is no longer a `todo!()`, which re-enables FilesystemRepositoryTest::testCorruptedRepositoryFile. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs')
-rw-r--r--crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs45
1 files changed, 15 insertions, 30 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs b/crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs
index 987c43f1..2091225d 100644
--- a/crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs
@@ -185,12 +185,7 @@ pub trait QuestionHelperInterface {
}
if matches!(read, PhpMixed::Bool(false)) {
- return Ok(Err(MissingInputException(RuntimeException(
- shirabe_php_shim::RuntimeException {
- message: "Aborted.".to_string(),
- code: 0,
- },
- ))));
+ return Ok(Err(MissingInputException::new("Aborted.".to_string())));
}
r = read;
if question.is_trimmable() {
@@ -263,17 +258,19 @@ pub trait QuestionHelperInterface {
// The validator return type is fixed to InvalidArgumentException here, so the
// RuntimeException rethrow branch is statically unreachable; record the error
// and retry.
- error = Some(shirabe_php_shim::Exception {
- message: e.0.message.clone(),
- code: e.0.code,
- });
+ error = Some(shirabe_php_shim::Exception::with_code(
+ e.get_message().to_string(),
+ e.get_code(),
+ ));
}
}
}
// throw $error;
Err(anyhow::Error::msg(
- error.map(|e| e.message).unwrap_or_default(),
+ error
+ .map(|e| e.get_message().to_string())
+ .unwrap_or_default(),
))
}
@@ -415,12 +412,12 @@ impl QuestionHelper {
let formatter = helper_set.borrow().get_formatter();
formatter.borrow().format_block(
- FormatBlockMessages::String(error.message.clone()),
+ FormatBlockMessages::String(error.get_message().to_string()),
"error",
false,
)
} else {
- format!("<error>{}</error>", error.message)
+ format!("<error>{}</error>", error.get_message())
};
output
@@ -491,12 +488,7 @@ impl QuestionHelper {
&& matches!(question.get_default(), PhpMixed::Null))
{
shirabe_php_shim::shell_exec(&format!("stty {}", stty_mode));
- return Err(MissingInputException(RuntimeException(
- shirabe_php_shim::RuntimeException {
- message: "Aborted.".to_string(),
- code: 0,
- },
- )));
+ return Err(MissingInputException::new("Aborted.".to_string()));
} else if c.as_deref() == Some("\u{7f}") {
// Backspace Character
if 0 == num_matches && 0 != i {
@@ -730,10 +722,9 @@ impl QuestionHelper {
stty_mode = shirabe_php_shim::shell_exec("stty -g").unwrap_or_default();
shirabe_php_shim::shell_exec("stty -echo");
} else if self.is_interactive_input(input_stream) {
- return Ok(Err(RuntimeException(shirabe_php_shim::RuntimeException {
- message: "Unable to hide the response.".to_string(),
- code: 0,
- })));
+ return Ok(Err(RuntimeException::new(
+ "Unable to hide the response.".to_string(),
+ )));
}
let value = shirabe_php_shim::fgets(input_stream, Some(4096));
@@ -745,13 +736,7 @@ impl QuestionHelper {
let mut value = match value {
Some(value) => value,
None => {
- return Err(MissingInputException(RuntimeException(
- shirabe_php_shim::RuntimeException {
- message: "Aborted.".to_string(),
- code: 0,
- },
- ))
- .into());
+ return Err(MissingInputException::new("Aborted.".to_string()).into());
}
};
if trimmable {