aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-external-packages/src/symfony/console/helper/table.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-08 22:14:12 +0900
committernsfisis <nsfisis@gmail.com>2026-08-08 22:14:12 +0900
commitf4cad2123b2af0de72bda4ce039e16e74f163f4e (patch)
tree21803308c5ff41e23c9d3b117433eea16b4ff663 /crates/shirabe-external-packages/src/symfony/console/helper/table.rs
parent0209f63210e5b547b5c6b73367bb80ea86c255ec (diff)
downloadphp-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.tar.gz
php-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.tar.zst
php-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.zip
feat(php-shim): give ported exceptions PHP's class hierarchy
Ported exceptions were flat structs reached with `downcast_ref`, so Composer's `catch (\RuntimeException $e)` only matched the exact leaf type and `get_class($e)` had nothing to report. Each exception now embeds an instance of the class it extends and travels inside an `AnyThrowable`; `Catch::catch`/`catch_mut` walk that chain, and `PhpClass::php_class_name` yields the PHP FQCN. Dropping the `std::error::Error` impls from the exception types leaves `AnyThrowable` as the only route into an `anyhow::Error`, so the walk cannot be bypassed. A `no_exception_downcast` linter catches the `downcast::<X>()` calls that would now silently answer `None`. Three sites change behavior as a result: the `TransportException` exit-code override reaches `MaxFileSizeExceededException`, the `catch (\LogicException)` in findSimilar() reaches its subclasses, and rendered exception titles carry the real class name rather than a guess. `get_class_err()` is no longer a `todo!()`, which re-enables FilesystemRepositoryTest::testCorruptedRepositoryFile. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony/console/helper/table.rs')
-rw-r--r--crates/shirabe-external-packages/src/symfony/console/helper/table.rs33
1 files changed, 13 insertions, 20 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/table.rs b/crates/shirabe-external-packages/src/symfony/console/helper/table.rs
index 66ab3174..a1f5a11e 100644
--- a/crates/shirabe-external-packages/src/symfony/console/helper/table.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/helper/table.rs
@@ -325,12 +325,10 @@ impl Table {
return Ok(Ok(style.clone()));
}
- Ok(Err(InvalidArgumentException(
- shirabe_php_shim::InvalidArgumentException {
- message: format!("Style \"{}\" is not defined.", name),
- code: 0,
- },
- )))
+ Ok(Err(InvalidArgumentException::new(format!(
+ "Style \"{}\" is not defined.",
+ name
+ ))))
}
/// Sets table style.
@@ -454,14 +452,11 @@ impl Table {
/// Adds a row to the table, and re-renders the table.
pub fn append_row(&mut self, row: Row) -> anyhow::Result<Result<&mut Self, RuntimeException>> {
if !Self::output_is_console_section(&self.output) {
- return Ok(Err(RuntimeException(shirabe_php_shim::RuntimeException {
- message: format!(
- "Output should be an instance of \"{}\" when calling \"{}\".",
- "Symfony\\Component\\Console\\Output\\ConsoleSectionOutput",
- "Symfony\\Component\\Console\\Helper\\Table::appendRow",
- ),
- code: 0,
- })));
+ return Ok(Err(RuntimeException::new(format!(
+ "Output should be an instance of \"{}\" when calling \"{}\".",
+ "Symfony\\Component\\Console\\Output\\ConsoleSectionOutput",
+ "Symfony\\Component\\Console\\Helper\\Table::appendRow",
+ ))));
}
if self.rendered {
@@ -1373,12 +1368,10 @@ impl Table {
return Ok(Ok(style.clone()));
}
- Ok(Err(InvalidArgumentException(
- shirabe_php_shim::InvalidArgumentException {
- message: format!("Style \"{}\" is not defined.", name),
- code: 0,
- },
- )))
+ Ok(Err(InvalidArgumentException::new(format!(
+ "Style \"{}\" is not defined.",
+ name
+ ))))
}
fn formatter_is_wrappable(