aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-external-packages/src/symfony/console/input/input.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-08 22:14:12 +0900
committernsfisis <nsfisis@gmail.com>2026-08-08 22:14:12 +0900
commitf4cad2123b2af0de72bda4ce039e16e74f163f4e (patch)
tree21803308c5ff41e23c9d3b117433eea16b4ff663 /crates/shirabe-external-packages/src/symfony/console/input/input.rs
parent0209f63210e5b547b5c6b73367bb80ea86c255ec (diff)
downloadphp-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.tar.gz
php-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.tar.zst
php-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.zip
feat(php-shim): give ported exceptions PHP's class hierarchy
Ported exceptions were flat structs reached with `downcast_ref`, so Composer's `catch (\RuntimeException $e)` only matched the exact leaf type and `get_class($e)` had nothing to report. Each exception now embeds an instance of the class it extends and travels inside an `AnyThrowable`; `Catch::catch`/`catch_mut` walk that chain, and `PhpClass::php_class_name` yields the PHP FQCN. Dropping the `std::error::Error` impls from the exception types leaves `AnyThrowable` as the only route into an `anyhow::Error`, so the walk cannot be bypassed. A `no_exception_downcast` linter catches the `downcast::<X>()` calls that would now silently answer `None`. Three sites change behavior as a result: the `TransportException` exit-code override reaches `MaxFileSizeExceededException`, the `catch (\LogicException)` in findSimilar() reaches its subclasses, and rendered exception titles carry the real class name rather than a guess. `get_class_err()` is no longer a `todo!()`, which re-enables FilesystemRepositoryTest::testCorruptedRepositoryFile. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony/console/input/input.rs')
-rw-r--r--crates/shirabe-external-packages/src/symfony/console/input/input.rs59
1 files changed, 24 insertions, 35 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/console/input/input.rs b/crates/shirabe-external-packages/src/symfony/console/input/input.rs
index e14ed354..ceff85f6 100644
--- a/crates/shirabe-external-packages/src/symfony/console/input/input.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/input/input.rs
@@ -80,13 +80,10 @@ impl Input {
);
if !missing_arguments.is_empty() {
- return Err(RuntimeException(shirabe_php_shim::RuntimeException {
- message: format!(
- "Not enough arguments (missing: \"{}\").",
- shirabe_php_shim::implode(", ", &missing_arguments),
- ),
- code: 0,
- })
+ return Err(RuntimeException::new(format!(
+ "Not enough arguments (missing: \"{}\").",
+ shirabe_php_shim::implode(", ", &missing_arguments),
+ ))
.into());
}
@@ -113,13 +110,11 @@ impl Input {
.definition
.has_argument(&PhpMixed::String(name.to_string()))
{
- return Err(
- InvalidArgumentException(shirabe_php_shim::InvalidArgumentException {
- message: format!("The \"{}\" argument does not exist.", name),
- code: 0,
- })
- .into(),
- );
+ return Err(InvalidArgumentException::new(format!(
+ "The \"{}\" argument does not exist.",
+ name
+ ))
+ .into());
}
Ok(match self.arguments.get(name) {
@@ -137,13 +132,11 @@ impl Input {
.definition
.has_argument(&PhpMixed::String(name.to_string()))
{
- return Err(
- InvalidArgumentException(shirabe_php_shim::InvalidArgumentException {
- message: format!("The \"{}\" argument does not exist.", name),
- code: 0,
- })
- .into(),
- );
+ return Err(InvalidArgumentException::new(format!(
+ "The \"{}\" argument does not exist.",
+ name
+ ))
+ .into());
}
self.arguments.insert(name.to_string(), value);
@@ -174,13 +167,11 @@ impl Input {
}
if !self.definition.has_option(name) {
- return Err(
- InvalidArgumentException(shirabe_php_shim::InvalidArgumentException {
- message: format!("The \"{}\" option does not exist.", name),
- code: 0,
- })
- .into(),
- );
+ return Err(InvalidArgumentException::new(format!(
+ "The \"{}\" option does not exist.",
+ name
+ ))
+ .into());
}
Ok(if self.options.contains_key(name) {
@@ -198,13 +189,11 @@ impl Input {
return Ok(());
} else if !self.definition.has_option(name) {
- return Err(
- InvalidArgumentException(shirabe_php_shim::InvalidArgumentException {
- message: format!("The \"{}\" option does not exist.", name),
- code: 0,
- })
- .into(),
- );
+ return Err(InvalidArgumentException::new(format!(
+ "The \"{}\" option does not exist.",
+ name
+ ))
+ .into());
}
self.options.insert(name.to_string(), value);