diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-08 03:24:27 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-08 03:25:02 +0900 |
| commit | b4f16a379e919eefc2cb37bcddee589c0f26eaad (patch) | |
| tree | fcd970b83deb89a04fb5daf2c107d6f75b34e0f2 /crates/shirabe-external-packages | |
| parent | da0d38a8e16ebefd59ef5291b5788e6238cc78ba (diff) | |
| download | php-shirabe-b4f16a379e919eefc2cb37bcddee589c0f26eaad.tar.gz php-shirabe-b4f16a379e919eefc2cb37bcddee589c0f26eaad.tar.zst php-shirabe-b4f16a379e919eefc2cb37bcddee589c0f26eaad.zip | |
refactor(php-shim): dispatch spl_object_hash on Rc and references
Getting a rule's identity meant spl_object_hash(&*rule.borrow()), so the
solver borrowed a RefCell just to read an address, and a second function
spl_object_hash_process existed because one generic fn cannot tell Rc<T>
from &T.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-external-packages')
| -rw-r--r-- | crates/shirabe-external-packages/src/symfony/console/helper/process_helper.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/process_helper.rs b/crates/shirabe-external-packages/src/symfony/console/helper/process_helper.rs index 58d1ea3f..312d8e15 100644 --- a/crates/shirabe-external-packages/src/symfony/console/helper/process_helper.rs +++ b/crates/shirabe-external-packages/src/symfony/console/helper/process_helper.rs @@ -116,7 +116,7 @@ impl ProcessHelper { if verbosity <= output.borrow().get_verbosity() { let started = Self::formatter_start( &formatter, - &shirabe_php_shim::spl_object_hash_process(&process), + &shirabe_php_shim::spl_object_hash(&process), &self.escape_string(&process.get_command_line()), ); output @@ -163,7 +163,7 @@ impl ProcessHelper { }; let stopped = Self::formatter_stop( &formatter, - &shirabe_php_shim::spl_object_hash_process(&process), + &shirabe_php_shim::spl_object_hash(&process), &message, process.is_successful(), ); @@ -242,7 +242,7 @@ impl ProcessHelper { .borrow() .get_debug_formatter(); - let object_hash = shirabe_php_shim::spl_object_hash_process(process); + let object_hash = shirabe_php_shim::spl_object_hash(process); Box::new(move |r#type: &str, buffer: &str| { let progressed = Self::formatter_progress( |