diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-16 13:59:28 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-16 13:59:28 +0900 |
| commit | b4ab3df2ec85fbe477d7721344a8cd3630b437a1 (patch) | |
| tree | eb618cbbdfa46cf829031f9c427dc09ef7584831 /crates/shirabe-php-rpc/php/guards/Composer/Downloader/PerforceDownloader.php | |
| parent | baf9aff3134ac5a10260d3be421a2c17a0180d64 (diff) | |
| download | php-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.tar.gz php-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.tar.zst php-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.zip | |
feat(plugin): guard Rust-owned classes the worker has no proxy for
The worker's autoloader fell through to the real Composer source for every
Rust-owned FQCN without a proxy stub, so plugin code doing `new Filesystem()`
or subclassing `LibraryInstaller` silently ran on a second instance the Rust
side never sees. An unimplemented part of the plugin API has to fail with an
explicit error naming it, not quietly work on a disconnected copy.
The stub generator now emits a guard class for each of those FQCNs: the real
declaration, hierarchy and constants, with every constructor and method
raising an explicit error. References satisfied by the declaration alone
(`instanceof`, `X::class`, `Link::TYPE_REQUIRE`) keep working. Two FQCNs stay
resolvable to the real class, each listed with the worker-side mechanism that
makes a natively constructed instance correct.
The error had nowhere to go: `Installer::run` dropped the `Result` of both
`dispatch_script` calls, so an exception from a listener ended in exit 0.
Both propagate now, the way the exception does upstream.
Three real-plugin E2E comparisons stop at a guard and are ignored, each
naming the class it needs.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-php-rpc/php/guards/Composer/Downloader/PerforceDownloader.php')
| -rw-r--r-- | crates/shirabe-php-rpc/php/guards/Composer/Downloader/PerforceDownloader.php | 111 |
1 files changed, 111 insertions, 0 deletions
diff --git a/crates/shirabe-php-rpc/php/guards/Composer/Downloader/PerforceDownloader.php b/crates/shirabe-php-rpc/php/guards/Composer/Downloader/PerforceDownloader.php new file mode 100644 index 00000000..91eb45cf --- /dev/null +++ b/crates/shirabe-php-rpc/php/guards/Composer/Downloader/PerforceDownloader.php @@ -0,0 +1,111 @@ +<?php + +// Generated by scripts/plugin-stub-generator; do not edit by hand. +// Guard for Composer\Downloader\PerforceDownloader. +// The Rust side owns this class and the worker has no proxy for it, so this +// declaration shadows the real one: the constants and the hierarchy stay, while +// constructing it or calling anything on it raises an explicit error. + +namespace Composer\Downloader; + +use React\Promise\PromiseInterface; +use Composer\Package\PackageInterface; +use Composer\Util\Perforce; + +class PerforceDownloader extends VcsDownloader +{ + protected function doDownload(PackageInterface $package, string $path, string $url, ?PackageInterface $prevPackage = null): PromiseInterface + { + \ShirabeUnsupportedClass::fail(self::class, 'doDownload'); + } + + public function doInstall(PackageInterface $package, string $path, string $url): PromiseInterface + { + \ShirabeUnsupportedClass::fail(self::class, 'doInstall'); + } + + public function initPerforce(PackageInterface $package, string $path, string $url): void + { + \ShirabeUnsupportedClass::fail(self::class, 'initPerforce'); + } + + protected function doUpdate(PackageInterface $initial, PackageInterface $target, string $path, string $url): PromiseInterface + { + \ShirabeUnsupportedClass::fail(self::class, 'doUpdate'); + } + + public function getLocalChanges(PackageInterface $package, string $path): ?string + { + \ShirabeUnsupportedClass::fail(self::class, 'getLocalChanges'); + } + + protected function getCommitLogs(string $fromReference, string $toReference, string $path): string + { + \ShirabeUnsupportedClass::fail(self::class, 'getCommitLogs'); + } + + public function setPerforce(Perforce $perforce): void + { + \ShirabeUnsupportedClass::fail(self::class, 'setPerforce'); + } + + protected function hasMetadataRepository(string $path): bool + { + \ShirabeUnsupportedClass::fail(self::class, 'hasMetadataRepository'); + } + + public function __construct(IOInterface $io, Config $config, ?ProcessExecutor $process = null, ?Filesystem $fs = null) + { + \ShirabeUnsupportedClass::fail(self::class, '__construct'); + } + + public function getInstallationSource(): string + { + \ShirabeUnsupportedClass::fail(self::class, 'getInstallationSource'); + } + + public function download(PackageInterface $package, string $path, ?PackageInterface $prevPackage = null): PromiseInterface + { + \ShirabeUnsupportedClass::fail(self::class, 'download'); + } + + public function prepare(string $type, PackageInterface $package, string $path, ?PackageInterface $prevPackage = null): PromiseInterface + { + \ShirabeUnsupportedClass::fail(self::class, 'prepare'); + } + + public function cleanup(string $type, PackageInterface $package, string $path, ?PackageInterface $prevPackage = null): PromiseInterface + { + \ShirabeUnsupportedClass::fail(self::class, 'cleanup'); + } + + public function install(PackageInterface $package, string $path): PromiseInterface + { + \ShirabeUnsupportedClass::fail(self::class, 'install'); + } + + public function update(PackageInterface $initial, PackageInterface $target, string $path): PromiseInterface + { + \ShirabeUnsupportedClass::fail(self::class, 'update'); + } + + public function remove(PackageInterface $package, string $path): PromiseInterface + { + \ShirabeUnsupportedClass::fail(self::class, 'remove'); + } + + public function getVcsReference(PackageInterface $package, string $path): ?string + { + \ShirabeUnsupportedClass::fail(self::class, 'getVcsReference'); + } + + protected function cleanChanges(PackageInterface $package, string $path, bool $update): PromiseInterface + { + \ShirabeUnsupportedClass::fail(self::class, 'cleanChanges'); + } + + protected function reapplyChanges(string $path): void + { + \ShirabeUnsupportedClass::fail(self::class, 'reapplyChanges'); + } +} |
