diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-16 13:59:28 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-16 13:59:28 +0900 |
| commit | b4ab3df2ec85fbe477d7721344a8cd3630b437a1 (patch) | |
| tree | eb618cbbdfa46cf829031f9c427dc09ef7584831 /crates/shirabe-php-rpc/php/guards/Composer/Package/Loader | |
| parent | baf9aff3134ac5a10260d3be421a2c17a0180d64 (diff) | |
| download | php-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.tar.gz php-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.tar.zst php-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.zip | |
feat(plugin): guard Rust-owned classes the worker has no proxy for
The worker's autoloader fell through to the real Composer source for every
Rust-owned FQCN without a proxy stub, so plugin code doing `new Filesystem()`
or subclassing `LibraryInstaller` silently ran on a second instance the Rust
side never sees. An unimplemented part of the plugin API has to fail with an
explicit error naming it, not quietly work on a disconnected copy.
The stub generator now emits a guard class for each of those FQCNs: the real
declaration, hierarchy and constants, with every constructor and method
raising an explicit error. References satisfied by the declaration alone
(`instanceof`, `X::class`, `Link::TYPE_REQUIRE`) keep working. Two FQCNs stay
resolvable to the real class, each listed with the worker-side mechanism that
makes a natively constructed instance correct.
The error had nowhere to go: `Installer::run` dropped the `Result` of both
`dispatch_script` calls, so an exception from a listener ended in exit 0.
Both propagate now, the way the exception does upstream.
Three real-plugin E2E comparisons stop at a guard and are ignored, each
naming the class it needs.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-php-rpc/php/guards/Composer/Package/Loader')
3 files changed, 123 insertions, 0 deletions
diff --git a/crates/shirabe-php-rpc/php/guards/Composer/Package/Loader/ArrayLoader.php b/crates/shirabe-php-rpc/php/guards/Composer/Package/Loader/ArrayLoader.php new file mode 100644 index 00000000..4e37ad7f --- /dev/null +++ b/crates/shirabe-php-rpc/php/guards/Composer/Package/Loader/ArrayLoader.php @@ -0,0 +1,40 @@ +<?php + +// Generated by scripts/plugin-stub-generator; do not edit by hand. +// Guard for Composer\Package\Loader\ArrayLoader. +// The Rust side owns this class and the worker has no proxy for it, so this +// declaration shadows the real one: the constants and the hierarchy stay, while +// constructing it or calling anything on it raises an explicit error. + +namespace Composer\Package\Loader; + +use Composer\Package\BasePackage; +use Composer\Package\Version\VersionParser; + +class ArrayLoader implements LoaderInterface +{ + public function __construct(?VersionParser $parser = null, bool $loadOptions = false) + { + \ShirabeUnsupportedClass::fail(self::class, '__construct'); + } + + public function load(array $config, string $class = 'Composer\Package\CompletePackage'): BasePackage + { + \ShirabeUnsupportedClass::fail(self::class, 'load'); + } + + public function loadPackages(array $versions): array + { + \ShirabeUnsupportedClass::fail(self::class, 'loadPackages'); + } + + public function parseLinks(string $source, string $sourceVersion, string $description, array $links): array + { + \ShirabeUnsupportedClass::fail(self::class, 'parseLinks'); + } + + public function getBranchAlias(array $config): ?string + { + \ShirabeUnsupportedClass::fail(self::class, 'getBranchAlias'); + } +} diff --git a/crates/shirabe-php-rpc/php/guards/Composer/Package/Loader/RootPackageLoader.php b/crates/shirabe-php-rpc/php/guards/Composer/Package/Loader/RootPackageLoader.php new file mode 100644 index 00000000..3d2d3390 --- /dev/null +++ b/crates/shirabe-php-rpc/php/guards/Composer/Package/Loader/RootPackageLoader.php @@ -0,0 +1,39 @@ +<?php + +// Generated by scripts/plugin-stub-generator; do not edit by hand. +// Guard for Composer\Package\Loader\RootPackageLoader. +// The Rust side owns this class and the worker has no proxy for it, so this +// declaration shadows the real one: the constants and the hierarchy stay, while +// constructing it or calling anything on it raises an explicit error. + +namespace Composer\Package\Loader; + +use Composer\Package\BasePackage; +use Composer\Config; +use Composer\IO\IOInterface; +use Composer\Package\Version\VersionGuesser; +use Composer\Package\Version\VersionParser; +use Composer\Repository\RepositoryManager; + +class RootPackageLoader extends ArrayLoader +{ + public function __construct(RepositoryManager $manager, Config $config, ?VersionParser $parser = null, ?VersionGuesser $versionGuesser = null, ?IOInterface $io = null) + { + \ShirabeUnsupportedClass::fail(self::class, '__construct'); + } + + public function load(array $config, string $class = 'Composer\Package\RootPackage', ?string $cwd = null): BasePackage + { + \ShirabeUnsupportedClass::fail(self::class, 'load'); + } + + public static function extractStabilityFlags(array $requires, string $minimumStability, array $stabilityFlags): array + { + \ShirabeUnsupportedClass::fail(self::class, 'extractStabilityFlags'); + } + + public static function extractReferences(array $requires, array $references): array + { + \ShirabeUnsupportedClass::fail(self::class, 'extractReferences'); + } +} diff --git a/crates/shirabe-php-rpc/php/guards/Composer/Package/Loader/ValidatingArrayLoader.php b/crates/shirabe-php-rpc/php/guards/Composer/Package/Loader/ValidatingArrayLoader.php new file mode 100644 index 00000000..c6f7af70 --- /dev/null +++ b/crates/shirabe-php-rpc/php/guards/Composer/Package/Loader/ValidatingArrayLoader.php @@ -0,0 +1,44 @@ +<?php + +// Generated by scripts/plugin-stub-generator; do not edit by hand. +// Guard for Composer\Package\Loader\ValidatingArrayLoader. +// The Rust side owns this class and the worker has no proxy for it, so this +// declaration shadows the real one: the constants and the hierarchy stay, while +// constructing it or calling anything on it raises an explicit error. + +namespace Composer\Package\Loader; + +use Composer\Package\BasePackage; +use Composer\Package\Version\VersionParser; + +class ValidatingArrayLoader implements LoaderInterface +{ + public const CHECK_ALL = 3; + public const CHECK_UNBOUND_CONSTRAINTS = 1; + public const CHECK_STRICT_CONSTRAINTS = 2; + + public function __construct(LoaderInterface $loader, bool $strictName = true, ?VersionParser $parser = null, int $flags = 0) + { + \ShirabeUnsupportedClass::fail(self::class, '__construct'); + } + + public function load(array $config, string $class = 'Composer\Package\CompletePackage'): BasePackage + { + \ShirabeUnsupportedClass::fail(self::class, 'load'); + } + + public function getWarnings(): array + { + \ShirabeUnsupportedClass::fail(self::class, 'getWarnings'); + } + + public function getErrors(): array + { + \ShirabeUnsupportedClass::fail(self::class, 'getErrors'); + } + + public static function hasPackageNamingError(string $name, bool $isLink = false): ?string + { + \ShirabeUnsupportedClass::fail(self::class, 'hasPackageNamingError'); + } +} |
