aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-symfony-console/src/command/list_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-19 23:45:37 +0900
committernsfisis <nsfisis@gmail.com>2026-08-19 23:45:37 +0900
commit0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc (patch)
treeba5602549ce20b8d71136423e85dffc25deafff4 /crates/shirabe-symfony-console/src/command/list_command.rs
parent6ed3a85dd636366d194c9810fd777db7f25e263f (diff)
downloadphp-shirabe-0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc.tar.gz
php-shirabe-0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc.tar.zst
php-shirabe-0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc.zip
fix(input): thread a typed InputValue through the input layer
Options and arguments were stored and passed as PhpMixed even though Symfony only ever puts a string, a bool, a list of strings or null in one. get_option already narrowed to InputOptionValue at the boundary; this widens that enum into InputValue and pushes it through InputInterface, InputOption/InputArgument defaults, the Input storage, ArgvInput/ArrayInput/StringInput/CompletionInput, Command::add_option and add_argument, and the Composer-side wrappers. Two neighbouring string|int unions get types of their own: InputDefinition::{get_argument,has_argument} take an ArgumentName, and ArrayInput keys its parameters by ParameterName. has_parameter_option and get_parameter_option take the values they look for as &[&str], which is what PHP's `(array) $values` cast produced anyway. Two behaviours change along the way. Input::set_option on a negated option now negates with PHP's loose bool cast rather than treating a non-bool as false, matching `!$value`. ArrayInput::parse now resolves an integer key to an argument position instead of looking up an argument literally named "0". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-symfony-console/src/command/list_command.rs')
-rw-r--r--crates/shirabe-symfony-console/src/command/list_command.rs19
1 files changed, 10 insertions, 9 deletions
diff --git a/crates/shirabe-symfony-console/src/command/list_command.rs b/crates/shirabe-symfony-console/src/command/list_command.rs
index 6074b49a..08faea71 100644
--- a/crates/shirabe-symfony-console/src/command/list_command.rs
+++ b/crates/shirabe-symfony-console/src/command/list_command.rs
@@ -10,8 +10,9 @@ use crate::input::DefinitionItem;
use crate::input::InputArgument;
use crate::input::InputInterface;
use crate::input::InputOption;
+use crate::input::InputValue;
use crate::output::OutputInterface;
-use shirabe_php_shim::{PhpMixed, impl_php_class};
+use shirabe_php_shim::impl_php_class;
use std::ops::{Deref, DerefMut};
/// ListCommand displays the list of all available commands for the application.
@@ -93,28 +94,28 @@ impl Command for ListCommand {
"namespace".to_string(),
Some(InputArgument::OPTIONAL),
"The namespace name".to_string(),
- PhpMixed::Null,
+ InputValue::Null,
)?),
DefinitionItem::InputOption(InputOption::new(
"raw",
- PhpMixed::Null,
+ None,
Some(InputOption::VALUE_NONE),
"To output raw command list".to_string(),
- PhpMixed::Null,
+ InputValue::Null,
)?),
DefinitionItem::InputOption(InputOption::new(
"format",
- PhpMixed::Null,
+ None,
Some(InputOption::VALUE_REQUIRED),
"The output format (txt, xml, json, or md)".to_string(),
- PhpMixed::from("txt".to_string()),
+ InputValue::from("txt".to_string()),
)?),
DefinitionItem::InputOption(InputOption::new(
"short",
- PhpMixed::Null,
+ None,
Some(InputOption::VALUE_NONE),
"To skip describing commands' arguments".to_string(),
- PhpMixed::Null,
+ InputValue::Null,
)?),
]));
self.inner.set_description("List commands");
@@ -157,7 +158,7 @@ impl Command for ListCommand {
);
options.insert(
"namespace".to_string(),
- input.borrow().get_argument("namespace")?,
+ input.borrow().get_argument("namespace")?.into(),
);
options.insert(
"short".to_string(),