aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-symfony-console/src/input
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-18 01:57:02 +0900
committernsfisis <nsfisis@gmail.com>2026-08-18 01:57:02 +0900
commitcb77f7c7076aa4bac3e6aaa1c164cf9c1d449ddc (patch)
tree1402c6cb393dd760dc240532119ee3df1e1be1ec /crates/shirabe-symfony-console/src/input
parent530d085d4f3e19f94ac3cf8f8ac3b17000214b2e (diff)
downloadphp-shirabe-cb77f7c7076aa4bac3e6aaa1c164cf9c1d449ddc.tar.gz
php-shirabe-cb77f7c7076aa4bac3e6aaa1c164cf9c1d449ddc.tar.zst
php-shirabe-cb77f7c7076aa4bac3e6aaa1c164cf9c1d449ddc.zip
refactor(preg): fold preg_match into preg_match2
preg_match copied every group into a Vec<Option<String>> while preg_match2 handed back the borrowed captures. They now differ only in the offset argument, so preg_match delegates with offset 0 and its callers read groups through PregMatches::get. Going through preg_match2 also makes preg_match honour the PCRE A modifier, which it used to ignore; no caller passes such a pattern. VersionParser::manipulate_version_string takes an index accessor instead of a slice, and VersionParser::normalize matches against a copy of the subject because the captures outlive the assignments to $version. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-symfony-console/src/input')
-rw-r--r--crates/shirabe-symfony-console/src/input/argv_input.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/crates/shirabe-symfony-console/src/input/argv_input.rs b/crates/shirabe-symfony-console/src/input/argv_input.rs
index 81582408..94e5299d 100644
--- a/crates/shirabe-symfony-console/src/input/argv_input.rs
+++ b/crates/shirabe-symfony-console/src/input/argv_input.rs
@@ -526,8 +526,8 @@ impl std::fmt::Display for ArgvInput {
if let Some(r#match) = preg_match(php_regex!("{^(-[^=]+=)(.+)}"), token) {
return format!(
"{}{}",
- r#match[1].as_deref().unwrap_or(""),
- self.inner.escape_token(r#match[2].as_deref().unwrap_or(""))
+ r#match.get(1).unwrap_or(""),
+ self.inner.escape_token(r#match.get(2).unwrap_or(""))
);
}