aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-symfony-console/src
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-18 04:47:02 +0900
committernsfisis <nsfisis@gmail.com>2026-08-18 04:47:18 +0900
commitced1f9aa91ee36857fec9664c9ccd86ba2310821 (patch)
tree630ea3eb3b0e710403669de9ba6a78a421e182a8 /crates/shirabe-symfony-console/src
parent6b7c6cb9a3d1cdf93f261238c1edbc70706a33c7 (diff)
downloadphp-shirabe-ced1f9aa91ee36857fec9664c9ccd86ba2310821.tar.gz
php-shirabe-ced1f9aa91ee36857fec9664c9ccd86ba2310821.tar.zst
php-shirabe-ced1f9aa91ee36857fec9664c9ccd86ba2310821.zip
refactor(function-exists): drop checks for always-present capabilities
function_exists() returns false in PHP when a function is blocked by disable_functions, when its extension is not compiled in, or when the PHP version predates it. None of those apply to a native binary.
Diffstat (limited to 'crates/shirabe-symfony-console/src')
-rw-r--r--crates/shirabe-symfony-console/src/output/console_output.rs6
-rw-r--r--crates/shirabe-symfony-console/src/terminal.rs9
2 files changed, 1 insertions, 14 deletions
diff --git a/crates/shirabe-symfony-console/src/output/console_output.rs b/crates/shirabe-symfony-console/src/output/console_output.rs
index 4080d688..9c2904db 100644
--- a/crates/shirabe-symfony-console/src/output/console_output.rs
+++ b/crates/shirabe-symfony-console/src/output/console_output.rs
@@ -98,11 +98,7 @@ impl ConsoleOutput {
/// doesn't properly convert character-encodings between ASCII to EBCDIC.
fn is_running_os400() -> bool {
let checks = [
- if shirabe_php_shim::function_exists("php_uname") {
- shirabe_php_shim::php_uname("s")
- } else {
- String::new()
- },
+ shirabe_php_shim::php_uname("s"),
shirabe_php_shim::getenv("OSTYPE")
.unwrap_or_default()
.to_string_lossy()
diff --git a/crates/shirabe-symfony-console/src/terminal.rs b/crates/shirabe-symfony-console/src/terminal.rs
index 492d8fe2..c7bc82b8 100644
--- a/crates/shirabe-symfony-console/src/terminal.rs
+++ b/crates/shirabe-symfony-console/src/terminal.rs
@@ -62,11 +62,6 @@ impl Terminal {
return stty;
}
- // skip check if shell_exec function is disabled
- if !shirabe_php_shim::function_exists("shell_exec") {
- return false;
- }
-
let result = shirabe_php_shim::shell_exec(&format!(
"stty 2> {}",
if cfg!(windows) { "NUL" } else { "/dev/null" }
@@ -195,10 +190,6 @@ impl Terminal {
}
fn read_from_process(command: &str) -> Option<String> {
- if !shirabe_php_shim::function_exists("proc_open") {
- return None;
- }
-
// Sparse PHP descriptorspec `[1 => ['pipe', 'w'], 2 => ['pipe', 'w']]`: fd 0 is inherited.
let descriptorspec = [
shirabe_php_shim::Descriptor::Inherit,