aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-symfony-finder/src
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-12 00:19:10 +0900
committernsfisis <nsfisis@gmail.com>2026-08-12 00:19:36 +0900
commit561924db750cbb4e4c183f9616472ed9a5b0fc7f (patch)
tree13d27f8c4d3a0fca8cfd447ea32befa9aa358228 /crates/shirabe-symfony-finder/src
parentdaa1acf091627f4f1af63ad44eee988048fa4136 (diff)
downloadphp-shirabe-561924db750cbb4e4c183f9616472ed9a5b0fc7f.tar.gz
php-shirabe-561924db750cbb4e4c183f9616472ed9a5b0fc7f.tar.zst
php-shirabe-561924db750cbb4e4c183f9616472ed9a5b0fc7f.zip
docs(todo): retag TODO markers by root cause
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-symfony-finder/src')
-rw-r--r--crates/shirabe-symfony-finder/src/finder.rs6
-rw-r--r--crates/shirabe-symfony-finder/src/spl_file_info.rs2
2 files changed, 4 insertions, 4 deletions
diff --git a/crates/shirabe-symfony-finder/src/finder.rs b/crates/shirabe-symfony-finder/src/finder.rs
index 2ab096e5..95ab5d50 100644
--- a/crates/shirabe-symfony-finder/src/finder.rs
+++ b/crates/shirabe-symfony-finder/src/finder.rs
@@ -183,7 +183,7 @@ impl Finder {
resolved_dirs.push(self.normalize_dir(&dir));
} else {
// GLOB_ONLYDIR is emulated by retaining directory matches only.
- // TODO(phase-c): wildcard `in()` paths depend on `shirabe_php_shim::glob`, which is
+ // TODO(php-semantics): wildcard `in()` paths depend on `shirabe_php_shim::glob`, which is
// still `todo!()`; only the real-directory branch above currently resolves.
let mut globbed: Vec<String> =
glob(&dir).into_iter().filter(|path| is_dir(path)).collect();
@@ -451,7 +451,7 @@ impl Finder {
out: &mut Vec<Entry>,
) {
// `RecursiveDirectoryIterator::SKIP_DOTS` is implicit: read_dir omits "." and "..".
- // TODO(phase-c): unreadable directories are skipped here; the SplFileInfo-less,
+ // TODO(symfony): unreadable directories are skipped here; the SplFileInfo-less,
// non-fallible iterator signatures cannot surface the AccessDeniedException that PHP
// throws when ignoreUnreadableDirs is false.
let read = match std::fs::read_dir(dir) {
@@ -715,7 +715,7 @@ fn parse_date_comparator(test: &str) -> (String, i64) {
/// `(new \DateTime($s))->format('U')`.
///
-/// TODO(phase-c): PHP's `\DateTime` accepts any strtotime() expression, but only the
+/// TODO(php-semantics): PHP's `\DateTime` accepts any strtotime() expression, but only the
/// `Y-m-d H:i:s` / `Y-m-d` shapes produced by the callers are parsed here. The components are
/// interpreted as UTC (not PHP's local timezone) so the timestamp round-trips with the
/// `chrono::Utc`-derived thresholds the callers format from.
diff --git a/crates/shirabe-symfony-finder/src/spl_file_info.rs b/crates/shirabe-symfony-finder/src/spl_file_info.rs
index 6f03fe14..b719efc5 100644
--- a/crates/shirabe-symfony-finder/src/spl_file_info.rs
+++ b/crates/shirabe-symfony-finder/src/spl_file_info.rs
@@ -78,7 +78,7 @@ impl SplFileInfo {
pub fn get_size(&self) -> i64 {
// \SplFileInfo::getSize() returns the file size in bytes (throws on failure).
- // TODO(phase-c): PHP throws a \RuntimeException on stat failure; this returns 0 instead.
+ // TODO(php-semantics): PHP throws a \RuntimeException on stat failure; this returns 0 instead.
shirabe_php_shim::filesize(&self.pathname).unwrap_or(0)
}
}