aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/autoload
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-19 23:45:38 +0900
committernsfisis <nsfisis@gmail.com>2026-08-19 23:45:38 +0900
commitcd7c3fce2472656b2a1247429751e43350976677 (patch)
tree95e8760e3417fc3e63dac28bc0cd823a6af768f2 /crates/shirabe/src/autoload
parentb8fb046bd7c4cd28598bcce9f3955d834ea5d008 (diff)
downloadphp-shirabe-cd7c3fce2472656b2a1247429751e43350976677.tar.gz
php-shirabe-cd7c3fce2472656b2a1247429751e43350976677.tar.zst
php-shirabe-cd7c3fce2472656b2a1247429751e43350976677.zip
perf(package): hand out link maps behind Rc
PackageInterface::getRequires() and friends return the array of Link objects; in PHP that is a copy-on-write array of object references, so a caller pays nothing to look at it. The port returned IndexMap<String, Link> by value, so every call deep-cloned the whole map, keys and constraints included. Pool building calls these accessors once per package per candidate, which put IndexMap::clone at 13.5% of `require laravel/laravel`. Store the maps as Rc<IndexMap<String, Link>> and return a handle. Callers that mutate the map clone it explicitly at the point of mutation, matching where PHP would separate the array. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/autoload')
-rw-r--r--crates/shirabe/src/autoload/autoload_generator.rs13
1 files changed, 8 insertions, 5 deletions
diff --git a/crates/shirabe/src/autoload/autoload_generator.rs b/crates/shirabe/src/autoload/autoload_generator.rs
index 5f435566..55124467 100644
--- a/crates/shirabe/src/autoload/autoload_generator.rs
+++ b/crates/shirabe/src/autoload/autoload_generator.rs
@@ -1149,8 +1149,11 @@ return array(
for item in package_map {
let package = &item.0;
- let links = array_merge_map(package.get_replaces(), package.get_provides());
- for (_k, link) in &links {
+ let links = array_merge_map(
+ (*package.get_replaces()).clone(),
+ (*package.get_provides()).clone(),
+ );
+ for (_k, link) in links.iter() {
if let Some(matches) = preg_match(php_regex!("{^ext-(.+)$}iD"), link.get_target())
&& let Some(ext) = matches.get(1).map(str::to_string)
{
@@ -1169,7 +1172,7 @@ return array(
continue;
}
- for (_k, link) in &package.get_requires() {
+ for (_k, link) in package.get_requires().iter() {
if self
.platform_requirement_filter
.borrow()
@@ -2028,7 +2031,7 @@ class ComposerStaticInit{}
let package = &item.0;
let name = package.get_name();
packages.insert(name.clone(), package.clone());
- for (_k, replace) in &package.get_replaces() {
+ for (_k, replace) in package.get_replaces().iter() {
replaced_by.insert(replace.get_target().to_string(), name.clone());
}
}
@@ -2040,7 +2043,7 @@ class ComposerStaticInit{}
include: &mut IndexMap<String, bool>,
replaced_by: &IndexMap<String, String>,
) {
- for (_k, link) in &package.get_requires() {
+ for (_k, link) in package.get_requires().iter() {
let mut target = link.get_target().to_string();
if let Some(rep) = replaced_by.get(&target) {
target = rep.clone();