aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/archive_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-05-28 03:31:41 +0900
committernsfisis <nsfisis@gmail.com>2026-05-28 03:32:04 +0900
commitc7f53c5d7d581ebf76803650c63ec615b1558dc8 (patch)
treec6d83819e82a83cf93ca737b661094a8ea800cec /crates/shirabe/src/command/archive_command.rs
parentcc5d73c05a0abca2eebcc8a6afa0b1543ee49850 (diff)
downloadphp-shirabe-c7f53c5d7d581ebf76803650c63ec615b1558dc8.tar.gz
php-shirabe-c7f53c5d7d581ebf76803650c63ec615b1558dc8.tar.zst
php-shirabe-c7f53c5d7d581ebf76803650c63ec615b1558dc8.zip
refactor(composer): represent composer via trait-based handlesrefactor/composer-handles
Replace the PartialComposer/Composer structs and the single Rc<RefCell<PartialOrFullComposer>> enum with PartialComposer and Composer traits (Composer: PartialComposer), InnerPartialComposer / InnerFullComposer data structs, and the handle types FullComposerHandle (impl Composer) and AnyComposerHandle (polymorphic enum, impl PartialComposer), plus their weak variants. Factory builds the full and partial graphs via separate Rc::new_cyclic branches that share a build_composer_base helper. Call sites now use trait methods that encapsulate borrowing instead of borrow_partial() / composer_full*(). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/archive_command.rs')
-rw-r--r--crates/shirabe/src/command/archive_command.rs9
1 files changed, 4 insertions, 5 deletions
diff --git a/crates/shirabe/src/command/archive_command.rs b/crates/shirabe/src/command/archive_command.rs
index aab7b51..c777f54 100644
--- a/crates/shirabe/src/command/archive_command.rs
+++ b/crates/shirabe/src/command/archive_command.rs
@@ -8,7 +8,7 @@ use shirabe_external_packages::symfony::component::console::output::OutputInterf
use shirabe_php_shim::{LogicException, get_debug_type};
use crate::command::{BaseCommand, BaseCommandData, HasBaseCommandData};
-use crate::composer::PartialComposerHandle;
+use crate::composer::{AnyComposerHandle, Composer, PartialComposer};
use crate::config::Config;
use crate::console::input::InputArgument;
use crate::console::input::InputOption;
@@ -67,10 +67,10 @@ impl ArchiveCommand {
let composer = self.try_composer(None, None);
let config = if let Some(ref composer) = composer {
- let config = composer.borrow_partial().get_config();
+ let config = composer.get_config();
// TODO(plugin): dispatch CommandEvent
let command_event = CommandEvent::new(PluginEvents::COMMAND, "archive", input, output);
- let event_dispatcher = composer.borrow_partial().get_event_dispatcher();
+ let event_dispatcher = composer.get_event_dispatcher();
event_dispatcher
.borrow_mut()
.dispatch(Some(command_event.get_name()), None);
@@ -138,7 +138,6 @@ impl ArchiveCommand {
&& let Some(ref composer) = composer
{
composer
- .borrow_partial()
.get_event_dispatcher()
.borrow_mut()
.dispatch_script(
@@ -162,7 +161,7 @@ impl ArchiveCommand {
dest: &str,
file_name: Option<String>,
ignore_filters: bool,
- composer: Option<&PartialComposerHandle>,
+ composer: Option<&AnyComposerHandle>,
) -> Result<i64> {
let composer_guard = composer.map(crate::command::composer_full);
let owned_archive_manager;