diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-16 00:59:54 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-16 01:03:45 +0900 |
| commit | 3a388b98a9aa6a14b1c7f7dc909c109cf9837800 (patch) | |
| tree | 593e342313c6e6bd3ec2943a1690b8798e0a83ae /crates/shirabe/src/command/base_command.rs | |
| parent | aad468e8b75ffc3e87ea6dfa22c53a8299fc08da (diff) | |
| download | php-shirabe-3a388b98a9aa6a14b1c7f7dc909c109cf9837800.tar.gz php-shirabe-3a388b98a9aa6a14b1c7f7dc909c109cf9837800.tar.zst php-shirabe-3a388b98a9aa6a14b1c7f7dc909c109cf9837800.zip | |
refactor: narrow pub(crate) items to private
Porting mapped every PHP `protected` member onto `pub(crate)`, which is
wider than nearly all of them need. Each item demoted here is reached
only from the module that defines it, so the crate-wide visibility
conveyed nothing.
Every `pub(crate)` that survives has at least one reader in another
module of the same crate.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/base_command.rs')
| -rw-r--r-- | crates/shirabe/src/command/base_command.rs | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/crates/shirabe/src/command/base_command.rs b/crates/shirabe/src/command/base_command.rs index 9eb28dd8..d7f935c1 100644 --- a/crates/shirabe/src/command/base_command.rs +++ b/crates/shirabe/src/command/base_command.rs @@ -38,16 +38,16 @@ pub const INVALID: i64 = 2; #[derive(Debug)] pub struct BaseCommandData { inner: CommandData, - pub(crate) composer: std::cell::RefCell<Option<PartialComposerHandle>>, - pub(crate) io: std::cell::RefCell<Option<std::rc::Rc<std::cell::RefCell<dyn IOInterface>>>>, + composer: std::cell::RefCell<Option<PartialComposerHandle>>, + io: std::cell::RefCell<Option<std::rc::Rc<std::cell::RefCell<dyn IOInterface>>>>, /// The definition entries that were registered through the Composer-typed /// InputArgument/InputOption (which carry the suggested-values backport). PHP checks /// `$definition->getArgument($name) instanceof Composer\Console\Input\InputArgument`; in /// this port `set_definition` converts the entries to the Symfony types for storage, so /// the Composer-typedness is tracked by name in these side maps instead. - pub(crate) composer_arguments: + composer_arguments: std::cell::RefCell<IndexMap<String, std::rc::Rc<crate::console::input::InputArgument>>>, - pub(crate) composer_options: + composer_options: std::cell::RefCell<IndexMap<String, std::rc::Rc<crate::console::input::InputOption>>>, } @@ -65,7 +65,7 @@ impl BaseCommandData { /// Access to the embedded Symfony command state, used by the Composer-typed definition /// builders to forward to `CommandData`'s Symfony-typed entry points. `CommandData` is /// interior-mutable, so a shared reference is enough. - pub(crate) fn command_data(&self) -> &CommandData { + fn command_data(&self) -> &CommandData { &self.inner } } |
