diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-05-25 00:58:20 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-05-25 00:58:36 +0900 |
| commit | 1921f173ea219cb4b25847294d2d3fa465550fbb (patch) | |
| tree | 0d30486a2cb9a0c106e5d5827be3f655c60cd871 /crates/shirabe/src/command/licenses_command.rs | |
| parent | dbdecaf5a1c54a876b7ee0153d58dd39b1080f97 (diff) | |
| download | php-shirabe-1921f173ea219cb4b25847294d2d3fa465550fbb.tar.gz php-shirabe-1921f173ea219cb4b25847294d2d3fa465550fbb.tar.zst php-shirabe-1921f173ea219cb4b25847294d2d3fa465550fbb.zip | |
refactor(package): introduce Rc<RefCell<_>> handles for packages
PHP packages have reference semantics, so introduce shared-ownership
handles over an AnyPackage enum (PackageInterfaceHandle and friends)
and replace Box<dyn PackageInterface> throughout.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/licenses_command.rs')
| -rw-r--r-- | crates/shirabe/src/command/licenses_command.rs | 29 |
1 files changed, 13 insertions, 16 deletions
diff --git a/crates/shirabe/src/command/licenses_command.rs b/crates/shirabe/src/command/licenses_command.rs index 961f70b..2bcecd5 100644 --- a/crates/shirabe/src/command/licenses_command.rs +++ b/crates/shirabe/src/command/licenses_command.rs @@ -113,7 +113,11 @@ impl LicensesCommand { if input.get_option("no-dev").as_bool().unwrap_or(false) { RepositoryUtils::filter_required_packages( &repo.get_packages(), - composer.get_package(), + composer + .get_package() + .as_rc() + .borrow() + .as_package_interface(), false, vec![], ) @@ -123,11 +127,8 @@ impl LicensesCommand { }; let _ = composer.get_package(); - // TODO(phase-b): convert BasePackage trait objects to PackageInterface for sorting. - let pkg_pi: Vec<Box<dyn crate::package::PackageInterface>> = packages - .into_iter() - .map(|p| p.clone_package_box()) - .collect(); + let pkg_pi: Vec<crate::package::PackageInterfaceHandle> = + packages.into_iter().map(|p| p.into()).collect(); let packages = PackageSorter::sort_packages_alphabetically(pkg_pi); let io = self.get_io(); @@ -158,7 +159,9 @@ impl LicensesCommand { PhpMixed::String("Licenses".to_string()), ]); for package in &packages { - let link = PackageInfo::get_view_source_or_homepage_url(package.as_ref()); + let link = PackageInfo::get_view_source_or_homepage_url( + package.as_rc().borrow().as_package_interface(), + ); let name = if let Some(link) = link { format!( "<href={}>{}</>", @@ -168,9 +171,7 @@ impl LicensesCommand { } else { package.get_pretty_name().to_string() }; - let pkg_licenses = if let Some(complete_pkg) = - package.as_any().downcast_ref::<CompletePackage>() - { + let pkg_licenses = if let Some(complete_pkg) = package.as_complete_package() { complete_pkg.get_license() } else { vec![] @@ -199,9 +200,7 @@ impl LicensesCommand { let mut dependencies: IndexMap<String, IndexMap<String, PhpMixed>> = IndexMap::new(); for package in &packages { - let pkg_licenses = if let Some(complete_pkg) = - package.as_any().downcast_ref::<CompletePackage>() - { + let pkg_licenses = if let Some(complete_pkg) = package.as_complete_package() { complete_pkg.get_license() } else { vec![] @@ -268,9 +267,7 @@ impl LicensesCommand { "summary" => { let mut used_licenses: IndexMap<String, i64> = IndexMap::new(); for package in &packages { - let mut licenses = if let Some(complete_pkg) = - package.as_any().downcast_ref::<CompletePackage>() - { + let mut licenses = if let Some(complete_pkg) = package.as_complete_package() { complete_pkg.get_license() } else { vec![] |
