fix(fs): carry file_get_contents results as bytes

file_get_contents() and file_get_contents_with_max_length() return
Vec<u8> instead of a from_utf8_lossy'd String.
Call sites whose consumer takes a &str still convert lossily and are
marked TODO(bytes).

file_get_contents_with_max_length() now reads at most the requested
number of bytes instead of the whole file.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

1 files changed, 3 insertions, 1 deletions

diff --git a/crates/shirabe/src/command/package_discovery_trait.rs b/crates/shirabe/src/command/package_discovery_trait.rs
index 4a915fbe..4816e9d4 100644
--- a/crates/shirabe/src/command/package_discovery_trait.rs
+++ b/crates/shirabe/src/command/package_discovery_trait.rs
@@ -112,7 +112,9 @@ pub trait PackageDiscoveryTrait: BaseCommand {
         // @phpstan-ignore-next-line as RequireCommand does not have the option above so this code is reachable there
         let file = Factory::get_composer_file().unwrap_or_default();
         if is_file(&file) && Filesystem::is_readable(&file) {
-            let contents = file_get_contents(&file).unwrap_or_default();
+            // TODO(bytes): json_decode_assoc takes the JSON as a &str.
+            let contents =
+                String::from_utf8_lossy(&file_get_contents(&file).unwrap_or_default()).into_owned();
             let composer = json_decode_assoc(&contents).unwrap_or(PhpMixed::Null);
             if is_array(&composer)
                 && let Some(arr) = composer.as_array()