aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/repository_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-19 23:45:37 +0900
committernsfisis <nsfisis@gmail.com>2026-08-19 23:45:37 +0900
commit0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc (patch)
treeba5602549ce20b8d71136423e85dffc25deafff4 /crates/shirabe/src/command/repository_command.rs
parent6ed3a85dd636366d194c9810fd777db7f25e263f (diff)
downloadphp-shirabe-0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc.tar.gz
php-shirabe-0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc.tar.zst
php-shirabe-0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc.zip
fix(input): thread a typed InputValue through the input layer
Options and arguments were stored and passed as PhpMixed even though Symfony only ever puts a string, a bool, a list of strings or null in one. get_option already narrowed to InputOptionValue at the boundary; this widens that enum into InputValue and pushes it through InputInterface, InputOption/InputArgument defaults, the Input storage, ArgvInput/ArrayInput/StringInput/CompletionInput, Command::add_option and add_argument, and the Composer-side wrappers. Two neighbouring string|int unions get types of their own: InputDefinition::{get_argument,has_argument} take an ArgumentName, and ArrayInput keys its parameters by ParameterName. has_parameter_option and get_parameter_option take the values they look for as &[&str], which is what PHP's `(array) $values` cast produced anyway. Two behaviours change along the way. Input::set_option on a negated option now negates with PHP's loose bool cast rather than treating a non-bool as false, matching `!$value`. ArrayInput::parse now resolves an integer key to an argument position instead of looking up an argument literally named "0". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/repository_command.rs')
-rw-r--r--crates/shirabe/src/command/repository_command.rs11
1 files changed, 6 insertions, 5 deletions
diff --git a/crates/shirabe/src/command/repository_command.rs b/crates/shirabe/src/command/repository_command.rs
index 8f68b16b..4cf0c981 100644
--- a/crates/shirabe/src/command/repository_command.rs
+++ b/crates/shirabe/src/command/repository_command.rs
@@ -16,6 +16,7 @@ use shirabe_php_shim::{
};
use shirabe_symfony_console::command::Command;
use shirabe_symfony_console::input::InputInterface;
+use shirabe_symfony_console::input::InputValue;
use shirabe_symfony_console::output::OutputInterface;
#[derive(Debug)]
@@ -128,7 +129,7 @@ impl RepositoryCommand {
/// PHP: private function suggestTypeForAdd(): \Closure (a static closure — `this` unused)
fn suggest_type_for_add(&self) -> crate::console::input::SuggestedValues {
crate::console::input::SuggestedValues::Closure(Box::new(|_this, input, _suggestions| {
- if input.get_argument("action")?.to_string() == "add" {
+ if input.get_argument("action")?.to_php_string() == "add" {
return Ok(vec![
"composer".to_string(),
"vcs".to_string(),
@@ -143,7 +144,7 @@ impl RepositoryCommand {
fn suggest_repo_names(&self) -> crate::console::input::SuggestedValues {
crate::console::input::SuggestedValues::Closure(Box::new(|this, input, _suggestions| {
- let action = input.get_argument("action")?.to_string();
+ let action = input.get_argument("action")?.to_php_string();
if ["enable", "disable"].contains(&action.as_str()) {
return Ok(vec!["packagist.org".to_string()]);
}
@@ -202,7 +203,7 @@ impl Command for RepositoryCommand {
self.set_definition(&[
InputOption::new(
"global",
- Some(PhpMixed::String("g".to_string())),
+ Some("g"),
Some(InputOption::VALUE_NONE),
"Apply command to the global config file",
None,
@@ -211,7 +212,7 @@ impl Command for RepositoryCommand {
.into(),
InputOption::new(
"file",
- Some(PhpMixed::String("f".to_string())),
+ Some("f"),
Some(InputOption::VALUE_REQUIRED),
"If you want to choose a different composer.json or config.json",
None,
@@ -251,7 +252,7 @@ impl Command for RepositoryCommand {
"action",
Some(InputArgument::OPTIONAL),
"Action to perform: list, add, remove, set-url, get-url, enable, disable",
- Some(PhpMixed::String("list".to_string())),
+ Some(InputValue::String("list".to_string())),
crate::console::input::SuggestedValues::List(vec![
"list".to_string(),
"add".to_string(),