aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/require_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-05-29 03:42:14 +0900
committernsfisis <nsfisis@gmail.com>2026-05-29 03:42:14 +0900
commit86fcc80b348a3f00ab81e5447924aa10202d95e8 (patch)
tree0bdb4f7bd11aab799230a97500a380401a93b77e /crates/shirabe/src/command/require_command.rs
parent7f83e785a77fbdbcada9c6714703d4e5801af82a (diff)
downloadphp-shirabe-86fcc80b348a3f00ab81e5447924aa10202d95e8.tar.gz
php-shirabe-86fcc80b348a3f00ab81e5447924aa10202d95e8.tar.zst
php-shirabe-86fcc80b348a3f00ab81e5447924aa10202d95e8.zip
refactor(repository): introduce typed LockArrayRepositoryHandle
Share LockArrayRepository via Rc<RefCell<_>> while preserving the PHP ?LockArrayRepository type strength: Request.locked_repository, Locker ::get_locked_repository, and the installer create_* helpers now thread the typed handle instead of an owned LockArrayRepository, and pool builder identity check becomes a strict ptr_eq via widening into RepositoryInterfaceHandle. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/require_command.rs')
-rw-r--r--crates/shirabe/src/command/require_command.rs17
1 files changed, 8 insertions, 9 deletions
diff --git a/crates/shirabe/src/command/require_command.rs b/crates/shirabe/src/command/require_command.rs
index f59d60f..bb90361 100644
--- a/crates/shirabe/src/command/require_command.rs
+++ b/crates/shirabe/src/command/require_command.rs
@@ -933,18 +933,17 @@ impl RequireCommand {
),
None,
)?;
- // TODO(phase-b): get_locked_repository returns LockArrayRepository (owned) and
- // get_local_repository returns &dyn InstalledRepositoryInterface; need a common
- // interface for find_package.
- let locked_repo;
- let repo: &dyn RepositoryInterface = if locker_is_locked {
- locked_repo = composer
+ let repo: crate::repository::RepositoryInterfaceHandle = if locker_is_locked {
+ composer
.get_locker()
.borrow_mut()
- .get_locked_repository(true)?;
- &locked_repo
+ .get_locked_repository(true)?
+ .into()
} else {
- todo!("convert &dyn InstalledRepositoryInterface to &dyn RepositoryInterface")
+ composer
+ .get_repository_manager()
+ .borrow()
+ .get_local_repository()
};
for package_name in requirements_to_update {
let mut package = repo.find_package(