aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/status_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-05-25 00:58:20 +0900
committernsfisis <nsfisis@gmail.com>2026-05-25 00:58:36 +0900
commit1921f173ea219cb4b25847294d2d3fa465550fbb (patch)
tree0d30486a2cb9a0c106e5d5827be3f655c60cd871 /crates/shirabe/src/command/status_command.rs
parentdbdecaf5a1c54a876b7ee0153d58dd39b1080f97 (diff)
downloadphp-shirabe-1921f173ea219cb4b25847294d2d3fa465550fbb.tar.gz
php-shirabe-1921f173ea219cb4b25847294d2d3fa465550fbb.tar.zst
php-shirabe-1921f173ea219cb4b25847294d2d3fa465550fbb.zip
refactor(package): introduce Rc<RefCell<_>> handles for packages
PHP packages have reference semantics, so introduce shared-ownership handles over an AnyPackage enum (PackageInterfaceHandle and friends) and replace Box<dyn PackageInterface> throughout. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/status_command.rs')
-rw-r--r--crates/shirabe/src/command/status_command.rs38
1 files changed, 23 insertions, 15 deletions
diff --git a/crates/shirabe/src/command/status_command.rs b/crates/shirabe/src/command/status_command.rs
index 190884a..69c36a1 100644
--- a/crates/shirabe/src/command/status_command.rs
+++ b/crates/shirabe/src/command/status_command.rs
@@ -120,18 +120,19 @@ impl StatusCommand {
let target_dir = composer
.get_installation_manager()
.borrow_mut()
- .get_install_path(package.as_ref());
+ .get_install_path(package.as_rc().borrow().as_package_interface());
let target_dir = match target_dir {
Some(d) => d,
None => continue,
};
// TODO(phase-b): downloader borrow lifetime tied to dm.borrow() temporary; restructure later.
let dm_borrow = dm.borrow();
- let downloader: &dyn crate::downloader::DownloaderInterface =
- match dm_borrow.get_downloader_for_package(package.as_ref())? {
- Some(d) => d,
- None => continue,
- };
+ let downloader: &dyn crate::downloader::DownloaderInterface = match dm_borrow
+ .get_downloader_for_package(package.as_rc().borrow().as_package_interface())?
+ {
+ Some(d) => d,
+ None => continue,
+ };
// TODO(phase-b): isinstance checks using ChangeReportInterface/VcsCapableDownloaderInterface/DvcsDownloaderInterface
if let Some(change_reporter) = downloader.as_change_report_interface() {
@@ -142,16 +143,20 @@ impl StatusCommand {
);
}
- if let Some(changes) =
- change_reporter.get_local_changes(package.as_ref(), &target_dir)?
- {
+ if let Some(changes) = change_reporter.get_local_changes(
+ package.as_rc().borrow().as_package_interface(),
+ &target_dir,
+ )? {
errors.insert(target_dir.clone(), changes);
}
}
if let Some(vcs_downloader) = downloader.as_vcs_capable_downloader_interface() {
if vcs_downloader
- .get_vcs_reference(package.as_ref(), target_dir.clone())
+ .get_vcs_reference(
+ package.as_rc().borrow().as_package_interface(),
+ target_dir.clone(),
+ )
.is_some()
{
let previous_ref = match package.get_installation_source().as_deref() {
@@ -160,8 +165,10 @@ impl StatusCommand {
_ => None,
};
- let current_version =
- guesser.guess_version(&dumper.dump(package.as_ref()), &target_dir)?;
+ let current_version = guesser.guess_version(
+ &dumper.dump(package.as_rc().borrow().as_package_interface()),
+ &target_dir,
+ )?;
if let (Some(prev_ref), Some(cur_version)) = (&previous_ref, &current_version) {
if cur_version.commit.as_deref() != Some(prev_ref.as_str())
@@ -195,9 +202,10 @@ impl StatusCommand {
}
if let Some(dvcs_downloader) = downloader.as_dvcs_downloader_interface() {
- if let Some(unpushed) =
- dvcs_downloader.get_unpushed_changes(package.as_ref(), target_dir.clone())
- {
+ if let Some(unpushed) = dvcs_downloader.get_unpushed_changes(
+ package.as_rc().borrow().as_package_interface(),
+ target_dir.clone(),
+ ) {
unpushed_changes.insert(target_dir, unpushed);
}
}