diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-10 09:03:07 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-10 09:03:07 +0900 |
| commit | 3f80f3c725245c769f05b6d3317f086e226fae50 (patch) | |
| tree | 0cd55641393ac6f519f87a2f4ada83661f1f9b5c /crates/shirabe/src/command/suggests_command.rs | |
| parent | 6066087795efe76357f929bc1148deb1835cbbae (diff) | |
| download | php-shirabe-3f80f3c725245c769f05b6d3317f086e226fae50.tar.gz php-shirabe-3f80f3c725245c769f05b6d3317f086e226fae50.tar.zst php-shirabe-3f80f3c725245c769f05b6d3317f086e226fae50.zip | |
refactor(symfony-process): drop the --enable-sigchild workarounds
isSigchildEnabled() detects a PHP built with --enable-sigchild, where PHP
reaps children itself and proc_get_status()/proc_terminate() stop reporting
or reaching them. Shirabe spawns child processes from Rust, so that build
option cannot affect them and every sigchild branch was unreachable.
Removing the branches retires the state that existed only to feed them:
fallbackStatus (written by the fourth pipe and by doSignal, read only by
the sigchild merge in updateStatus) and useFileHandles (whose sole reader
was the sigchild condition). shirabe-php-shim loses phpinfo(),
INFO_GENERAL and posix_kill(), which had no other callers.
DiagnoseCommand keeps its --enable-sigchild warning: it reports on the
user's PHP installation, not on how Shirabe runs processes.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/suggests_command.rs')
0 files changed, 0 insertions, 0 deletions