aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-12 01:20:25 +0900
committernsfisis <nsfisis@gmail.com>2026-08-12 01:20:25 +0900
commit0779bfe8c7b5ee22034d552477cac54e8ae2895f (patch)
tree91b341422c48982b5a7b0d8d7e8efe8b25b9248e /crates/shirabe/src/command
parent561924db750cbb4e4c183f9616472ed9a5b0fc7f (diff)
downloadphp-shirabe-0779bfe8c7b5ee22034d552477cac54e8ae2895f.tar.gz
php-shirabe-0779bfe8c7b5ee22034d552477cac54e8ae2895f.tar.zst
php-shirabe-0779bfe8c7b5ee22034d552477cac54e8ae2895f.zip
fix(command): port ScriptAliasCommand's ignoreValidationErrors() call
The command's own definition covers only --dev/--no-dev and the args array, so any other application-level option reaching it (as when GlobalCommand re-parses `--no-interaction=1` out of ArrayInput's stringification) aborted the run with "does not accept a value". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command')
-rw-r--r--crates/shirabe/src/command/script_alias_command.rs7
1 files changed, 1 insertions, 6 deletions
diff --git a/crates/shirabe/src/command/script_alias_command.rs b/crates/shirabe/src/command/script_alias_command.rs
index b10e1671..30d82779 100644
--- a/crates/shirabe/src/command/script_alias_command.rs
+++ b/crates/shirabe/src/command/script_alias_command.rs
@@ -44,18 +44,13 @@ impl ScriptAliasCommand {
}
}
- // PHP also calls parent::__construct() (Symfony Command base) and
- // $this->ignoreValidationErrors().
- // TODO(symfony): both are Symfony Command base-class operations — the constructor sets up
- // the command's name/definition/application state and ignoreValidationErrors() flips a flag
- // on it. Composer's BaseCommand carries no such Symfony Command state yet (the Symfony
- // Command base is an intentional todo!() stub), so there is nothing to initialize here.
let command = Self {
base_command_data: BaseCommandData::new(None),
script,
description,
aliases,
};
+ command.ignore_validation_errors();
command
.configure()
.expect("ScriptAliasCommand::configure uses constructor-provided metadata");