aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-09 11:24:48 +0900
committernsfisis <nsfisis@gmail.com>2026-08-09 11:24:48 +0900
commit596482de82ff32705e85f18c1c9ae784e6cd2c6f (patch)
tree6a970fa30f7770d702d3f6c53232c123d0478d16 /crates/shirabe/src/command
parent738a258496318edb6e264b13b8a6d0dc313795d3 (diff)
downloadphp-shirabe-596482de82ff32705e85f18c1c9ae784e6cd2c6f.tar.gz
php-shirabe-596482de82ff32705e85f18c1c9ae784e6cd2c6f.tar.zst
php-shirabe-596482de82ff32705e85f18c1c9ae784e6cd2c6f.zip
refactor(xdebug-handler): extract composer/xdebug_handler into the shirabe-xdebug-handler crate
Move `Composer\XdebugHandler` out of shirabe-external-packages and into its own crate, so the path is `shirabe_xdebug_handler::XdebugHandler` instead of `shirabe_external_packages::composer::xdebug_handler::XdebugHandler`. Standing alone, the stub no longer sits in a crate that shirabe-php-rpc depends on, so drop the dependency-cycle rationale from the comments that explain why callers reach for shirabe_php_rpc directly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command')
-rw-r--r--crates/shirabe/src/command/diagnose_command.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/crates/shirabe/src/command/diagnose_command.rs b/crates/shirabe/src/command/diagnose_command.rs
index eade37fc..2af2acfc 100644
--- a/crates/shirabe/src/command/diagnose_command.rs
+++ b/crates/shirabe/src/command/diagnose_command.rs
@@ -888,8 +888,8 @@ impl DiagnoseCommand {
warnings.insert("xdebug_profile".to_string(), PhpMixed::Bool(true));
} else if diagnostics.xdebug_active {
// PHP: XdebugHandler::isXdebugActive(). As with IniHelper::get_all, the port of that
- // method in shirabe_external_packages cannot reach the PHP RPC bridge (the dependency
- // would cycle), so the real runtime is queried through the diagnose payload instead.
+ // method in shirabe_xdebug_handler is a stub, so the real runtime is queried through
+ // the diagnose payload instead.
warnings.insert("xdebug_loaded".to_string(), PhpMixed::Bool(true));
}