aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/console/application.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-16 00:59:54 +0900
committernsfisis <nsfisis@gmail.com>2026-08-16 01:03:45 +0900
commit3a388b98a9aa6a14b1c7f7dc909c109cf9837800 (patch)
tree593e342313c6e6bd3ec2943a1690b8798e0a83ae /crates/shirabe/src/console/application.rs
parentaad468e8b75ffc3e87ea6dfa22c53a8299fc08da (diff)
downloadphp-shirabe-3a388b98a9aa6a14b1c7f7dc909c109cf9837800.tar.gz
php-shirabe-3a388b98a9aa6a14b1c7f7dc909c109cf9837800.tar.zst
php-shirabe-3a388b98a9aa6a14b1c7f7dc909c109cf9837800.zip
refactor: narrow pub(crate) items to private
Porting mapped every PHP `protected` member onto `pub(crate)`, which is wider than nearly all of them need. Each item demoted here is reached only from the module that defines it, so the crate-wide visibility conveyed nothing. Every `pub(crate)` that survives has at least one reader in another module of the same crate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/console/application.rs')
-rw-r--r--crates/shirabe/src/console/application.rs12
1 files changed, 5 insertions, 7 deletions
diff --git a/crates/shirabe/src/console/application.rs b/crates/shirabe/src/console/application.rs
index 9a17868c..fb89f8b0 100644
--- a/crates/shirabe/src/console/application.rs
+++ b/crates/shirabe/src/console/application.rs
@@ -119,8 +119,8 @@ pub struct Application {
default_command: String,
single_command: bool,
// $initialized is omitted. See ApplicationHandle::init().
- pub(crate) composer: Option<PartialComposerHandle>,
- pub(crate) io: std::rc::Rc<std::cell::RefCell<dyn IOInterface>>,
+ composer: Option<PartialComposerHandle>,
+ io: std::rc::Rc<std::cell::RefCell<dyn IOInterface>>,
has_plugin_commands: bool,
/// Whether this application published the worker-side console application handoff. The
/// handoff is process-wide, so a second application in the same process must replace it
@@ -443,9 +443,7 @@ impl Application {
}
/// Initializes all the composer commands.
- pub(crate) fn get_default_commands(
- &self,
- ) -> Vec<std::rc::Rc<std::cell::RefCell<dyn SymfonyCommand>>> {
+ fn get_default_commands(&self) -> Vec<std::rc::Rc<std::cell::RefCell<dyn SymfonyCommand>>> {
let mut commands = self.base_get_default_commands();
let composer_commands: Vec<std::rc::Rc<std::cell::RefCell<dyn SymfonyCommand>>> = vec![
std::rc::Rc::new(std::cell::RefCell::new(AboutCommand::new())),
@@ -525,7 +523,7 @@ impl Application {
)
}
- pub(crate) fn get_default_input_definition(&self) -> anyhow::Result<InputDefinition> {
+ fn get_default_input_definition(&self) -> anyhow::Result<InputDefinition> {
let mut definition = self.base_get_default_input_definition();
definition.add_option(InputOption::new(
"--profile",
@@ -3089,7 +3087,7 @@ thread_local! {
}
/// Registers the application the worker's reverse command stubs call back into.
-pub(crate) fn register_worker_reverse_application(
+fn register_worker_reverse_application(
application: std::rc::Weak<std::cell::RefCell<Application>>,
) {
WORKER_REVERSE_APPLICATION.with(|slot| *slot.borrow_mut() = Some(application));