refactor(pcre): inline Preg into its call sites and drop the crate

Preg had shed everything it owned: after the last few rounds its methods
were one-line forwards to the shim's preg_*(), differing only in a
default argument or a wrapper the caller unwrapped anyway. The 460 call
sites now name the shim function, and shirabe-pcre is gone from the
workspace along with its LICENSE entry.

The forwards expand as they read: isMatch becomes
preg_match2(.., 0).is_some() (is_none() where PHP negates it), isMatch3
and match3 drop the .is_some(), matchAll counts through
preg_match_all2(..).occurrence_count(), and replace4/replace5 spell out
the limit and count arguments preg_replace2 takes. Callbacks are the one
place the shapes differ: preg_replace_callback carries an error out of
the callback, so the fourteen infallible closures wrap their result in
Ok() and expect() it back.

Config::process() is the fifteenth, and it drops the `error` cell it
captured to smuggle a failure past a closure that could only return a
String. The `?` in the closure now carries it, which is what the PHP
does -- a throw from the callback leaves preg_replace_callback at the
failing match rather than running the remaining replacements and
reporting the last error.

The module doc that explained why composer/pcre's exceptions and
*StrictGroups() variants have no counterpart moves to the shim's preg
module, where the functions it describes live.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

1 files changed, 9 insertions, 12 deletions

diff --git a/crates/shirabe/src/dependency_resolver/lock_transaction.rs b/crates/shirabe/src/dependency_resolver/lock_transaction.rs
index a238f2d6..df9a737d 100644
--- a/crates/shirabe/src/dependency_resolver/lock_transaction.rs
+++ b/crates/shirabe/src/dependency_resolver/lock_transaction.rs
@@ -5,8 +5,7 @@ use crate::dependency_resolver::Pool;
 use crate::dependency_resolver::Transaction;
 use crate::package::PackageInterfaceHandle;
 use indexmap::IndexMap;
-use shirabe_pcre::Preg;
-use shirabe_php_shim::php_regex;
+use shirabe_php_shim::{PregMatches, php_regex, preg_match2, preg_replace_callback};
 
 #[derive(Debug)]
 pub struct LockTransaction {
@@ -159,12 +158,9 @@ impl LockTransaction {
 
             if package.get_dist_url().is_some()
                 && present_package.get_dist_reference().is_some()
-                && Preg::is_match(
-                    php_regex!(
-                        r"{^https?://(?:(?:www\.)?bitbucket\.org|(api\.)?github\.com|(?:www\.)?gitlab\.com)/}i"
-                    ),
-                    &package.get_dist_url().unwrap(),
-                )
+                && preg_match2(php_regex!(
+                    r"{^https?://(?:(?:www\.)?bitbucket\.org|(api\.)?github\.com|(?:www\.)?gitlab\.com)/}i"
+                ), &package.get_dist_url().unwrap(), 0).is_some()
             {
                 // Regex pattern compatibility:
                 // The `regex` crate has no look-around, so `(?<=/|sha=)[a-f0-9]{40}(?=/|$)` is
@@ -174,14 +170,15 @@ impl LockTransaction {
                 // 40-hex SHAs sharing a single `/` between them would not both match; harmless
                 // here since a dist URL never carries more than one SHA reference.
                 let dist_reference = present_package.get_dist_reference().unwrap();
-                let new_dist_url = Preg::replace_callback(
+                let new_dist_url = preg_replace_callback(
                     php_regex!(r"{(/|sha=)[a-f0-9]{40}(/|$)}i"),
-                    |m: &shirabe_pcre::PregMatches| -> String {
+                    |m: &PregMatches| -> anyhow::Result<String> {
                         let get = |i: usize| -> String { m.get(i).unwrap_or_default().to_string() };
-                        format!("{}{}{}", get(1), dist_reference, get(2))
+                        Ok(format!("{}{}{}", get(1), dist_reference, get(2)))
                     },
                     &package.get_dist_url().unwrap(),
-                );
+                )
+                .expect("the replacement callback cannot fail");
                 present_package.set_dist_url(Some(new_dist_url));
             }
             present_package.set_dist_mirrors(package.get_dist_mirrors());