aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/downloader/svn_downloader.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-08 22:14:12 +0900
committernsfisis <nsfisis@gmail.com>2026-08-08 22:14:12 +0900
commitf4cad2123b2af0de72bda4ce039e16e74f163f4e (patch)
tree21803308c5ff41e23c9d3b117433eea16b4ff663 /crates/shirabe/src/downloader/svn_downloader.rs
parent0209f63210e5b547b5c6b73367bb80ea86c255ec (diff)
downloadphp-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.tar.gz
php-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.tar.zst
php-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.zip
feat(php-shim): give ported exceptions PHP's class hierarchy
Ported exceptions were flat structs reached with `downcast_ref`, so Composer's `catch (\RuntimeException $e)` only matched the exact leaf type and `get_class($e)` had nothing to report. Each exception now embeds an instance of the class it extends and travels inside an `AnyThrowable`; `Catch::catch`/`catch_mut` walk that chain, and `PhpClass::php_class_name` yields the PHP FQCN. Dropping the `std::error::Error` impls from the exception types leaves `AnyThrowable` as the only route into an `anyhow::Error`, so the walk cannot be bypassed. A `no_exception_downcast` linter catches the `downcast::<X>()` calls that would now silently answer `None`. Three sites change behavior as a result: the `TransportException` exit-code override reaches `MaxFileSizeExceededException`, the `catch (\LogicException)` in findSimilar() reaches its subclasses, and rendered exception titles carry the real class name rather than a guess. `get_class_err()` is no longer a `todo!()`, which re-enables FilesystemRepositoryTest::testCorruptedRepositoryFile. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/downloader/svn_downloader.rs')
-rw-r--r--crates/shirabe/src/downloader/svn_downloader.rs73
1 files changed, 30 insertions, 43 deletions
diff --git a/crates/shirabe/src/downloader/svn_downloader.rs b/crates/shirabe/src/downloader/svn_downloader.rs
index 6a8bdf0e..cb748a93 100644
--- a/crates/shirabe/src/downloader/svn_downloader.rs
+++ b/crates/shirabe/src/downloader/svn_downloader.rs
@@ -75,13 +75,10 @@ impl SvnDownloader {
Some(path),
) != 0
{
- return Err(RuntimeException {
- message: format!(
- "Could not reset changes\n\n:{}",
- self.inner.process.borrow().get_error_output()
- ),
- code: 0,
- }
+ return Err(RuntimeException::new(format!(
+ "Could not reset changes\n\n:{}",
+ self.inner.process.borrow().get_error_output()
+ ))
.into());
}
@@ -96,10 +93,10 @@ impl SvnDownloader {
path: &str,
) -> anyhow::Result<()> {
if self.get_local_changes(package, path)?.is_some() {
- return Err(RuntimeException {
- message: format!("Source directory {} has uncommitted changes.", path),
- code: 0,
- }
+ return Err(RuntimeException::new(format!(
+ "Source directory {} has uncommitted changes.",
+ path
+ ))
.into());
}
@@ -143,10 +140,9 @@ impl VcsDownloader for SvnDownloader {
Some(self.inner.process.clone()),
);
if util.binary_version().is_none() {
- return Err(RuntimeException {
- message: "svn was not found in your PATH, skipping source download".to_string(),
- code: 0,
- }
+ return Err(RuntimeException::new(
+ "svn was not found in your PATH, skipping source download".to_string(),
+ )
.into());
}
@@ -206,13 +202,10 @@ impl VcsDownloader for SvnDownloader {
let r#ref = target.get_source_reference();
if !self.has_metadata_repository(path) {
- return Err(RuntimeException {
- message: format!(
- "The .svn directory is missing from {}, see https://getcomposer.org/commit-deps for more information",
- path
- ),
- code: 0,
- }
+ return Err(RuntimeException::new(format!(
+ "The .svn directory is missing from {}, see https://getcomposer.org/commit-deps for more information",
+ path
+ ))
.into());
}
@@ -324,11 +317,7 @@ impl VcsDownloader for SvnDownloader {
break;
}
Some("n") => {
- return Err(RuntimeException {
- message: "Update aborted".to_string(),
- code: 0,
- }
- .into());
+ return Err(RuntimeException::new("Update aborted".to_string()).into());
}
Some("v") => {
for line in &changes {
@@ -384,14 +373,11 @@ impl VcsDownloader for SvnDownloader {
.execute_args(&command, &mut output, Some(path))
!= 0
{
- return Err(RuntimeException {
- message: format!(
- "Failed to execute {}\n\n{}",
- command.join(" "),
- self.inner.process.borrow().get_error_output()
- ),
- code: 0,
- }
+ return Err(RuntimeException::new(format!(
+ "Failed to execute {}\n\n{}",
+ command.join(" "),
+ self.inner.process.borrow().get_error_output()
+ ))
.into());
}
@@ -403,10 +389,10 @@ impl VcsDownloader for SvnDownloader {
.cloned()
.unwrap_or_default()
} else {
- return Err(RuntimeException {
- message: format!("Unable to determine svn url for path {}", path),
- code: 0,
- }
+ return Err(RuntimeException::new(format!(
+ "Unable to determine svn url for path {}",
+ path
+ ))
.into());
};
@@ -431,10 +417,11 @@ impl VcsDownloader for SvnDownloader {
util.set_cache_credentials(self.cache_credentials.get());
util.execute_local(command.clone(), path, None, self.inner.io.is_verbose())
.map_err(|e| {
- RuntimeException {
- message: format!("Failed to execute {}\n\n{}", command.join(" "), e),
- code: 0,
- }
+ RuntimeException::new(format!(
+ "Failed to execute {}\n\n{}",
+ command.join(" "),
+ e
+ ))
.into()
})
} else {