aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/event_dispatcher
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-11 23:28:40 +0900
committernsfisis <nsfisis@gmail.com>2026-08-11 23:28:40 +0900
commit38621c67917fd015f884ea04517791cdc5058c6d (patch)
tree03f466e2db22a3bc45e20e4f9694eb371a59b0e1 /crates/shirabe/src/event_dispatcher
parent73ab00d3108933c952844b3820f44230c8203807 (diff)
downloadphp-shirabe-38621c67917fd015f884ea04517791cdc5058c6d.tar.gz
php-shirabe-38621c67917fd015f884ea04517791cdc5058c6d.tar.zst
php-shirabe-38621c67917fd015f884ea04517791cdc5058c6d.zip
chore(php-shim): drop the substring predicate ports
str_contains(), str_starts_with() and str_ends_with() were thin wrappers over the str methods of the same semantics. Call sites now use contains()/starts_with()/ends_with() directly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/event_dispatcher')
-rw-r--r--crates/shirabe/src/event_dispatcher/event_dispatcher.rs17
1 files changed, 7 insertions, 10 deletions
diff --git a/crates/shirabe/src/event_dispatcher/event_dispatcher.rs b/crates/shirabe/src/event_dispatcher/event_dispatcher.rs
index ca6c2adc..d9ec9306 100644
--- a/crates/shirabe/src/event_dispatcher/event_dispatcher.rs
+++ b/crates/shirabe/src/event_dispatcher/event_dispatcher.rs
@@ -32,8 +32,7 @@ use shirabe_php_shim::{
array_search_in_vec, array_splice, file_exists, get_class, hash, implode, ini_get, is_array,
is_callable, is_object, is_string, krsort, php_regex, preg_quote, realpath,
spl_autoload_functions, spl_autoload_register, spl_autoload_unregister, spl_object_hash,
- str_contains, str_ends_with, str_replace, str_starts_with, strlen, strpos, strtoupper, substr,
- trim,
+ str_replace, strlen, strpos, strtoupper, substr, trim,
};
use shirabe_symfony_console::output::output_interface;
use shirabe_symfony_process::ExecutableFinder;
@@ -371,7 +370,7 @@ impl EventDispatcher {
let mut additional_args = event.get_arguments().clone();
let mut callable = callable;
if let Callable::String(ref s) = callable
- && str_contains(s, "@no_additional_args")
+ && s.contains("@no_additional_args")
{
let replaced = Preg::replace(php_regex!("{ ?@no_additional_args}"), "", s);
callable = Callable::String(replaced);
@@ -880,7 +879,7 @@ try {{
// @putenv does not receive arguments
let mut exec = if strpos(&callable_str, "@putenv ") == Some(0) {
callable_str.clone()
- } else if str_contains(&callable_str, "@additional_args") {
+ } else if callable_str.contains("@additional_args") {
str_replace("@additional_args", &args, &callable_str)
} else {
format!(
@@ -1358,16 +1357,14 @@ try {{
/// Checks if string given references a command class
fn is_command_class(&self, callable: &str) -> bool {
- str_contains(callable, "\\")
- && !str_contains(callable, " ")
- && str_ends_with(callable, "Command")
+ callable.contains("\\") && !callable.contains(" ") && callable.ends_with("Command")
}
/// Checks if string given references a composer run-script
fn is_composer_script(&self, callable: &str) -> bool {
- str_starts_with(callable, "@")
- && !str_starts_with(callable, "@php ")
- && !str_starts_with(callable, "@putenv ")
+ callable.starts_with("@")
+ && !callable.starts_with("@php ")
+ && !callable.starts_with("@putenv ")
}
/// Push an event to the stack of active event