aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/installer/binary_installer.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-16 00:59:54 +0900
committernsfisis <nsfisis@gmail.com>2026-08-16 01:03:45 +0900
commit3a388b98a9aa6a14b1c7f7dc909c109cf9837800 (patch)
tree593e342313c6e6bd3ec2943a1690b8798e0a83ae /crates/shirabe/src/installer/binary_installer.rs
parentaad468e8b75ffc3e87ea6dfa22c53a8299fc08da (diff)
downloadphp-shirabe-3a388b98a9aa6a14b1c7f7dc909c109cf9837800.tar.gz
php-shirabe-3a388b98a9aa6a14b1c7f7dc909c109cf9837800.tar.zst
php-shirabe-3a388b98a9aa6a14b1c7f7dc909c109cf9837800.zip
refactor: narrow pub(crate) items to private
Porting mapped every PHP `protected` member onto `pub(crate)`, which is wider than nearly all of them need. Each item demoted here is reached only from the module that defines it, so the crate-wide visibility conveyed nothing. Every `pub(crate)` that survives has at least one reader in another module of the same crate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/installer/binary_installer.rs')
-rw-r--r--crates/shirabe/src/installer/binary_installer.rs20
1 files changed, 10 insertions, 10 deletions
diff --git a/crates/shirabe/src/installer/binary_installer.rs b/crates/shirabe/src/installer/binary_installer.rs
index 8cd4fe5a..32e4c071 100644
--- a/crates/shirabe/src/installer/binary_installer.rs
+++ b/crates/shirabe/src/installer/binary_installer.rs
@@ -47,10 +47,10 @@ impl BinaryInstallerInterface for BinaryInstaller {
/// Utility to handle installation of package "bin"/binaries
#[derive(Debug)]
pub struct BinaryInstaller {
- pub(crate) bin_dir: String,
- pub(crate) bin_compat: String,
- pub(crate) io: std::rc::Rc<std::cell::RefCell<dyn IOInterface>>,
- pub(crate) filesystem: std::rc::Rc<std::cell::RefCell<Filesystem>>,
+ bin_dir: String,
+ bin_compat: String,
+ io: std::rc::Rc<std::cell::RefCell<dyn IOInterface>>,
+ filesystem: std::rc::Rc<std::cell::RefCell<Filesystem>>,
vendor_dir: Option<String>,
}
@@ -219,11 +219,11 @@ impl BinaryInstaller {
"php".to_string()
}
- pub(crate) fn get_binaries(&self, package: PackageInterfaceHandle) -> Vec<String> {
+ fn get_binaries(&self, package: PackageInterfaceHandle) -> Vec<String> {
package.get_binaries()
}
- pub(crate) fn install_full_binaries(
+ fn install_full_binaries(
&mut self,
bin_path: &str,
link: &str,
@@ -258,7 +258,7 @@ impl BinaryInstaller {
}
}
- pub(crate) fn install_unixy_proxy_binaries(&self, bin_path: &str, link: &str) {
+ fn install_unixy_proxy_binaries(&self, bin_path: &str, link: &str) {
let code = self.generate_unixy_proxy_code(bin_path, link);
file_put_contents(link, code.as_bytes());
let link_owned = link.to_string();
@@ -268,14 +268,14 @@ impl BinaryInstaller {
});
}
- pub(crate) fn initialize_bin_dir(&mut self) {
+ fn initialize_bin_dir(&mut self) {
self.filesystem
.borrow_mut()
.ensure_directory_exists(&self.bin_dir);
self.bin_dir = realpath(&self.bin_dir).unwrap_or_default();
}
- pub(crate) fn generate_windows_proxy_code(&self, bin: &str, link: &str) -> String {
+ fn generate_windows_proxy_code(&self, bin: &str, link: &str) -> String {
let bin_path = self
.filesystem
.borrow_mut()
@@ -311,7 +311,7 @@ impl BinaryInstaller {
)
}
- pub(crate) fn generate_unixy_proxy_code(&self, bin: &str, link: &str) -> String {
+ fn generate_unixy_proxy_code(&self, bin: &str, link: &str) -> String {
let bin_path = self
.filesystem
.borrow_mut()