refactor(silencer): stop guarding work that stays inside Rust

Silencer only lowers the PHP error_reporting() level and re-throws
whatever the guarded work raises. A region that never reaches the PHP
runtime has no level to lower and emits no diagnostic on failure, so
wrapping it is indistinguishable from running it unguarded.

The pair kept in Application::hint_common_errors brackets a
getComposer() call, which loads installed plugins and dispatches
PluginEvents::INIT.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1 files changed, 2 insertions, 7 deletions

diff --git a/crates/shirabe/src/json/json_file.rs b/crates/shirabe/src/json/json_file.rs
index 703b9fbb..eafe27e7 100644
--- a/crates/shirabe/src/json/json_file.rs
+++ b/crates/shirabe/src/json/json_file.rs
@@ -7,7 +7,6 @@ use crate::io::io_interface;
 use crate::json::JsonValidationException;
 use crate::util::Filesystem;
 use crate::util::HttpDownloader;
-use crate::util::Silencer;
 use shirabe_php_shim::Catch as _;
 use shirabe_php_shim::{
     InvalidArgumentException, JSON_PRETTY_PRINT, JSON_UNESCAPED_SLASHES, JSON_UNESCAPED_UNICODE,
@@ -239,8 +238,7 @@ impl JsonFile {
                 ))
                 .into());
             }
-            // PHP: @mkdir($dir, 0777, true)
-            if !Silencer::call(|| Ok(mkdir(&dir, 0o777, true).is_ok())).unwrap_or(false) {
+            if mkdir(&dir, 0o777, true).is_err() {
                 return Err(UnexpectedValueException::new(format!(
                     "{} does not exist and could not be created.",
                     dir
@@ -285,10 +283,7 @@ impl JsonFile {
         path: &str,
         content: &str,
     ) -> anyhow::Result<Option<i64>> {
-        // PHP: @file_get_contents($path)
-        let current_content = Silencer::call(|| Ok(file_get_contents(path).ok()))
-            .ok()
-            .flatten();
+        let current_content = file_get_contents(path).ok();
         if current_content.is_none() || current_content.as_deref() != Some(content.as_bytes()) {
             return Ok(file_put_contents(path, content.as_bytes()));
         }