diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-10 02:59:50 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-10 03:05:26 +0900 |
| commit | 264feb1093d587e5df457fac023852a0e578b22f (patch) | |
| tree | fc23db88f628bd421c2a9819ebbdb96b05ed99de /crates/shirabe/src/package/archiver | |
| parent | 54760d5c73ca20de2e155df274d576cec9ea0ed0 (diff) | |
| download | php-shirabe-264feb1093d587e5df457fac023852a0e578b22f.tar.gz php-shirabe-264feb1093d587e5df457fac023852a0e578b22f.tar.zst php-shirabe-264feb1093d587e5df457fac023852a0e578b22f.zip | |
fix(php-shim): return an error from fileperms instead of 0
fileperms swallowed metadata errors and reported a mode of 0, which the
callers could not tell apart from a real (if implausible) mode: the zip
archiver stored entries with no permission bits, and Filesystem::copy
chmod-ed the target to 0. It now returns Result<u32, io::Error> so both
callers propagate the failure. The switch to u32 also drops the casts
around the mode arithmetic and ZipArchive's entry attributes.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/package/archiver')
| -rw-r--r-- | crates/shirabe/src/package/archiver/zip_archiver.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crates/shirabe/src/package/archiver/zip_archiver.rs b/crates/shirabe/src/package/archiver/zip_archiver.rs index 5604c07d..2ef9473e 100644 --- a/crates/shirabe/src/package/archiver/zip_archiver.rs +++ b/crates/shirabe/src/package/archiver/zip_archiver.rs @@ -70,7 +70,7 @@ impl ArchiverInterface for ZipArchiver { } // Ensure to preserve the permission umasks for the filepath in the archive. - let perms = fileperms(&filepath); + let perms = fileperms(&filepath)?; if filepath.is_dir() { zip.add_empty_dir( |