diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-19 23:45:38 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-19 23:45:38 +0900 |
| commit | cd7c3fce2472656b2a1247429751e43350976677 (patch) | |
| tree | 95e8760e3417fc3e63dac28bc0cd823a6af768f2 /crates/shirabe/src/package/handle.rs | |
| parent | b8fb046bd7c4cd28598bcce9f3955d834ea5d008 (diff) | |
| download | php-shirabe-cd7c3fce2472656b2a1247429751e43350976677.tar.gz php-shirabe-cd7c3fce2472656b2a1247429751e43350976677.tar.zst php-shirabe-cd7c3fce2472656b2a1247429751e43350976677.zip | |
perf(package): hand out link maps behind Rc
PackageInterface::getRequires() and friends return the array of Link objects;
in PHP that is a copy-on-write array of object references, so a caller pays
nothing to look at it. The port returned IndexMap<String, Link> by value, so
every call deep-cloned the whole map, keys and constraints included. Pool
building calls these accessors once per package per candidate, which put
IndexMap::clone at 13.5% of `require laravel/laravel`.
Store the maps as Rc<IndexMap<String, Link>> and return a handle. Callers that
mutate the map clone it explicitly at the point of mutation, matching where PHP
would separate the array.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/package/handle.rs')
| -rw-r--r-- | crates/shirabe/src/package/handle.rs | 42 |
1 files changed, 31 insertions, 11 deletions
diff --git a/crates/shirabe/src/package/handle.rs b/crates/shirabe/src/package/handle.rs index 45d46f49..fd7272de 100644 --- a/crates/shirabe/src/package/handle.rs +++ b/crates/shirabe/src/package/handle.rs @@ -322,19 +322,29 @@ macro_rules! delegate_package_interface_to_inner { fn get_stability(&self) -> &str { self.$field.get_stability() } - fn get_requires(&self) -> indexmap::IndexMap<String, crate::package::Link> { + fn get_requires( + &self, + ) -> std::rc::Rc<indexmap::IndexMap<String, crate::package::Link>> { self.$field.get_requires() } - fn get_conflicts(&self) -> indexmap::IndexMap<String, crate::package::Link> { + fn get_conflicts( + &self, + ) -> std::rc::Rc<indexmap::IndexMap<String, crate::package::Link>> { self.$field.get_conflicts() } - fn get_provides(&self) -> indexmap::IndexMap<String, crate::package::Link> { + fn get_provides( + &self, + ) -> std::rc::Rc<indexmap::IndexMap<String, crate::package::Link>> { self.$field.get_provides() } - fn get_replaces(&self) -> indexmap::IndexMap<String, crate::package::Link> { + fn get_replaces( + &self, + ) -> std::rc::Rc<indexmap::IndexMap<String, crate::package::Link>> { self.$field.get_replaces() } - fn get_dev_requires(&self) -> indexmap::IndexMap<String, crate::package::Link> { + fn get_dev_requires( + &self, + ) -> std::rc::Rc<indexmap::IndexMap<String, crate::package::Link>> { self.$field.get_dev_requires() } fn get_suggests(&self) -> indexmap::IndexMap<String, String> { @@ -585,23 +595,33 @@ macro_rules! impl_package_interface_handle { .to_string() } - pub fn get_requires(&self) -> indexmap::IndexMap<String, crate::package::Link> { + pub fn get_requires( + &self, + ) -> std::rc::Rc<indexmap::IndexMap<String, crate::package::Link>> { self.0.borrow().as_package_interface().get_requires() } - pub fn get_conflicts(&self) -> indexmap::IndexMap<String, crate::package::Link> { + pub fn get_conflicts( + &self, + ) -> std::rc::Rc<indexmap::IndexMap<String, crate::package::Link>> { self.0.borrow().as_package_interface().get_conflicts() } - pub fn get_provides(&self) -> indexmap::IndexMap<String, crate::package::Link> { + pub fn get_provides( + &self, + ) -> std::rc::Rc<indexmap::IndexMap<String, crate::package::Link>> { self.0.borrow().as_package_interface().get_provides() } - pub fn get_replaces(&self) -> indexmap::IndexMap<String, crate::package::Link> { + pub fn get_replaces( + &self, + ) -> std::rc::Rc<indexmap::IndexMap<String, crate::package::Link>> { self.0.borrow().as_package_interface().get_replaces() } - pub fn get_dev_requires(&self) -> indexmap::IndexMap<String, crate::package::Link> { + pub fn get_dev_requires( + &self, + ) -> std::rc::Rc<indexmap::IndexMap<String, crate::package::Link>> { self.0.borrow().as_package_interface().get_dev_requires() } @@ -612,7 +632,7 @@ macro_rules! impl_package_interface_handle { pub fn get_links_for_type( &self, link_type: &str, - ) -> indexmap::IndexMap<String, crate::package::Link> { + ) -> std::rc::Rc<indexmap::IndexMap<String, crate::package::Link>> { self.0 .borrow() .as_package_interface() |
