aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/package/loader/root_package_loader.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-08 22:14:12 +0900
committernsfisis <nsfisis@gmail.com>2026-08-08 22:14:12 +0900
commitf4cad2123b2af0de72bda4ce039e16e74f163f4e (patch)
tree21803308c5ff41e23c9d3b117433eea16b4ff663 /crates/shirabe/src/package/loader/root_package_loader.rs
parent0209f63210e5b547b5c6b73367bb80ea86c255ec (diff)
downloadphp-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.tar.gz
php-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.tar.zst
php-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.zip
feat(php-shim): give ported exceptions PHP's class hierarchy
Ported exceptions were flat structs reached with `downcast_ref`, so Composer's `catch (\RuntimeException $e)` only matched the exact leaf type and `get_class($e)` had nothing to report. Each exception now embeds an instance of the class it extends and travels inside an `AnyThrowable`; `Catch::catch`/`catch_mut` walk that chain, and `PhpClass::php_class_name` yields the PHP FQCN. Dropping the `std::error::Error` impls from the exception types leaves `AnyThrowable` as the only route into an `anyhow::Error`, so the walk cannot be bypassed. A `no_exception_downcast` linter catches the `downcast::<X>()` calls that would now silently answer `None`. Three sites change behavior as a result: the `TransportException` exit-code override reaches `MaxFileSizeExceededException`, the `catch (\LogicException)` in findSimilar() reaches its subclasses, and rendered exception titles carry the real class name rather than a guess. `get_class_err()` is no longer a `todo!()`, which re-enables FilesystemRepositoryTest::testCorruptedRepositoryFile. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/package/loader/root_package_loader.rs')
-rw-r--r--crates/shirabe/src/package/loader/root_package_loader.rs30
1 files changed, 9 insertions, 21 deletions
diff --git a/crates/shirabe/src/package/loader/root_package_loader.rs b/crates/shirabe/src/package/loader/root_package_loader.rs
index 284bb175..e26a7e95 100644
--- a/crates/shirabe/src/package/loader/root_package_loader.rs
+++ b/crates/shirabe/src/package/loader/root_package_loader.rs
@@ -78,10 +78,7 @@ impl RootPackageLoader {
config["name"].as_string().unwrap_or(""),
false,
) {
- return Err(anyhow::anyhow!(RuntimeException {
- message: format!("Your package name {}", err),
- code: 0,
- }));
+ return Err(RuntimeException::new(format!("Your package name {}", err)).into());
}
let mut auto_versioned = false;
@@ -197,13 +194,10 @@ impl RootPackageLoader {
let package_name = config["name"].as_string().unwrap_or("").to_string();
if links.contains_key(&package_name) {
- return Err(anyhow::anyhow!(RuntimeException {
- message: format!(
- "Root package '{}' cannot require itself in its composer.json\nDid you accidentally name your root package after an external package?",
- package_name
- ),
- code: 0,
- }));
+ return Err(RuntimeException::new(format!(
+ "Root package '{}' cannot require itself in its composer.json\nDid you accidentally name your root package after an external package?",
+ package_name
+ )).into());
}
}
}
@@ -216,10 +210,7 @@ impl RootPackageLoader {
if let Some(err) =
ValidatingArrayLoader::has_package_naming_error(link_name, true)
{
- return Err(anyhow::anyhow!(RuntimeException {
- message: format!("{}.{}", link_type, err),
- code: 0,
- }));
+ return Err(RuntimeException::new(format!("{}.{}", link_type, err)).into());
}
}
}
@@ -291,14 +282,11 @@ impl RootPackageLoader {
return {
panic!(
"{}",
- UnexpectedValueException {
- message: format!(
+ UnexpectedValueException::new(format!(
"Invalid alias definition in \"{}\": \"{}\". Aliases should be in the form \"exact-version as other-exact-version\".",
req_name, req_version
- ),
- code: 0,
- }
- .message
+ ))
+ .get_message()
)
};
}