aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/plugin/capability/capability.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-17 07:36:34 +0900
committernsfisis <nsfisis@gmail.com>2026-08-17 07:36:34 +0900
commit9fd6aecad27240ccedab4487f6c157914142ca47 (patch)
tree3819360771b9eb9298315e26604cafabeae84e04 /crates/shirabe/src/plugin/capability/capability.rs
parent6b4ce98f20b3cfc14f1c955565a8acd9abcc16a2 (diff)
downloadphp-shirabe-9fd6aecad27240ccedab4487f6c157914142ca47.tar.gz
php-shirabe-9fd6aecad27240ccedab4487f6c157914142ca47.tar.zst
php-shirabe-9fd6aecad27240ccedab4487f6c157914142ca47.zip
refactor(preg): return the preg_* $matches instead of filling an out-param
PHP fills `$matches` through a by-ref parameter, which the port mirrored with a `&mut` out-param plus a bool or count return. Every caller then had to declare an empty binding one line ahead of the call, and nothing in the type said the binding is only meaningful when the call succeeded. Return the matches instead: preg_match() and preg_match2() hand back an Option, and the three preg_match_all* functions hand back the collection they used to fill. The occurrence count the two map-shaped preg_match_all* functions used to return is the length of any one of the map's columns, so it is not lost -- Preg::match_all() and friends derive it via occurrence_count(). preg_replace2() keeps its `count: Option<&mut usize>`: that one is not derivable from the replaced string, and callers that do not want it pay nothing for passing None. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/plugin/capability/capability.rs')
0 files changed, 0 insertions, 0 deletions