aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/question
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-18 01:57:02 +0900
committernsfisis <nsfisis@gmail.com>2026-08-18 01:57:02 +0900
commitfed0a6e7ac361af9b963c1f62411b1a85478230c (patch)
tree5cde64a24845c761890fbcbe05e0d702f1ec8df7 /crates/shirabe/src/question
parente093b2be1c333e67c96aebb0a5291bea9ae3d6db (diff)
downloadphp-shirabe-fed0a6e7ac361af9b963c1f62411b1a85478230c.tar.gz
php-shirabe-fed0a6e7ac361af9b963c1f62411b1a85478230c.tar.zst
php-shirabe-fed0a6e7ac361af9b963c1f62411b1a85478230c.zip
refactor(preg): add preg_is_match for existence-only call sites
The capture groups were discarded at 162 of the preg_match call sites, which only tested the Option. They now call preg_is_match, which lets the regex engine skip capture tracking. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/question')
-rw-r--r--crates/shirabe/src/question/strict_confirmation_question.rs6
1 files changed, 3 insertions, 3 deletions
diff --git a/crates/shirabe/src/question/strict_confirmation_question.rs b/crates/shirabe/src/question/strict_confirmation_question.rs
index dbc39574..a0c1d92f 100644
--- a/crates/shirabe/src/question/strict_confirmation_question.rs
+++ b/crates/shirabe/src/question/strict_confirmation_question.rs
@@ -1,6 +1,6 @@
//! ref: composer/src/Composer/Question/StrictConfirmationQuestion.php
-use shirabe_php_shim::{PhpMixed, empty, is_bool, preg_match};
+use shirabe_php_shim::{PhpMixed, empty, is_bool, preg_is_match};
use shirabe_symfony_console::exception::InvalidArgumentException;
use shirabe_symfony_console::question::Question;
use shirabe_symfony_console::question::QuestionInterface;
@@ -53,10 +53,10 @@ impl StrictConfirmationQuestion {
return default.clone();
}
if let PhpMixed::String(s) = &answer {
- if preg_match(&true_regex, s).is_some() {
+ if preg_is_match(&true_regex, s) {
return PhpMixed::Bool(true);
}
- if preg_match(&false_regex, s).is_some() {
+ if preg_is_match(&false_regex, s) {
return PhpMixed::Bool(false);
}
}