aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/repository/installed_repository.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-19 23:45:38 +0900
committernsfisis <nsfisis@gmail.com>2026-08-19 23:45:38 +0900
commitcd7c3fce2472656b2a1247429751e43350976677 (patch)
tree95e8760e3417fc3e63dac28bc0cd823a6af768f2 /crates/shirabe/src/repository/installed_repository.rs
parentb8fb046bd7c4cd28598bcce9f3955d834ea5d008 (diff)
downloadphp-shirabe-cd7c3fce2472656b2a1247429751e43350976677.tar.gz
php-shirabe-cd7c3fce2472656b2a1247429751e43350976677.tar.zst
php-shirabe-cd7c3fce2472656b2a1247429751e43350976677.zip
perf(package): hand out link maps behind Rc
PackageInterface::getRequires() and friends return the array of Link objects; in PHP that is a copy-on-write array of object references, so a caller pays nothing to look at it. The port returned IndexMap<String, Link> by value, so every call deep-cloned the whole map, keys and constraints included. Pool building calls these accessors once per package per candidate, which put IndexMap::clone at 13.5% of `require laravel/laravel`. Store the maps as Rc<IndexMap<String, Link>> and return a handle. Callers that mutate the map clone it explicitly at the point of mutation, matching where PHP would separate the array. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/repository/installed_repository.rs')
-rw-r--r--crates/shirabe/src/repository/installed_repository.rs29
1 files changed, 17 insertions, 12 deletions
diff --git a/crates/shirabe/src/repository/installed_repository.rs b/crates/shirabe/src/repository/installed_repository.rs
index 36ad510c..097fca84 100644
--- a/crates/shirabe/src/repository/installed_repository.rs
+++ b/crates/shirabe/src/repository/installed_repository.rs
@@ -84,8 +84,10 @@ impl InstalledRepository {
continue;
}
- let provides_and_replaces =
- array_merge_map(candidate.get_provides(), candidate.get_replaces());
+ let provides_and_replaces = array_merge_map(
+ (*candidate.get_provides()).clone(),
+ (*candidate.get_replaces()).clone(),
+ );
for link in provides_and_replaces.values() {
if name == link.get_target()
&& (constraint.is_none()
@@ -126,12 +128,12 @@ impl InstalledRepository {
}
for package in self.inner.get_packages()? {
- let mut links: IndexMap<String, Link> = package.get_requires();
+ let mut links: IndexMap<String, Link> = (*package.get_requires()).clone();
let mut packages_in_tree = packages_found.clone();
if !invert {
- for (k, v) in package.get_replaces() {
- links.entry(k).or_insert(v);
+ for (k, v) in package.get_replaces().iter() {
+ links.entry(k.clone()).or_insert(v.clone());
}
let needles_snapshot = needles.clone();
@@ -169,8 +171,8 @@ impl InstalledRepository {
}
if package.as_root().is_some() {
- for (k, v) in package.get_dev_requires() {
- links.entry(k).or_insert(v);
+ for (k, v) in package.get_dev_requires().iter() {
+ links.entry(k.clone()).or_insert(v.clone());
}
}
@@ -297,8 +299,10 @@ impl InstalledRepository {
.into();
if link.get_target() != pkg.get_name().as_str() {
- let replaces_and_provides =
- array_merge_map(pkg.get_replaces(), pkg.get_provides());
+ let replaces_and_provides = array_merge_map(
+ (*pkg.get_replaces()).clone(),
+ (*pkg.get_provides()).clone(),
+ );
for prov in replaces_and_provides.values() {
if link.get_target() == prov.get_target() {
version = prov.get_constraint().clone();
@@ -309,9 +313,10 @@ impl InstalledRepository {
if !link.get_constraint().matches(&version) {
if let Some(root_pkg) = root_package.as_ref() {
- let mut root_reqs: IndexMap<String, Link> = root_pkg.get_requires();
- for (k, v) in root_pkg.get_dev_requires() {
- root_reqs.entry(k).or_insert(v);
+ let mut root_reqs: IndexMap<String, Link> =
+ (*root_pkg.get_requires()).clone();
+ for (k, v) in root_pkg.get_dev_requires().iter() {
+ root_reqs.entry(k.clone()).or_insert(v.clone());
}
for root_req in root_reqs.values() {
if pkg