refactor(pcre): hand back the match instead of copying it out

Preg::match4 and Preg::replace_callback gave callers a
PregMatchedGroups: an IndexMap rebuilt from the match with an owned
String per group, plus a second String for a named group's name key.
That is the copy PregMatches shed when it started wrapping
regex::Captures, reinstated one layer up -- and nearly every regex call
in the tree goes through Preg rather than the shim's preg_* directly, so
almost nothing saw the borrow.

PregMatchedGroups existed only to drop the null (unmatched) groups the
old PregMatches held as Option<String> values. PregMatches::get reports
a non-participating group as None on its own, so the two read alike and
the type collapses into it. Call sites still reach groups through
get(&CaptureKey::ByIndex(N)); what changes is that the value arrives as
a &str borrowed from the subject, which the signatures now carry as a
lifetime.

Three places needed the borrow reckoned with rather than a mechanical
rewrite: PhpFileCleaner::clean and Problem::get_messages read their
groups out before mutating what the match borrows, and
Git::get_authentication_failure names the lifetime of its url argument,
which the result borrows instead of self.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

7 files changed, 99 insertions, 49 deletions

diff --git a/crates/shirabe/src/repository/vcs/forgejo_driver.rs b/crates/shirabe/src/repository/vcs/forgejo_driver.rs
index 9e156418..8aa72a6c 100644
--- a/crates/shirabe/src/repository/vcs/forgejo_driver.rs
+++ b/crates/shirabe/src/repository/vcs/forgejo_driver.rs
@@ -587,7 +587,7 @@ impl ForgejoDriver {
             if let Some(m) = Preg::match3(php_regex!(r#"{<(.+?)>; *rel="next"}"#), &link)
                 && let Some(url) = m.get(&CaptureKey::ByIndex(1))
             {
-                return Some(url.clone());
+                return Some(url.to_string());
             }
         }
 
diff --git a/crates/shirabe/src/repository/vcs/git_bitbucket_driver.rs b/crates/shirabe/src/repository/vcs/git_bitbucket_driver.rs
index cf1f5f98..e053cadf 100644
--- a/crates/shirabe/src/repository/vcs/git_bitbucket_driver.rs
+++ b/crates/shirabe/src/repository/vcs/git_bitbucket_driver.rs
@@ -95,8 +95,14 @@ impl GitBitbucketDriver {
             .into());
         };
 
-        self.owner = m.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default();
-        self.repository = m.get(&CaptureKey::ByIndex(2)).cloned().unwrap_or_default();
+        self.owner = m
+            .get(&CaptureKey::ByIndex(1))
+            .unwrap_or_default()
+            .to_string();
+        self.repository = m
+            .get(&CaptureKey::ByIndex(2))
+            .unwrap_or_default()
+            .to_string();
         self.inner.origin_url = "bitbucket.org".to_string();
         self.inner.cache = Some(Cache::new(
             self.inner.io.clone(),
diff --git a/crates/shirabe/src/repository/vcs/git_driver.rs b/crates/shirabe/src/repository/vcs/git_driver.rs
index 99275e98..bd56766b 100644
--- a/crates/shirabe/src/repository/vcs/git_driver.rs
+++ b/crates/shirabe/src/repository/vcs/git_driver.rs
@@ -202,7 +202,7 @@ impl GitDriver {
                         && let Some(caps) = Preg::match3(php_regex!(r"{^\* +(\S+)}"), branch)
                         && let Some(name) = caps.get(&CaptureKey::ByIndex(1))
                     {
-                        self.root_identifier = Some(name.clone());
+                        self.root_identifier = Some(name.to_string());
                         break;
                     }
                 }
@@ -321,7 +321,7 @@ impl GitDriver {
                     self.tags
                         .as_mut()
                         .unwrap()
-                        .insert(name.clone(), hash.clone());
+                        .insert(name.to_string(), hash.to_string());
                 }
             }
         }
@@ -358,7 +358,7 @@ impl GitDriver {
                     )
                     && !name.starts_with('-')
                 {
-                    branches.insert(name.clone(), hash.clone());
+                    branches.insert(name.to_string(), hash.to_string());
                 }
             }
 
diff --git a/crates/shirabe/src/repository/vcs/github_driver.rs b/crates/shirabe/src/repository/vcs/github_driver.rs
index 7cbceaf2..08561171 100644
--- a/crates/shirabe/src/repository/vcs/github_driver.rs
+++ b/crates/shirabe/src/repository/vcs/github_driver.rs
@@ -85,22 +85,22 @@ impl GitHubDriver {
 
         self.owner = match_
             .get(&CaptureKey::ByIndex(3))
-            .cloned()
-            .unwrap_or_default();
+            .unwrap_or_default()
+            .to_string();
         self.repository = match_
             .get(&CaptureKey::ByIndex(4))
-            .cloned()
-            .unwrap_or_default();
+            .unwrap_or_default()
+            .to_string();
         self.inner.origin_url = strtolower(
             &match_
                 .get(&CaptureKey::ByIndex(1))
-                .cloned()
                 .filter(|s| !s.is_empty())
+                .map(str::to_string)
                 .unwrap_or_else(|| {
                     match_
                         .get(&CaptureKey::ByIndex(2))
-                        .cloned()
                         .unwrap_or_default()
+                        .to_string()
                 }),
         );
         if self.inner.origin_url == "www.github.com" {
@@ -494,14 +494,23 @@ impl GitHubDriver {
         for line in preg_split(php_regex!(r"{\r?\n}"), &funding) {
             let line = trim(&line, None);
             if let Some(m) = Preg::is_match3(php_regex!(r"{^(\w+)\s*:\s*(.+)$}"), &line) {
-                let g1 = m.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default();
-                let g2 = m.get(&CaptureKey::ByIndex(2)).cloned().unwrap_or_default();
+                let g1 = m
+                    .get(&CaptureKey::ByIndex(1))
+                    .unwrap_or_default()
+                    .to_string();
+                let g2 = m
+                    .get(&CaptureKey::ByIndex(2))
+                    .unwrap_or_default()
+                    .to_string();
                 if g2 == "[" {
                     key = Some(g1);
                     continue;
                 }
                 if let Some(m2) = Preg::is_match3(php_regex!(r"{^\[(.*?)\](?:\s*#.*)?$}"), &g2) {
-                    let inner = m2.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default();
+                    let inner = m2
+                        .get(&CaptureKey::ByIndex(1))
+                        .unwrap_or_default()
+                        .to_string();
                     for item in array_map(
                         |s: &String| trim(s, None),
                         &preg_split(php_regex!(r#"{[\'\"]?\s*,\s*[\'\"]?}"#), &inner),
@@ -522,7 +531,7 @@ impl GitHubDriver {
                     entry.insert(
                         "url".to_string(),
                         PhpMixed::String(trim(
-                            &m2.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default(),
+                            m2.get(&CaptureKey::ByIndex(1)).unwrap_or_default(),
                             Some("\"' "),
                         )),
                     );
@@ -530,7 +539,11 @@ impl GitHubDriver {
                 }
                 key = None;
             } else if let Some(m) = Preg::is_match3(php_regex!(r"{^(\w+)\s*:\s*#\s*$}"), &line) {
-                key = Some(m.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default());
+                key = Some(
+                    m.get(&CaptureKey::ByIndex(1))
+                        .unwrap_or_default()
+                        .to_string(),
+                );
             } else if key.is_some()
                 && let Some(m) = Preg::is_match3(php_regex!(r"{^-\s*(.+)(?:\s+#.*)?$}"), &line)
                     .or_else(|| Preg::is_match3(php_regex!(r"{^(.+),(?:\s*#.*)?$}"), &line))
@@ -543,7 +556,7 @@ impl GitHubDriver {
                 entry.insert(
                     "url".to_string(),
                     PhpMixed::String(trim(
-                        &m.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default(),
+                        m.get(&CaptureKey::ByIndex(1)).unwrap_or_default(),
                         Some("\"' "),
                     )),
                 );
@@ -936,13 +949,13 @@ impl GitHubDriver {
 
         let origin_url = matches
             .get(&CaptureKey::ByIndex(2))
-            .cloned()
             .filter(|s| !s.is_empty())
+            .map(str::to_string)
             .unwrap_or_else(|| {
                 matches
                     .get(&CaptureKey::ByIndex(3))
-                    .cloned()
                     .unwrap_or_default()
+                    .to_string()
             });
         if !in_array_loose(
             strtolower(&Preg::replace(php_regex!(r"{^www\.}i"), "", &origin_url)),
@@ -1272,7 +1285,11 @@ impl GitHubDriver {
         let links = explode(",", &header);
         for link in &links {
             if let Some(m) = Preg::is_match3(php_regex!(r#"{<(.+?)>; *rel="next"}"#), link) {
-                return Some(m.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default());
+                return Some(
+                    m.get(&CaptureKey::ByIndex(1))
+                        .unwrap_or_default()
+                        .to_string(),
+                );
             }
         }
 
diff --git a/crates/shirabe/src/repository/vcs/gitlab_driver.rs b/crates/shirabe/src/repository/vcs/gitlab_driver.rs
index 1887ddc4..5494feed 100644
--- a/crates/shirabe/src/repository/vcs/gitlab_driver.rs
+++ b/crates/shirabe/src/repository/vcs/gitlab_driver.rs
@@ -91,27 +91,26 @@ impl GitLabDriver {
 
         let guessed_domain = match_
             .get(&CaptureKey::ByName("domain".to_string()))
-            .cloned()
             .filter(|s| !s.is_empty())
+            .map(str::to_string)
             .unwrap_or_else(|| {
                 match_
                     .get(&CaptureKey::ByName("domain2".to_string()))
-                    .cloned()
                     .unwrap_or_default()
+                    .to_string()
             });
         let configured_domains = self.inner.config.borrow_mut().get("gitlab-domains");
         let mut url_parts: Vec<String> = explode(
             "/",
-            &match_
+            match_
                 .get(&CaptureKey::ByName("parts".to_string()))
-                .cloned()
                 .unwrap_or_default(),
         );
 
         let scheme_match = match_
             .get(&CaptureKey::ByName("scheme".to_string()))
-            .cloned()
-            .unwrap_or_default();
+            .unwrap_or_default()
+            .to_string();
         self.scheme = if matches!(scheme_match.as_str(), "https" | "http") {
             scheme_match
         } else if self
@@ -125,7 +124,9 @@ impl GitLabDriver {
         } else {
             "https".to_string()
         };
-        let port = match_.get(&CaptureKey::ByName("port".to_string())).cloned();
+        let port = match_
+            .get(&CaptureKey::ByName("port".to_string()))
+            .map(str::to_string);
         let origin =
             Self::determine_origin(&configured_domains, guessed_domain, &mut url_parts, port);
         let origin = match origin {
@@ -169,9 +170,8 @@ impl GitLabDriver {
         self.repository = Preg::replace(
             php_regex!(r"#(\.git)$#"),
             "",
-            &match_
+            match_
                 .get(&CaptureKey::ByName("repo".to_string()))
-                .cloned()
                 .unwrap_or_default(),
         );
 
@@ -950,23 +950,22 @@ impl GitLabDriver {
 
         let scheme = match_
             .get(&CaptureKey::ByName("scheme".to_string()))
-            .cloned()
-            .unwrap_or_default();
+            .unwrap_or_default()
+            .to_string();
         let guessed_domain = match_
             .get(&CaptureKey::ByName("domain".to_string()))
-            .cloned()
             .filter(|s| !s.is_empty())
+            .map(str::to_string)
             .unwrap_or_else(|| {
                 match_
                     .get(&CaptureKey::ByName("domain2".to_string()))
-                    .cloned()
                     .unwrap_or_default()
+                    .to_string()
             });
         let mut url_parts: Vec<String> = explode(
             "/",
-            &match_
+            match_
                 .get(&CaptureKey::ByName("parts".to_string()))
-                .cloned()
                 .unwrap_or_default(),
         );
 
@@ -974,7 +973,9 @@ impl GitLabDriver {
             &config.borrow().get("gitlab-domains"),
             guessed_domain,
             &mut url_parts,
-            match_.get(&CaptureKey::ByName("port".to_string())).cloned(),
+            match_
+                .get(&CaptureKey::ByName("port".to_string()))
+                .map(str::to_string),
         )
         .is_none()
         {
@@ -1013,8 +1014,8 @@ impl GitLabDriver {
                 return Some(
                     match_
                         .get(&CaptureKey::ByIndex(1))
-                        .cloned()
-                        .unwrap_or_default(),
+                        .unwrap_or_default()
+                        .to_string(),
                 );
             }
         }
diff --git a/crates/shirabe/src/repository/vcs/hg_driver.rs b/crates/shirabe/src/repository/vcs/hg_driver.rs
index 0933a643..aae9c7cb 100644
--- a/crates/shirabe/src/repository/vcs/hg_driver.rs
+++ b/crates/shirabe/src/repository/vcs/hg_driver.rs
@@ -236,8 +236,12 @@ impl HgDriver {
                     && let Some(m) = Preg::match3(php_regex!(r"(^([^\s]+)\s+\d+:(.*)$)"), &tag)
                 {
                     tags.insert(
-                        m.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default(),
-                        m.get(&CaptureKey::ByIndex(2)).cloned().unwrap_or_default(),
+                        m.get(&CaptureKey::ByIndex(1))
+                            .unwrap_or_default()
+                            .to_string(),
+                        m.get(&CaptureKey::ByIndex(2))
+                            .unwrap_or_default()
+                            .to_string(),
                     );
                 }
             }
@@ -265,11 +269,16 @@ impl HgDriver {
                     && let Some(m) =
                         Preg::match3(php_regex!(r"(^([^\s]+)\s+\d+:([a-f0-9]+))"), &branch)
                 {
-                    let name = m.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default();
+                    let name = m
+                        .get(&CaptureKey::ByIndex(1))
+                        .unwrap_or_default()
+                        .to_string();
                     if !name.starts_with('-') {
                         branches.insert(
                             name,
-                            m.get(&CaptureKey::ByIndex(2)).cloned().unwrap_or_default(),
+                            m.get(&CaptureKey::ByIndex(2))
+                                .unwrap_or_default()
+                                .to_string(),
                         );
                     }
                 }
@@ -286,11 +295,16 @@ impl HgDriver {
                     && let Some(m) =
                         Preg::match3(php_regex!(r"(^(?:[\s*]*)([^\s]+)\s+\d+:(.*)$)"), &branch)
                 {
-                    let name = m.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default();
+                    let name = m
+                        .get(&CaptureKey::ByIndex(1))
+                        .unwrap_or_default()
+                        .to_string();
                     if !name.starts_with('-') {
                         bookmarks.insert(
                             name,
-                            m.get(&CaptureKey::ByIndex(2)).cloned().unwrap_or_default(),
+                            m.get(&CaptureKey::ByIndex(2))
+                                .unwrap_or_default()
+                                .to_string(),
                         );
                     }
                 }
diff --git a/crates/shirabe/src/repository/vcs/svn_driver.rs b/crates/shirabe/src/repository/vcs/svn_driver.rs
index 05380a17..9426e1f3 100644
--- a/crates/shirabe/src/repository/vcs/svn_driver.rs
+++ b/crates/shirabe/src/repository/vcs/svn_driver.rs
@@ -321,7 +321,10 @@ impl SvnDriver {
                 && let Some(m) =
                     Preg::is_match3(php_regex!(r"{^Last Changed Date: ([^(]+)}"), &line)
             {
-                let date_str = m.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default();
+                let date_str = m
+                    .get(&CaptureKey::ByIndex(1))
+                    .unwrap_or_default()
+                    .to_string();
                 return Ok(shirabe_php_shim::date_create::<Utc>(date_str.trim())
                     .ok()
                     .map(|d| d.fixed_offset()));
@@ -353,7 +356,10 @@ impl SvnDriver {
                                 .get(&CaptureKey::ByIndex(1))
                                 .and_then(|s| s.parse().ok())
                                 .unwrap_or(0);
-                            let path = m.get(&CaptureKey::ByIndex(2)).cloned().unwrap_or_default();
+                            let path = m
+                                .get(&CaptureKey::ByIndex(2))
+                                .unwrap_or_default()
+                                .to_string();
                             if path == "./" {
                                 last_rev = rev;
                             } else {
@@ -399,7 +405,10 @@ impl SvnDriver {
                             .get(&CaptureKey::ByIndex(1))
                             .and_then(|s| s.parse().ok())
                             .unwrap_or(0);
-                        let path = m.get(&CaptureKey::ByIndex(2)).cloned().unwrap_or_default();
+                        let path = m
+                            .get(&CaptureKey::ByIndex(2))
+                            .unwrap_or_default()
+                            .to_string();
                         if path == "./" {
                             let identifier = self.build_identifier(
                                 &format!("/{}", self.trunk_path.clone().unwrap_or_default()),
@@ -437,7 +446,10 @@ impl SvnDriver {
                                 .get(&CaptureKey::ByIndex(1))
                                 .and_then(|s| s.parse().ok())
                                 .unwrap_or(0);
-                            let path = m.get(&CaptureKey::ByIndex(2)).cloned().unwrap_or_default();
+                            let path = m
+                                .get(&CaptureKey::ByIndex(2))
+                                .unwrap_or_default()
+                                .to_string();
                             if path == "./" {
                                 last_rev = rev;
                             } else {