aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/repository/vcs_repository.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-08 22:14:12 +0900
committernsfisis <nsfisis@gmail.com>2026-08-08 22:14:12 +0900
commitf4cad2123b2af0de72bda4ce039e16e74f163f4e (patch)
tree21803308c5ff41e23c9d3b117433eea16b4ff663 /crates/shirabe/src/repository/vcs_repository.rs
parent0209f63210e5b547b5c6b73367bb80ea86c255ec (diff)
downloadphp-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.tar.gz
php-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.tar.zst
php-shirabe-f4cad2123b2af0de72bda4ce039e16e74f163f4e.zip
feat(php-shim): give ported exceptions PHP's class hierarchy
Ported exceptions were flat structs reached with `downcast_ref`, so Composer's `catch (\RuntimeException $e)` only matched the exact leaf type and `get_class($e)` had nothing to report. Each exception now embeds an instance of the class it extends and travels inside an `AnyThrowable`; `Catch::catch`/`catch_mut` walk that chain, and `PhpClass::php_class_name` yields the PHP FQCN. Dropping the `std::error::Error` impls from the exception types leaves `AnyThrowable` as the only route into an `anyhow::Error`, so the walk cannot be bypassed. A `no_exception_downcast` linter catches the `downcast::<X>()` calls that would now silently answer `None`. Three sites change behavior as a result: the `TransportException` exit-code override reaches `MaxFileSizeExceededException`, the `catch (\LogicException)` in findSimilar() reaches its subclasses, and rendered exception titles carry the real class name rather than a guess. `get_class_err()` is no longer a `todo!()`, which re-enables FilesystemRepositoryTest::testCorruptedRepositoryFile. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/repository/vcs_repository.rs')
-rw-r--r--crates/shirabe/src/repository/vcs_repository.rs19
1 files changed, 10 insertions, 9 deletions
diff --git a/crates/shirabe/src/repository/vcs_repository.rs b/crates/shirabe/src/repository/vcs_repository.rs
index 521d7aea..2b811c78 100644
--- a/crates/shirabe/src/repository/vcs_repository.rs
+++ b/crates/shirabe/src/repository/vcs_repository.rs
@@ -28,6 +28,7 @@ use crate::util::ProcessExecutor;
use crate::util::Url;
use indexmap::IndexMap;
use shirabe_external_packages::composer::pcre::Preg;
+use shirabe_php_shim::Catch as _;
use shirabe_php_shim::{
InvalidArgumentException, PhpClass, PhpMixed, php_regex, str_replace, strpos,
};
@@ -305,10 +306,10 @@ impl VcsRepository {
let driver_url = self.url.clone();
self.ensure_driver();
if self.driver.borrow().is_none() {
- return Err(InvalidArgumentException {
- message: format!("No driver found to handle VCS repository {}", driver_url),
- code: 0,
- }
+ return Err(InvalidArgumentException::new(format!(
+ "No driver found to handle VCS repository {}",
+ driver_url
+ ))
.into());
}
*self.version_parser.borrow_mut() = Some(VersionParser::new());
@@ -351,7 +352,7 @@ impl VcsRepository {
}
Ok(None) => {}
Err(e) => {
- if let Some(te) = e.downcast_ref::<TransportException>()
+ if let Some(te) = e.catch::<TransportException>()
&& self.should_rethrow_transport_exception(te)
{
return Err(e);
@@ -367,7 +368,7 @@ impl VcsRepository {
}
}
Err(e) => {
- if let Some(te) = e.downcast_ref::<TransportException>()
+ if let Some(te) = e.catch::<TransportException>()
&& self.should_rethrow_transport_exception(te)
{
return Err(e);
@@ -575,7 +576,7 @@ impl VcsRepository {
Ok(())
})();
if let Err(e) = result {
- if let Some(te) = e.downcast_ref::<TransportException>() {
+ if let Some(te) = e.catch::<TransportException>() {
self.version_transport_exceptions
.borrow_mut()
.entry("tags".to_string())
@@ -589,7 +590,7 @@ impl VcsRepository {
}
}
if is_very_verbose {
- let detail = if let Some(te) = e.downcast_ref::<TransportException>() {
+ let detail = if let Some(te) = e.catch::<TransportException>() {
format!(
"no composer file was found ({} HTTP status code)",
te.get_code()
@@ -786,7 +787,7 @@ impl VcsRepository {
Ok(())
})();
if let Err(e) = result {
- if let Some(te) = e.downcast_ref::<TransportException>() {
+ if let Some(te) = e.catch::<TransportException>() {
self.version_transport_exceptions
.borrow_mut()
.entry("branches".to_string())