fix: propagate ported exceptions instead of flattening them

`ProcessExecutor::execute_args` existed only to turn `execute`'s
`anyhow::Result` into an exit code of 1, so every one of its ~87 call
sites silently took the "command failed" branch on an error PHP would
have thrown. It is gone; callers use `execute` and propagate with `?`.
Where the enclosing function had no `Result` to propagate into, its
signature grew one, up to and including `Git::get_version`,
`Svn::binary_version`, `GitHub`/`GitLab`/`Bitbucket::authorize_oauth`,
`InitCommand::get_git_config` and `DiagnoseCommand::check_git`.

The VCS drivers had the same problem in the other direction: their
`get_contents` returned `Result<Response, Box<TransportException>>`, a
type too narrow for the PHP method, which lets any Throwable out of the
`catch (TransportException $e)` block. Every non-transport error was
therefore rewritten into a `TransportException` with code 0, which the
callers switch on. They now return
`anyhow::Result<Result<Response, Box<TransportException>>>`: the outer
`Result` carries what PHP does not catch, the inner one the exception
the drivers handle.

That signature also restores `GitLabDriver::getContents`: the 400/401
`TransportException`s it raises to force authentication are thrown
inside its own `try` block and handled by its own `catch`, but the port
returned them straight to the caller, so the authentication flow behind
them never ran.

`impl_php_exception!` gains `From<Box<$ty>> for anyhow::Error` so a
caught exception can be re-propagated with `?`.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/crates/shirabe/src/util/filesystem.rs b/crates/shirabe/src/util/filesystem.rs
index 8726df63..bca18771 100644
--- a/crates/shirabe/src/util/filesystem.rs
+++ b/crates/shirabe/src/util/filesystem.rs
@@ -475,7 +475,7 @@ impl Filesystem {
         if Platform::is_windows() {
             // Try to copy & delete - this is a workaround for random "Access denied" errors.
             let mut output = String::new();
-            let result = self.get_process().execute_args(
+            let result = self.get_process().execute(
                 &[
                     "xcopy".to_string(),
                     source.to_string(),
@@ -487,7 +487,7 @@ impl Filesystem {
                 ],
                 &mut output,
                 None,
-            );
+            )?;
 
             // clear stat cache because external processes aren't tracked by the php stat cache
             clearstatcache2(false, "");
@@ -501,11 +501,11 @@ impl Filesystem {
             // We do not use PHP's "rename" function here since it does not support
             // the case where $source, and $target are located on different partitions.
             let mut output = String::new();
-            let result = self.get_process().execute_args(
+            let result = self.get_process().execute(
                 &["mv".to_string(), source.to_string(), target.to_string()],
                 &mut output,
                 None,
-            );
+            )?;
 
             // clear stat cache because external processes aren't tracked by the php stat cache
             clearstatcache2(false, "");
@@ -932,7 +932,7 @@ impl Filesystem {
             Platform::realpath(target),
         ];
         let mut output = String::new();
-        if self.get_process().execute_args(&cmd, &mut output, None) != 0 {
+        if self.get_process().execute(&cmd, &mut output, None)? != 0 {
             return Err(IOException::new(
                 format!(
                     "Failed to create junction to \"{}\" at \"{}\".",