refactor(pcre): return the Preg $matches instead of filling an out-param

`Composer\Pcre\Preg` fills `$matches` through a by-ref parameter, and the
port mirrored that with a `&mut` (or `Option<&mut>`) out-param plus a
bool or count return. Callers had to declare an empty map one line ahead
of the call, and the type never said the map is only meaningful when the
call matched. Return the matches instead:

- match3/match4/is_match3/is_match4 -> Option<PregMatchedGroups>
- is_match_named -> Option<PregNamedGroups>
- match_all2/is_match_all -> PregMatchesAll
- is_match_all_with_offsets3 -> PregMatchesAllWithOffsets

Nothing is lost: the bool is `Option::is_some()`, and the occurrence
count is the length of any one column of a PREG_PATTERN_ORDER map, now
spelled `PregMatchesAll::occurrence_count()`. is_match() still answers
the bool question directly for callers that want no groups.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

1 files changed, 10 insertions, 11 deletions

diff --git a/crates/shirabe/src/util/process_executor.rs b/crates/shirabe/src/util/process_executor.rs
index d87e2ff4..48fa415f 100644
--- a/crates/shirabe/src/util/process_executor.rs
+++ b/crates/shirabe/src/util/process_executor.rs
@@ -216,17 +216,16 @@ impl ProcessExecutor {
         let mut process: Process;
         if is_string(&command) {
             let mut command_str = command.as_string().unwrap_or("").to_string();
-            if Platform::is_windows() {
-                let mut m = PregMatchedGroups::new();
-                if Preg::is_match3(php_regex!(r"{^([^:/\\]++) }"), &command_str, Some(&mut m)) {
-                    let m1 = m.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default();
-                    command_str = substr_replace(
-                        &command_str,
-                        &Self::escape(&Self::get_executable(&m1)),
-                        0,
-                        Some(strlen(&m1)),
-                    );
-                }
+            if Platform::is_windows()
+                && let Some(m) = Preg::is_match3(php_regex!(r"{^([^:/\\]++) }"), &command_str)
+            {
+                let m1 = m.get(&CaptureKey::ByIndex(1)).cloned().unwrap_or_default();
+                command_str = substr_replace(
+                    &command_str,
+                    &Self::escape(&Self::get_executable(&m1)),
+                    0,
+                    Some(strlen(&m1)),
+                );
             }
 
             process = Process::from_shell_commandline(