aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/util
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-09 11:24:48 +0900
committernsfisis <nsfisis@gmail.com>2026-08-09 11:24:48 +0900
commit596482de82ff32705e85f18c1c9ae784e6cd2c6f (patch)
tree6a970fa30f7770d702d3f6c53232c123d0478d16 /crates/shirabe/src/util
parent738a258496318edb6e264b13b8a6d0dc313795d3 (diff)
downloadphp-shirabe-596482de82ff32705e85f18c1c9ae784e6cd2c6f.tar.gz
php-shirabe-596482de82ff32705e85f18c1c9ae784e6cd2c6f.tar.zst
php-shirabe-596482de82ff32705e85f18c1c9ae784e6cd2c6f.zip
refactor(xdebug-handler): extract composer/xdebug_handler into the shirabe-xdebug-handler crate
Move `Composer\XdebugHandler` out of shirabe-external-packages and into its own crate, so the path is `shirabe_xdebug_handler::XdebugHandler` instead of `shirabe_external_packages::composer::xdebug_handler::XdebugHandler`. Standing alone, the stub no longer sits in a crate that shirabe-php-rpc depends on, so drop the dependency-cycle rationale from the comments that explain why callers reach for shirabe_php_rpc directly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/util')
-rw-r--r--crates/shirabe/src/util/ini_helper.rs7
1 files changed, 3 insertions, 4 deletions
diff --git a/crates/shirabe/src/util/ini_helper.rs b/crates/shirabe/src/util/ini_helper.rs
index c36b9189..4ff9a5e2 100644
--- a/crates/shirabe/src/util/ini_helper.rs
+++ b/crates/shirabe/src/util/ini_helper.rs
@@ -5,10 +5,9 @@ pub struct IniHelper;
impl IniHelper {
/// Returns an array of php.ini locations with at least one entry.
pub fn get_all() -> Vec<String> {
- // PHP: XdebugHandler::getAllIniFiles(). shirabe_external_packages::XdebugHandler's port
- // of that method can't reach the PHP RPC bridge (shirabe-php-rpc already depends on
- // shirabe-external-packages, so the reverse dependency would cycle), so query the real
- // PHP runtime's loaded/scanned ini files here instead.
+ // PHP: XdebugHandler::getAllIniFiles(). shirabe_xdebug_handler::XdebugHandler's port
+ // of that method is a stub that returns the PHP default, so query the real PHP
+ // runtime's loaded/scanned ini files here instead.
shirabe_php_rpc::get_all_ini_files()
}