diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-19 23:45:38 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-19 23:45:38 +0900 |
| commit | cd7c3fce2472656b2a1247429751e43350976677 (patch) | |
| tree | 95e8760e3417fc3e63dac28bc0cd823a6af768f2 /crates/shirabe/src/util | |
| parent | b8fb046bd7c4cd28598bcce9f3955d834ea5d008 (diff) | |
| download | php-shirabe-cd7c3fce2472656b2a1247429751e43350976677.tar.gz php-shirabe-cd7c3fce2472656b2a1247429751e43350976677.tar.zst php-shirabe-cd7c3fce2472656b2a1247429751e43350976677.zip | |
perf(package): hand out link maps behind Rc
PackageInterface::getRequires() and friends return the array of Link objects;
in PHP that is a copy-on-write array of object references, so a caller pays
nothing to look at it. The port returned IndexMap<String, Link> by value, so
every call deep-cloned the whole map, keys and constraints included. Pool
building calls these accessors once per package per candidate, which put
IndexMap::clone at 13.5% of `require laravel/laravel`.
Store the maps as Rc<IndexMap<String, Link>> and return a handle. Callers that
mutate the map clone it explicitly at the point of mutation, matching where PHP
would separate the array.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/util')
| -rw-r--r-- | crates/shirabe/src/util/package_sorter.rs | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/crates/shirabe/src/util/package_sorter.rs b/crates/shirabe/src/util/package_sorter.rs index 5687a339..9770375b 100644 --- a/crates/shirabe/src/util/package_sorter.rs +++ b/crates/shirabe/src/util/package_sorter.rs @@ -43,9 +43,14 @@ impl PackageSorter { let mut usage_list: IndexMap<String, Vec<String>> = IndexMap::new(); for package in &packages { - let mut links: IndexMap<String, Link> = package.get_requires(); + let mut links: IndexMap<String, Link> = (*package.get_requires()).clone(); if let Some(root_package) = package.as_root() { - links.extend(root_package.get_dev_requires()); + links.extend( + root_package + .get_dev_requires() + .iter() + .map(|(k, v)| (k.clone(), v.clone())), + ); } for link in links.values() { let target = link.get_target().to_string(); |
