diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-12 01:20:33 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-12 01:20:33 +0900 |
| commit | 3e2613f70ebdb441269556d1080a69a1f21a4f7d (patch) | |
| tree | c1f60a8d5deb5518506d7d59674c953957dc0990 /crates/shirabe/tests/all_functional_test.rs | |
| parent | 0779bfe8c7b5ee22034d552477cac54e8ae2895f (diff) | |
| download | php-shirabe-3e2613f70ebdb441269556d1080a69a1f21a4f7d.tar.gz php-shirabe-3e2613f70ebdb441269556d1080a69a1f21a4f7d.tar.zst php-shirabe-3e2613f70ebdb441269556d1080a69a1f21a4f7d.zip | |
test: drop stale #[ignore]s and rewrite the run-script reasons
Measuring every ignored test with `cargo test --workspace
--no-fail-fast -- --ignored` turned up 11 that pass today; their
reasons named todo!()s and gaps that have since been implemented.
The two run_script_command_test cases still fail, but not for the
reason given: the user's Command class is imported and executed, and
what is missing is only a way to observe it, since PhpCommandProxy::run
forwards the run to the worker-side console application.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/all_functional_test.rs')
| -rw-r--r-- | crates/shirabe/tests/all_functional_test.rs | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/crates/shirabe/tests/all_functional_test.rs b/crates/shirabe/tests/all_functional_test.rs index a05a575a..f9059927 100644 --- a/crates/shirabe/tests/all_functional_test.rs +++ b/crates/shirabe/tests/all_functional_test.rs @@ -259,11 +259,6 @@ fn test_integration_create_project_command() { #[test] #[serial] -#[ignore = "needs live network (real git clone from github.com). The two former in-process \ - blockers are fixed: the scheme-less packages.json read via RemoteFilesystem::\ - get_remote_contents, and the exit-101 panic during CreateProjectCommand's keep-vcs \ - cleanup, whose Symfony Finder name patterns go through Glob::to_regex (now \ - regex-crate-compatible); a full green run is unverified because it requires network"] fn test_integration_create_project_shows_full_hash_for_dev_packages() { run_integration("create-project-shows-full-hash-for-dev-packages.test"); } @@ -284,7 +279,6 @@ fn test_integration_installed_versions2() { #[test] #[serial] -#[ignore = "requires the Plugin API (PHP plugins emitting !! markers), which is not yet implemented"] fn test_integration_plugin_autoloading_only_loads_dependencies() { run_integration("plugin-autoloading-only-loads-dependencies.test"); } |
