diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-12 01:20:33 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-12 01:20:33 +0900 |
| commit | 3e2613f70ebdb441269556d1080a69a1f21a4f7d (patch) | |
| tree | c1f60a8d5deb5518506d7d59674c953957dc0990 /crates/shirabe/tests/application_test.rs | |
| parent | 0779bfe8c7b5ee22034d552477cac54e8ae2895f (diff) | |
| download | php-shirabe-3e2613f70ebdb441269556d1080a69a1f21a4f7d.tar.gz php-shirabe-3e2613f70ebdb441269556d1080a69a1f21a4f7d.tar.zst php-shirabe-3e2613f70ebdb441269556d1080a69a1f21a4f7d.zip | |
test: drop stale #[ignore]s and rewrite the run-script reasons
Measuring every ignored test with `cargo test --workspace
--no-fail-fast -- --ignored` turned up 11 that pass today; their
reasons named todo!()s and gaps that have since been implemented.
The two run_script_command_test cases still fail, but not for the
reason given: the user's Command class is imported and executed, and
what is missing is only a way to observe it, since PhpCommandProxy::run
forwards the run to the worker-side console application.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/application_test.rs')
| -rw-r--r-- | crates/shirabe/tests/application_test.rs | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/crates/shirabe/tests/application_test.rs b/crates/shirabe/tests/application_test.rs index 257bc861..1c93b790 100644 --- a/crates/shirabe/tests/application_test.rs +++ b/crates/shirabe/tests/application_test.rs @@ -145,9 +145,6 @@ fn test_process_isolation_works_multiple_times() { assert_eq!(0, application.do_run(input2, output2).unwrap()); } -#[ignore = "Application::do_run registers the composer.json script as a command, a path that ends at a todo!() \ - (application.rs:2461, 'plugin: register reflection-instantiated command on Application::add'). With a \ - 'scripts' key present, do_run panics there before getComposer is reached"] #[test] #[serial] fn test_no_plugins_disables_plugins_when_script_commands_exist() { @@ -213,9 +210,6 @@ fn test_no_plugins_disables_plugins_when_script_commands_exist() { ); } -#[ignore = "Application::do_run registers composer.json scripts as commands; that path ends at a todo!() \ - (application.rs:2461, 'plugin: register reflection-instantiated command on Application::add'). With a \ - 'scripts' key present, do_run panics there before the script command executes"] #[test] #[serial] fn test_script_command_takes_priority_over_abbreviated_builtin_command() { |
