diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-12 01:20:33 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-12 01:20:33 +0900 |
| commit | 3e2613f70ebdb441269556d1080a69a1f21a4f7d (patch) | |
| tree | c1f60a8d5deb5518506d7d59674c953957dc0990 /crates/shirabe/tests/command/base_dependency_command_test.rs | |
| parent | 0779bfe8c7b5ee22034d552477cac54e8ae2895f (diff) | |
| download | php-shirabe-3e2613f70ebdb441269556d1080a69a1f21a4f7d.tar.gz php-shirabe-3e2613f70ebdb441269556d1080a69a1f21a4f7d.tar.zst php-shirabe-3e2613f70ebdb441269556d1080a69a1f21a4f7d.zip | |
test: drop stale #[ignore]s and rewrite the run-script reasons
Measuring every ignored test with `cargo test --workspace
--no-fail-fast -- --ignored` turned up 11 that pass today; their
reasons named todo!()s and gaps that have since been implemented.
The two run_script_command_test cases still fail, but not for the
reason given: the user's Command class is imported and executed, and
what is missing is only a way to observe it, since PhpCommandProxy::run
forwards the run to the worker-side console application.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/command/base_dependency_command_test.rs')
| -rw-r--r-- | crates/shirabe/tests/command/base_dependency_command_test.rs | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/crates/shirabe/tests/command/base_dependency_command_test.rs b/crates/shirabe/tests/command/base_dependency_command_test.rs index 41ad362d..ace43ae7 100644 --- a/crates/shirabe/tests/command/base_dependency_command_test.rs +++ b/crates/shirabe/tests/command/base_dependency_command_test.rs @@ -445,7 +445,6 @@ fn test_why_command_outputs() { /// ref: BaseDependencyCommandTest::testWhyNotCommandOutputs (caseWhyNotProvider rolled in). #[test] #[serial] -#[ignore = "panics in shirabe_php_shim::runtime::trigger_error (crates/shirabe-php-shim/src/runtime.rs:435 todo!()): emitting a PHP error obeys error_reporting and the installed error handler (runtime state not modeled), reached on the `why-not` command execution path"] fn test_why_not_command_outputs() { // caseWhyNotProvider: (package, version, expected_output, expected_status_code) let cases: Vec<(&str, &str, &str, i32)> = vec![ |