aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/command/clear_cache_command_test.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-19 23:45:37 +0900
committernsfisis <nsfisis@gmail.com>2026-08-19 23:45:37 +0900
commit0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc (patch)
treeba5602549ce20b8d71136423e85dffc25deafff4 /crates/shirabe/tests/command/clear_cache_command_test.rs
parent6ed3a85dd636366d194c9810fd777db7f25e263f (diff)
downloadphp-shirabe-0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc.tar.gz
php-shirabe-0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc.tar.zst
php-shirabe-0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc.zip
fix(input): thread a typed InputValue through the input layer
Options and arguments were stored and passed as PhpMixed even though Symfony only ever puts a string, a bool, a list of strings or null in one. get_option already narrowed to InputOptionValue at the boundary; this widens that enum into InputValue and pushes it through InputInterface, InputOption/InputArgument defaults, the Input storage, ArgvInput/ArrayInput/StringInput/CompletionInput, Command::add_option and add_argument, and the Composer-side wrappers. Two neighbouring string|int unions get types of their own: InputDefinition::{get_argument,has_argument} take an ArgumentName, and ArrayInput keys its parameters by ParameterName. has_parameter_option and get_parameter_option take the values they look for as &[&str], which is what PHP's `(array) $values` cast produced anyway. Two behaviours change along the way. Input::set_option on a negated option now negates with PHP's loose bool cast rather than treating a non-bool as false, matching `!$value`. ArrayInput::parse now resolves an integer key to an argument position instead of looking up an argument literally named "0". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/command/clear_cache_command_test.rs')
-rw-r--r--crates/shirabe/tests/command/clear_cache_command_test.rs22
1 files changed, 16 insertions, 6 deletions
diff --git a/crates/shirabe/tests/command/clear_cache_command_test.rs b/crates/shirabe/tests/command/clear_cache_command_test.rs
index b1855799..b25200f5 100644
--- a/crates/shirabe/tests/command/clear_cache_command_test.rs
+++ b/crates/shirabe/tests/command/clear_cache_command_test.rs
@@ -3,7 +3,8 @@
use crate::test_case::{RunOptions, get_application_tester};
use serial_test::serial;
use shirabe::util::platform::Platform;
-use shirabe_php_shim::PhpMixed;
+use shirabe_symfony_console::input::InputValue;
+use shirabe_symfony_console::input::ParameterName;
fn tear_down() {
// --no-cache triggers the env to change so make sure the env is cleaned up after these tests run
@@ -26,7 +27,10 @@ fn test_clear_cache_command_success() {
let mut app_tester = get_application_tester();
app_tester
.run(
- vec![(PhpMixed::from("command"), PhpMixed::from("clear-cache"))],
+ vec![(
+ ParameterName::of("command"),
+ InputValue::from("clear-cache"),
+ )],
RunOptions::default(),
)
.unwrap();
@@ -50,8 +54,11 @@ fn test_clear_cache_command_with_option_garbage_collection() {
app_tester
.run(
vec![
- (PhpMixed::from("command"), PhpMixed::from("clear-cache")),
- (PhpMixed::from("--gc"), PhpMixed::Bool(true)),
+ (
+ ParameterName::of("command"),
+ InputValue::from("clear-cache"),
+ ),
+ (ParameterName::of("--gc"), InputValue::Bool(true)),
],
RunOptions::default(),
)
@@ -76,8 +83,11 @@ fn test_clear_cache_command_with_option_no_cache() {
app_tester
.run(
vec![
- (PhpMixed::from("command"), PhpMixed::from("clear-cache")),
- (PhpMixed::from("--no-cache"), PhpMixed::Bool(true)),
+ (
+ ParameterName::of("command"),
+ InputValue::from("clear-cache"),
+ ),
+ (ParameterName::of("--no-cache"), InputValue::Bool(true)),
],
RunOptions::default(),
)